Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a2ba37f2-d498-6958-eb96-5bbfc8b2151c@prevas.dk>
Date:   Thu, 10 Aug 2023 10:29:51 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH 1/2] drm/exec: use unique instead of local label
Content-Language: en-US, da
To:     Nick Desaulniers <ndesaulniers@google.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <ckoenig.leichtzumerken@gmail.com>
Cc:     boris.brezillon@collabora.com, maarten.lankhorst@linux.intel.com,
        mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com,
        daniel@ffwll.ch, trix@redhat.com, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
        naresh.kamboju@linaro.org, dakr@redhat.com
References: <20230731123625.3766-1-christian.koenig@amd.com>
 <CAKwvOdmRm=vOjNXGWeuKw-h78CXMrkcwc5vnCRVqFxMxWzhCcg@mail.gmail.com>
From:   Rasmus Villemoes <rasmus.villemoes@prevas.dk>
In-Reply-To: <CAKwvOdmRm=vOjNXGWeuKw-h78CXMrkcwc5vnCRVqFxMxWzhCcg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cytXZ2JSMlpuYmdodEhqZW5HcHJLdjBOdHhNUGY0OWlEczZvYStDV2g2REZ1?=
 =?utf-8?B?OXRzdkE2d09WKzdLNTJRYm1lNHc5dmtzclNmZmtPWGJtU2krdHJJa0hQR1Av?=
 =?utf-8?B?cGxBa0tNYzNjVTlZTVU2WTFwMGdXdXFuT01mUWlONWFIS1hmVENBL2pyU0t1?=
 =?utf-8?B?ZkFJU0pKOUVtOE1UekZ2SmpEOVgvSFIyWVo0YU5SRFJncC8xRXBpUE0vaDBK?=
 =?utf-8?B?NkFFa1dqRHoxYjRzVURDaFo5WGRMcnpCY1pmbDArQzRoU0NGQlZkNFJ1WHBS?=
 =?utf-8?B?WS84aW9aMVJZS0NkWXZjSEdpZmRaRTFMdGZsK0dEYURDVDh6blF4WTVJWThQ?=
 =?utf-8?B?VkRtR3hGSWpYOHQzVVNHaEIxNGpybUtnSFRLTmtoZUFTZm9jaG11Mmg5OURP?=
 =?utf-8?B?RWhqR2VTRGQ5QXhWWGZidnA2RHoxbUVFUUJHTEFtV1lzMDNnc0UyQ2djODF3?=
 =?utf-8?B?bnJGNmdRL1VUSEx0NnZmY0lkNkh6b0ozR2I4NmxDSXRBdU96emM3dW1nOVM3?=
 =?utf-8?B?cDFxZ1pPTGNEM1VCYmp5Q3hra3hRckNOQW1oN0xqRmZEL0E4VEhjeVYrQnNj?=
 =?utf-8?B?Ny9vMjJCSkhiUWlYalZ2eFN5VnJkTHRaeTV3Y3RZUkdsVjBnblNGVmUyUXl5?=
 =?utf-8?B?NXdLNWZ5REdRalBkZ0MxeHFENzlEdGl4S2RmdVl3c3N1bmZmemNrUkdXQU1Q?=
 =?utf-8?B?NTlOa1E2WkRsV2o4eTZ3MitucXZUdDJmM0lyZ2VWUjRmd0dhUFJPOTd6RmVF?=
 =?utf-8?B?VlNTMUFvaVJQemZwL3Z3eHVWMjVFTVVaUUlxMFV1dm1sVGNoczZ4YmxJbDBP?=
 =?utf-8?B?UlJzK2phL1h0ektnNnFzNVp3aW0wVVBRcXhOM085bkZDVHdFUkhoQ3lIT25s?=
 =?utf-8?B?V1JwOUJ2OUhLV3JrRlQ1U1RBZU9sQTA0NjJIM0dGWC9RQ211a0I2T3VBczBJ?=
 =?utf-8?B?dFV5MDBFU0wyaE5mTjltTzZtZzdSTUg0c3ZxOTlYckx4ZExpWjhHdERJYkJa?=
 =?utf-8?B?TkpmWTFudERmUFhVTHp6OVV3S2NFWTJOcFJaNWNoR25zaEQ1MjBhR0ovanpv?=
 =?utf-8?B?dDUwclNJTWp1Uk5wRnlRQkRlVk1Xc1ZKN05ONld5WDZYVWNxQmtLaTlnOEs2?=
 =?utf-8?B?bzZJenIzbk1RZ1F0YlUwSXAreksxSjgveHpsb2FlelEza0pFLzllMXB3YUta?=
 =?utf-8?B?MFBjTXRCaUxLSXB6eElVRzRIZ29SS1psTUNtQTlCeGZOZ3ZjL252VWFCY2lT?=
 =?utf-8?B?WEgvKzlXUVBvczUwNVE1ZmlHREZ3NXVWL296eVpjNjRETHY2c2RzaUVIZEZ1?=
 =?utf-8?B?MnBZWkdzNVhMSHBxbkEwcHJNbjlxNS9paEZhVDg2R0RNSCtxOFdYWWZqMHls?=
 =?utf-8?B?YStzdEFrYTFob3dqa3pMc1F5VGdnMTk4MmxvalhnM041RGxTcWJPNElHWHhn?=
 =?utf-8?B?bkUxRm43R1hWWGJhRit3bVAxOFlnTTVEQjFPcTZsK3E3Q2FIYTBrZUE1aERw?=
 =?utf-8?B?Yyt6dGFEM0NmNDdLZ1N4YVYrMEFZdUxEampXdlMxMXpIUE9ndEh0dnlSL0JJ?=
 =?utf-8?B?Q2V1K1BLWVUwVE5jUjZjQ0themlUUkJKajNVNy9aUXdpc0VlclZnM2FqSWpN?=
 =?utf-8?B?M0M5VW9XTUlWbHA5VnhuL1pkeEFBZytFeG5CMmdyQTFsQVFxU2dkajJiQXFO?=
 =?utf-8?B?OFczWkR5TzZaV1hUMjhxWVhsU251aWo5Ujc2RWt3bkh3Tks4TDZMR3Q0NjdS?=
 =?utf-8?B?OUk2WUVSUko5MWUxcGsvU3FuMnNxVlFFT1MySzMwMGFycVlheEwwRWNkd2Ro?=
 =?utf-8?B?cmtWekU0cXJ5M3lFUkNXc1MxM3NTUjkxMGwrWHNyTEl2ZDhNRjVFOG0xTitO?=
 =?utf-8?B?dndBMzBnUlFYcW5ZT3VxV3RjN1pUSmJYTitaUEZtV2N1eWFiMmU1YkhlcVUy?=
 =?utf-8?B?T20vc2dWYjErT2F2RWU5WjZjSzQ4dEU0b3RzSkN5QVQxMC9aTG1LY3N3anBH?=
 =?utf-8?B?LzdSbGp4SFlYMVFVU3huSnFKVkJYK0pRc0tpU0N1bjAyalBFajQwck05SGlr?=
 =?utf-8?B?Zm1QUUNvSWFxbDNoU2NnYThlcjd2TmFsclZKWHdMOGRkZFB5Y1l1TmlkMnJM?=
 =?utf-8?B?T05OUjkvbjl0M2tIWHhxUnFac3BCNmRjM216YVRnT3RkdlYvemtWMUNHaURB?=
 =?utf-8?B?ZGc9PQ==?=
X-OriginatorOrg: prevas.dk
X-MS-Exchange-CrossTenant-Network-Message-Id: ff752d07-7978-4362-a3d0-08db997bf955
X-MS-Exchange-CrossTenant-AuthSource: DB9PR10MB7100.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 08:29:54.7632
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: d350cf71-778d-4780-88f5-071a4cb1ed61
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ctuRAegWWqQckCKyTW96Dpsfl6K4kaUYSq5TsdFd5Wo7qbnzTTOklGeyrz9kzd2a4kQIOeShK4kniUyF+pf5PAM43HLbUi0EHLjY6mnzNA8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR10MB3769
X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 01/08/2023 22.35, Nick Desaulniers wrote:

> I suspect it's possible to change the indirect goto into a direct goto
> with some further refactoring (macros can take block statements; 

Well, with some somewhat subtle restrictions. C99, 6.10.3.11. "The
sequence of preprocessing tokens bounded by the outside-most matching
parentheses forms the list of arguments for the function-like macro. The
individual arguments within the list are separated by comma
preprocessing tokens, but comma preprocessing tokens between matching
inner parentheses do not separate arguments."

cpp doesn't care about the {} tokens when trying to figure out what
constitutes the "block" argument, so if that block contained any comma
outside a () pair, cpp would barf something like

  error: macro "foo" passed 3 arguments, but takes just 2

So while the commas inside function calls (and other macro invocations)
are fine, constructs like

  int x, y;

or

  struct s s = {.a = 3, .b = 4}

would be verboten inside that block.

One way around that is to make block a variadic argument so it just
gobbles up all preprocessor token. Or have the users pass a statement
expression instead of a block.

Rasmus