Received: by 2002:a05:6358:51dd:b0:131:369:b2a3 with SMTP id 29csp848320rwl; Thu, 10 Aug 2023 02:33:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG8BFagG3Eih+oZw4XVsYohlQhNKDjOXVSwXOofJYLtuKSHc9OMyFC+kR9mbvAOMkOZvkoi X-Received: by 2002:a05:6402:35d5:b0:521:ef0f:8ef9 with SMTP id z21-20020a05640235d500b00521ef0f8ef9mr1909206edc.19.1691660015257; Thu, 10 Aug 2023 02:33:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691660015; cv=none; d=google.com; s=arc-20160816; b=Z6HsDisQakt/XRS+9n/kIDlg4HaJ2+M1EKHx2H6gBhKT2abACp4wPnUN+n2Z/Rn/61 3OU2MD+ph+eiJzEF/Y/nlTKUnPMnKzp/Vn5Goe/zKhmVliTY/eq1FeYeSMc76qAmnnr2 BDeJ2lGJvDI3zLFT+QEw6hVgm4gqgQF6RzMcv9CyijhUgRuET7JYSwuh0UaENk7y8ij0 GxTOcx05TX6vt2NLQ8ZADhVC1aBSC8apsZxbXIx/Dy1hkbl2ZN+KpYBx8l9h2nhwTqwv B1QHIrXozM6bPOUfkvYls679K2Y7w89CaZfDuDZ8bXZQ7pPVCIyrOX4Df6Eh9WFBsWsv Qblg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=4pNiKuPmDyWwwvfu9rKcDB19AC9Yolj8ezpQ2UeqOHE=; fh=k7XzfpyqnKqnwxpqVF0NftrWa2FIpeAcHVbykF5xarA=; b=xeuRSAVxzxb8OBnsFxsGhp2a6PJO16c3r9KpIF04bJpTbTpLGZAvr2wMMZ1PLbev5u VtjjJ0eS4OOptUejdzeWWzS+eS/kuaBnPtx7UFUHgwTJ+BA0f3/LbwB8eSPnbCIKk21a 64B50xdVgvJvq5N427EDp5yQ6AqY9Ly2EWOWGqMzmM4Dd1k7ukip2Rpwv5YoS61+Ig5p B9y+Hfs0QgiuSLvxXg7fqTdblvNXHrMjOAuJPsYyMpHKoM8amT3Bf1pamZmxlMTYt4Zx enA01y+EeQdYiR0PbcHnenquJEu3XNzbkB6CDPpUpdMJMpxo1AdiHj43hGNwJgW/GKa4 uqWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LV4M+mX1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s19-20020aa7c553000000b005233e4533bcsi1155186edr.405.2023.08.10.02.32.57; Thu, 10 Aug 2023 02:33:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LV4M+mX1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234578AbjHJJRT (ORCPT + 99 others); Thu, 10 Aug 2023 05:17:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234229AbjHJJQf (ORCPT ); Thu, 10 Aug 2023 05:16:35 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA9973AA0; Thu, 10 Aug 2023 02:16:02 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 82646654E4; Thu, 10 Aug 2023 09:16:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6CFFC433BB; Thu, 10 Aug 2023 09:16:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691658962; bh=9QHODcZM6KKrgHiwTBHLES0drVEZoPScIy4Zc+1uY7U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LV4M+mX17H/l62Y8F0htkILTVvHc8End0nfp4b6Da2Yv59kFUo6ruj+1jgNQDcPcL bEMUVjHoLQGmQV7WaF4RCa2IIkcseaWUE0c8b+hkKxgKilfqOVQLeuUZxr1F403lQ5 PIAWg4wpd/85K7c7aS0EDgIDJkLA7qollbgW/AGapkfJwmNrQDewzQHrMcegNbfOAG RIZ7+fRH0weBi8Blk9D1MvRb+rP4LFr8xPygL4RTyy5OtvGxC7k/attTUGRsgFnNf3 gehTGnIVTbaR0eaPFStVZnt1BCk/A0sJ9zKi1QJ1iCG/t0SumZFzLG3ZtccJBM+Mnw dheXEGy0ytwRw== From: "Jiri Slaby (SUSE)" To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" Subject: [PATCH 19/36] tty: make char_buf_ptr()/flag_buf_ptr()'s offset unsigned Date: Thu, 10 Aug 2023 11:14:53 +0200 Message-ID: <20230810091510.13006-20-jirislaby@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230810091510.13006-1-jirislaby@kernel.org> References: <20230810091510.13006-1-jirislaby@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The offset is meant from the beginning of data, so unsigned. Make it as such for clarity. All struct tty_buffer's members should be unsigned too -- see the next patch. Signed-off-by: Jiri Slaby (SUSE) --- include/linux/tty_buffer.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/tty_buffer.h b/include/linux/tty_buffer.h index b11cc8c749d2..391a875be20c 100644 --- a/include/linux/tty_buffer.h +++ b/include/linux/tty_buffer.h @@ -22,12 +22,12 @@ struct tty_buffer { unsigned long data[]; }; -static inline u8 *char_buf_ptr(struct tty_buffer *b, int ofs) +static inline u8 *char_buf_ptr(struct tty_buffer *b, unsigned int ofs) { return ((u8 *)b->data) + ofs; } -static inline u8 *flag_buf_ptr(struct tty_buffer *b, int ofs) +static inline u8 *flag_buf_ptr(struct tty_buffer *b, unsigned int ofs) { return char_buf_ptr(b, ofs) + b->size; } -- 2.41.0