Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Xiaolei Wang <xiaolei.wang@windriver.com>
To:     catalin.marinas@arm.com, akpm@linux-foundation.org,
        glider@google.com, andreyknvl@gmail.com, vbabka@suse.cz,
        zhaoyang.huang@unisoc.com
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] mm/kmemleak: No need to check kmemleak_initialized in set_track_prepare()
Date:   Thu, 10 Aug 2023 15:47:04 +0800
Message-Id: <20230810074704.2042664-3-xiaolei.wang@windriver.com>
In-Reply-To: <20230810074704.2042664-1-xiaolei.wang@windriver.com>
References: <20230810074704.2042664-1-xiaolei.wang@windriver.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?clKAeswkRpOgZG09A2/0hYWRDPzptEa9kK279DXCfG8ftj1aIkKGwCbHTJpA?=
 =?us-ascii?Q?Rc9zDI3K0wuI+t9sMerAb7ZY9dOhXtQfStBpnNMibkYseR3kxTHgfDJasZqc?=
 =?us-ascii?Q?+AAy0VM7yzOZFosLZeZMlOz0VSUFkubtWW/CuIqvask2bj+Y1V3ITAUqLm82?=
 =?us-ascii?Q?v4Eomxet5l0FpW0hXbIje5BWqFU6DflgKXrSnuucZ0fNkSlsyeNmbcq4nXUA?=
 =?us-ascii?Q?SfXXGveJEN3DFTbJ2VIr2+caXexIo84tHrS+2SbbOuxkIRvRLktSI0iOYnak?=
 =?us-ascii?Q?ZBUWhSV9KYrfx/izrrL97K6jYzhRL6RugzcTxZpyS22IF3jof8cNRbR71Kez?=
 =?us-ascii?Q?+Y4BJNT068IRhlFKhzhgeKihpA8d2YHb4wiv6rHvKQwW2YNd+s1YJSIbxzQO?=
 =?us-ascii?Q?Rs41vYQg4DS71E/aWJ74eppQY8e73B7TAtkU9Obr5eDkrpirhddp+M2izYTq?=
 =?us-ascii?Q?WTbyrgb74b4JFfDMUfn7TxPh7kUewo9NdDeZIJvX7XT3CsLxVZ6nGMF+NTET?=
 =?us-ascii?Q?rsRW9ZnXgVvaB0DLf6AwZSkv3mzV9f+YAZmFlSYWNATWSOrPTOx1KV/ihCsm?=
 =?us-ascii?Q?VV3PzY3yCCoQ85MYQSQ/dtwJnSh3G/YsDJDW321q0btHP6KgWB+X/3vEtpxa?=
 =?us-ascii?Q?VBvPeduMT4Xze0Ju7USvIGI+d94y7cvLGeELhcMs05cr6Go+ZIU04JINv+8i?=
 =?us-ascii?Q?0cc8EOOHPuC/hCJPrdZD5i90i+RT+wmsHcC5RjL3qNZ4wU2t50N33uRfwdfP?=
 =?us-ascii?Q?gBgjHBXkf3mc9wuIt/CSRbOUWCwCkZ+faIBD0kZobpK1AbTlRrDgbAV+2spN?=
 =?us-ascii?Q?KlvjKRwxb8AlXPSN7H1RzBh+GMwtlxHPspK5BtY6+VFsytiDamM1UO5Jby5W?=
 =?us-ascii?Q?5NkxHUUnVcRoF98QALFptXHIVtBAsh1bWWKMKi+a27EPFegrpSSmE4/OStJR?=
 =?us-ascii?Q?M4iB+MMwFLb1qCmULsG6wYF2KBxPUzQ6Y4g1pf9ZOjoKR61sPmSw9NY8VRtV?=
 =?us-ascii?Q?lZv9HFRWYcH7apcIzBjwGZebzCzYBJLf9xLBEWns0vqM86KJ7I5h3oqb2rgf?=
 =?us-ascii?Q?l3gI3+wjma3fYfrr3PcpfwNczRiawbDnTFf2w8XGVLUr2VwmvWGgjO78HqmG?=
 =?us-ascii?Q?t5DfqjLyNreKN7j0Uo78xf6uy8/2c0PSXO7objYIFBNFSRVhHzIB4acLKyHZ?=
 =?us-ascii?Q?DeRRGxsU/E2aHIpHR+Su9nVRXEnDU9zvcPZH3gMp5FBO5J2B0cs9G2MCSeBF?=
 =?us-ascii?Q?YvYJ4UeulLOFtD8DGpyVmB+1lX71itq6QOqp+iUmyneTL8Sc8KtEH/pTp0on?=
 =?us-ascii?Q?Phlmhq+GIHNlwyjkbmI/L7Qinseb8VrK5xwyEsaJZvaRxJ+uS6mJGu8eTxDz?=
 =?us-ascii?Q?awUuwAc3vRiK9P086MDIKVrvi7wkXXvHRNxLHSGYIuPmxzvLirOMu/hESCK8?=
 =?us-ascii?Q?B0zQOfe93EkXFM51TbtJHHAbHxdb87na+EHtttBj9QQiof/QWVUrEy/prTW9?=
 =?us-ascii?Q?piNrsecs92GfD5KfB5EUv4oZJYuSgBtmMMrF6UlKP8AL6HAOBqnoCiLoykw5?=
 =?us-ascii?Q?PR/+YznRyqszYY9pbTxObnrpH1Bs3M5Edvyj9cIf/UlXOIHTAKS4Kv6kd3Rj?=
 =?us-ascii?Q?Cg=3D=3D?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1f03e3fe-dcfb-45f0-ca62-08db99760bd8
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5769.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 07:47:28.9289
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +6+3MACJ+vZiYVgDlY20LeF2bT7YK7hRRtcsXHjWPNXGBqT/ZHELxSJbboyCayMiVoeMaICrKEJ9HAWsGguiAeeUlUswhT63bPq+z5AEVy8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7497
X-Proofpoint-GUID: Yc2pXsIeBXjHWopBqFppm6UGCUQoORty
X-Proofpoint-ORIG-GUID: Yc2pXsIeBXjHWopBqFppm6UGCUQoORty
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-08-10_07,2023-08-09_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0
 lowpriorityscore=0 priorityscore=1501 spamscore=0 mlxscore=0
 malwarescore=0 bulkscore=0 mlxlogscore=674 clxscore=1015 phishscore=0
 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.19.0-2306200000 definitions=main-2308100064
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The kmemleak_late_init() is defined as a late_initcall. The current
implementation of set_track_prepare() depends on the kmemleak init.
That also means there is no call trace for the memory leak which object
is created before the kmemleak_late_init().


In a previous patch, we have fixed a bug in stack_depot_save() so that
it can be invoked even before stack depot is initialized. So there is
no reason to check the kmemleak_initialized in set_track_prepare().
So delete the kmemleak_initialized judgment in set_track_prepare()

unreferenced object 0xc674ca80 (size 64):
  comm "swapper/0", pid 1, jiffies 4294938337 (age 204.880s)
  hex dump (first 32 bytes):
    80 55 75 c6 80 54 75 c6 00 55 75 c6 80 52 75 c6 .Uu..Tu..Uu..Ru.
    00 53 75 c6 00 00 00 00 00 00 00 00 00 00 00 00 .Su..........

Fixes: 56a61617dd22 ("mm: use stack_depot for recording kmemleak's backtrace")
Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
---
 mm/kmemleak.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/mm/kmemleak.c b/mm/kmemleak.c
index a2d34226e3c8..c9f2f816db19 100644
--- a/mm/kmemleak.c
+++ b/mm/kmemleak.c
@@ -610,8 +610,6 @@ static noinline depot_stack_handle_t set_track_prepare(void)
 	unsigned long entries[MAX_TRACE];
 	unsigned int nr_entries;
 
-	if (!kmemleak_initialized)
-		return 0;
 	nr_entries = stack_trace_save(entries, ARRAY_SIZE(entries), 3);
 	trace_handle = stack_depot_save(entries, nr_entries, GFP_NOWAIT);
 
-- 
2.25.1