Received: by 2002:a05:6358:51dd:b0:131:369:b2a3 with SMTP id 29csp901950rwl; Thu, 10 Aug 2023 03:34:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGCMD0TCnSBAqUMa4ixdN59FKWit4X/PA2Z1LQeSO6/BtBHGBzeU2Rf5p/eT2Jg+LpZqHnd X-Received: by 2002:a50:ef05:0:b0:522:4dd0:de72 with SMTP id m5-20020a50ef05000000b005224dd0de72mr1547662eds.27.1691663653932; Thu, 10 Aug 2023 03:34:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691663653; cv=none; d=google.com; s=arc-20160816; b=Dqt6MDrZ2Cjroow3ECFMQaOu1vXJ2QEtjH5W7rMs9iKziGcylPJx5Zpv6/UURkIi40 9TcfznCPMW64MtdChwFWnjDM+Un5SoEZYRBfDt6yAAkhhbgjAhXr/H/OqSLorXrFjfAl C7zAZK/oE25GQRTU29bPNACnlP/130kpfksU+2qRwolmn2k3WhvHAQ9tqGvCrURj9Ewh WLGWEDVX7gsqLiKrLfM5/DDgLCqnJDrw+XFuUACUhYGZ0wi+3gql5SLj9dPJgz2v8udM aCJi3/i+Lylwz1DM/r0c1Uwhot8cUEaxxKak0zXnrDU/jQPwGS092IXRegx19fYt16oR IW/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=6CrqwtdtTMQQYtirl768oVpxOHXUYkfqpbiJtiq6HIU=; fh=YZMMBt+SM8tx3yMP4mImPoXnhZEsYGzg6kTB65ASl3k=; b=sqvmrPJhZlSbV7KUO6Cib6AdLD6asqzMy1o8A/hCRmMsonqORdnhLLECFqn2Cuo0YW Q+HXFdoO2JBuN5dYGbGRNkYSqQq/lvEXIJV8MdX/hmf6FMS17VVg88+4tKRoBJIg9dTI 7nS1MPo2PCMltmrZYFLFxvtkw4w0533hhKr+Q+Wp1aZJd2ILwOAcYQ5wmdUEyA6T4B3e PBWnsaN5MXZRBMmKX4u4WoyGglUcTQrLN04YuMhCf9HN67+f88W3Oao+wSGFukTAsE+9 v+mQV/G68WqvnkKLuXZ0vgE1Hg3ssHJOkZ6W01vv4DuefW/cR31ZilXs2jietkx+SXsR a0hw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=DefJEtk6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l11-20020a056402124b00b0052319f5e94fsi1118817edw.540.2023.08.10.03.33.49; Thu, 10 Aug 2023 03:34:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=DefJEtk6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234675AbjHJJMy (ORCPT + 99 others); Thu, 10 Aug 2023 05:12:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234526AbjHJJM2 (ORCPT ); Thu, 10 Aug 2023 05:12:28 -0400 Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D47A2123; Thu, 10 Aug 2023 02:12:08 -0700 (PDT) Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 37A99XXP123734; Thu, 10 Aug 2023 04:09:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1691658573; bh=6CrqwtdtTMQQYtirl768oVpxOHXUYkfqpbiJtiq6HIU=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=DefJEtk6YcDg8i2NG+00iUx9T2oRygzNIbBPA9bxWAtkpYvDRlPD66D39mQVumz+9 Lk/1mScSfkJexCQsQ/Pmf5UbM2YtV5aImYBCNXJ2mbOo8i2Wh7a7lb/4p5kYeNACwE UAnxIVwWJ/MRjf33Ik1p6e0hUu9FUkgtJXqG2AM4= Received: from DLEE108.ent.ti.com (dlee108.ent.ti.com [157.170.170.38]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 37A99XP2031836 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 10 Aug 2023 04:09:33 -0500 Received: from DLEE104.ent.ti.com (157.170.170.34) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Thu, 10 Aug 2023 04:09:32 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Thu, 10 Aug 2023 04:09:32 -0500 Received: from localhost (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 37A99Vjo084143; Thu, 10 Aug 2023 04:09:31 -0500 Date: Thu, 10 Aug 2023 14:39:30 +0530 From: Dhruva Gole To: Tony Lindgren CC: Greg Kroah-Hartman , Jiri Slaby , Andy Shevchenko , Ilpo =?utf-8?B?SsOkcnZpbmVu?= , John Ogness , Johan Hovold , Sebastian Andrzej Siewior , Vignesh Raghavendra , , , Guenter Roeck Subject: Re: [PATCH] serial: core: Fix serial core port id, including multiport devices Message-ID: <20230810090930.fylxbzh5v5jffh75@dhruva> References: <20230810065737.47294-1-tony@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230810065737.47294-1-tony@atomide.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Aug 10, 2023 at 09:57:34 +0300, Tony Lindgren wrote: > We want to fix the serial core port DEVNAME to use a port id of the > hardware specific controller port instance instead of the port->line. > > For example, the 8250 driver sets up a number of serial8250 ports > initially that can be inherited by the hardware specific driver. At that > the port->line no longer decribes the port's relation to the serial core > controller instance. > > Let's fix the issue by assigning port->port_id for each serial core > controller port instance. > > Fixes: 7d695d83767c ("serial: core: Fix serial_base_match() after fixing controller port name") > Tested-by: Guenter Roeck > Signed-off-by: Tony Lindgren > --- > drivers/tty/serial/serial_base.h | 1 + > drivers/tty/serial/serial_base_bus.c | 28 +++++++++++++++++++++++++++- > 2 files changed, 28 insertions(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/serial_base.h b/drivers/tty/serial/serial_base.h > --- a/drivers/tty/serial/serial_base.h > +++ b/drivers/tty/serial/serial_base.h > @@ -16,6 +16,7 @@ struct device; > > struct serial_ctrl_device { > struct device dev; > + struct ida port_ida; LGTM! Reviewed-by: Dhruva Gole [...] -- Best regards, Dhruva Gole