Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230809154813.16033-1-aboutphysycs@gmail.com>
In-Reply-To: <20230809154813.16033-1-aboutphysycs@gmail.com>
From:   Alexandru Ardelean <alex@shruggie.ro>
Date:   Thu, 10 Aug 2023 13:27:54 +0300
Message-ID: <CAH3L5Qp3HYbaz3eWr7ugJ0Ftm+ji-3r376LeX23_qCHOq8Vvqg@mail.gmail.com>
Subject: Re: [PATCH] thermal: broadcom: brcstb_thermal: removed unneeded platform_set_drvdata()
To:     Andrei Coardos <aboutphysycs@gmail.com>
Cc:     linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-pm@vger.kernel.org, florian.fainelli@broadcom.com,
        rui.zhang@intel.com, amitk@kernel.org, daniel.lezcano@linaro.org,
        rafael@kernel.org, bcm-kernel-feedback-list@broadcom.com,
        mmayer@broadcom.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Aug 9, 2023 at 6:48=E2=80=AFPM Andrei Coardos <aboutphysycs@gmail.c=
om> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Als=
o,
> the private data is defined in this driver, so there is no risk of it bei=
ng
> accessed outside of this driver file.
>

Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>

> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
> ---
>  drivers/thermal/broadcom/brcmstb_thermal.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/thermal/broadcom/brcmstb_thermal.c b/drivers/thermal=
/broadcom/brcmstb_thermal.c
> index 72d1dbe60b8f..2997c589ac7d 100644
> --- a/drivers/thermal/broadcom/brcmstb_thermal.c
> +++ b/drivers/thermal/broadcom/brcmstb_thermal.c
> @@ -334,7 +334,6 @@ static int brcmstb_thermal_probe(struct platform_devi=
ce *pdev)
>                 return PTR_ERR(priv->tmon_base);
>
>         priv->dev =3D &pdev->dev;
> -       platform_set_drvdata(pdev, priv);
>         of_ops =3D priv->temp_params->of_ops;
>
>         thermal =3D devm_thermal_of_zone_register(&pdev->dev, 0, priv,
> --
> 2.34.1
>