Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230810095923.123388-1-krzysztof.kozlowski@linaro.org> <20230810095923.123388-2-krzysztof.kozlowski@linaro.org>
In-Reply-To: <20230810095923.123388-2-krzysztof.kozlowski@linaro.org>
From:   Qiang Yu <yuq825@gmail.com>
Date:   Thu, 10 Aug 2023 19:59:23 +0800
Message-ID: <CAKGbVbv12K6NkRAe7jm7jueu6XCKyAkK+gmFia8ZxL7WH_h7zg@mail.gmail.com>
Subject: Re: [PATCH 2/2] drm/lima: fix Wvoid-pointer-to-enum-cast warning
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Andrzej Hajda <andrzej.hajda@intel.com>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Robert Foss <rfoss@kernel.org>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        lima@lists.freedesktop.org, Andi Shyti <andi.shyti@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Reviewed-by: Qiang Yu <yuq825@gmail.com>

On Thu, Aug 10, 2023 at 5:59=E2=80=AFPM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> 'id' is an enum, thus cast of pointer on 64-bit compile test with W=3D1
> causes:
>
>   lima_drv.c:387:13: error: cast to smaller integer type 'enum lima_gpu_i=
d' from 'const void *' [-Werror,-Wvoid-pointer-to-enum-cast]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  drivers/gpu/drm/lima/lima_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/lima/lima_drv.c b/drivers/gpu/drm/lima/lima_=
drv.c
> index 10fd9154cc46..884181708de8 100644
> --- a/drivers/gpu/drm/lima/lima_drv.c
> +++ b/drivers/gpu/drm/lima/lima_drv.c
> @@ -384,7 +384,7 @@ static int lima_pdev_probe(struct platform_device *pd=
ev)
>         }
>
>         ldev->dev =3D &pdev->dev;
> -       ldev->id =3D (enum lima_gpu_id)of_device_get_match_data(&pdev->de=
v);
> +       ldev->id =3D (uintptr_t)of_device_get_match_data(&pdev->dev);
>
>         platform_set_drvdata(pdev, ldev);
>
> --
> 2.34.1
>