Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Aug 2023 09:04:35 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Will Deacon <will@kernel.org>
Cc:     Michael Shavit <mshavit@google.com>, iommu@lists.linux.dev,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        robin.murphy@arm.com, nicolinc@nvidia.com, jean-philippe@linaro.org
Subject: Re: [PATCH v5 2/9] iommu/arm-smmu-v3: Replace s1_cfg with cdtab_cfg
Message-ID: <ZNTSU1Jm6OsauygC@nvidia.com>
References: <20230809011204.v5.2.I1ef1ed19d7786c8176a0d05820c869e650c8d68f@changeid>
 <20230809134941.GA4226@willie-the-truck>
 <ZNObxeogswAYyDQ5@nvidia.com>
 <20230809145542.GB4472@willie-the-truck>
 <ZNOr0ggoO9kXHJWl@nvidia.com>
 <20230809162254.GB4591@willie-the-truck>
 <ZNO+QVkXcHG78KG3@nvidia.com>
 <20230809162749.GA4663@willie-the-truck>
 <CAKHBV27JAFb56VkHJO2ZBZt=25aVregeiMjO2YJrg_fW9HQbYg@mail.gmail.com>
 <20230810094323.GC5365@willie-the-truck>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230810094323.GC5365@willie-the-truck>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uu+K8uBUT/lKGlSsVqmL5sp4a0BmMWofJF0wLJuHFAA8zg1w67S1RBIJMWZO?=
 =?us-ascii?Q?XbufIxW9nUflS3wyjnc+7KmKougubzM13f948q3e/j+pYU55FCvzocBvyXEQ?=
 =?us-ascii?Q?PLkxvPRc+BPfHFjlTkd4bczmxf0YoSBGmdjfcd9KY7iQT6gCl6L8z5UK+w96?=
 =?us-ascii?Q?CzOVyz0syWFt7fOVc23+Nf2tScRLcx0F3mWFUbdL2cFh7uP4BPjmLBfjCn9d?=
 =?us-ascii?Q?lM/yMb6QFZmZLHC74QeRsSddMKiMYQ5Z+q69ESZIRw0nHZIVZFo+vJfmSslm?=
 =?us-ascii?Q?bltEf7c/cAulsViwI1T66UHGsjtppfQ9PlAVs+9/fuDp198k2cHxboe7c+vu?=
 =?us-ascii?Q?/uoTLyHjAnShTmywwhwMwkB1SQmt37XzsQBeIIDhHwHXjgGEblJbIEh48iND?=
 =?us-ascii?Q?jlavg2DzdbBzAb6U8LwrL+xh0gRsQI1wYN5H9+hjPMQOQcmiUDp706woOuO8?=
 =?us-ascii?Q?AQZu4FyPSyzDClLgBVsSw4DrjAR9lZSblqRtywP1V5fRCfSHXnyFY+nYwlVD?=
 =?us-ascii?Q?Vgs1dTeAjYsx+NdhOPQoVZAKDeKd0ZGeyeTH1d32pcInf+y6y5Dj9bC+yecH?=
 =?us-ascii?Q?go6/fFyEmYHL/bMchAlw90jhGMKqUDiddoNm6JZ2FtWM1fWJ01eYPHlGABaP?=
 =?us-ascii?Q?3jk5FWnRo/Y0TTVmFUkuJaIn0WtY3vXEToH4kRJaFyR1vkkyXu0jYSYBEAW2?=
 =?us-ascii?Q?7YZ31B4wjdjgez25njUoelRGXV4bMJSRA2gFhIBRODoGEoiLLTnIYdFG8yXC?=
 =?us-ascii?Q?RWoxMbaEgBB+YPbc9ijZLWiyK8DmaRxMBWhPVlAN+n0/2FSQhKPXCB6g1hSv?=
 =?us-ascii?Q?928sP8rqmT4MD/wQJZ1NqfAqQ8qgudX/4zuEI2w7USNLLtWQWVKsCgAZg7Gq?=
 =?us-ascii?Q?C3CrceecqDwZ2mLumaWO8PbxnXOqGjs42huCeenjMBJhoARtuBtlMJwYnu+P?=
 =?us-ascii?Q?JM5OR4UoYHwprZVakKas7+VtU4SBGO1oApFcZVrKpnQtKnRpsRxa1Hsrv2jJ?=
 =?us-ascii?Q?OB6tCJl+bKBxUF5GdTV4i2a7Z4bOI+80RP/ZKZ3Unn4SvHJqy2lx1ojGaaxf?=
 =?us-ascii?Q?5L4eqdvmgdoj812nj/4KmUJI59B4sl+PlQVj6f24mfsETZRc8fD8ZtGQXJFh?=
 =?us-ascii?Q?QMZupsgJ5E14dW8PUfBX4fa9gxonD5Pun/RdSg7byeveU9VHmnNTHNdxm4bT?=
 =?us-ascii?Q?+X5SMrIace8c13HGpBAFW8TU/PZN+Z+tjQxvaFzhQ17Kft2PK+MUsrJJams4?=
 =?us-ascii?Q?qfoJ0J8C0OUmSw/bTRmsuMqJBKazTG7NXWdb6bP9xXuBs3Hf4v5JVptrH7Ft?=
 =?us-ascii?Q?fM/lJX0hVnlG9eoxCddfHUmaezPVHuhnahnRnXCTpHJ553CdaX5MqA9WhiDa?=
 =?us-ascii?Q?PYgK2Y0Qbg4Jday5XRI2aZWpMOinMw2tGKvAhG0N6kzWUYDYRZumCWJWkfX2?=
 =?us-ascii?Q?mh9GVCKE/BHV5fTMGRLjA0rW/zly8hIDoKCAPYHPE3E5tzG+MAaSM6Rte4XN?=
 =?us-ascii?Q?2lg3gaErBr8gT87deohpcR2dSFu24mdS0YJmRu7dXJUTQfplV29qUo3w7Gah?=
 =?us-ascii?Q?j9AvK9xOiyCUlE6+BLmSqCJ3WjmpRGC4/8Fzc/vP?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c9fff71e-308c-4489-cd83-08db9999f845
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 12:04:37.9645
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dvuqP+1v7BPk+wvvqdlcXbw8QYPsLTZ2QCr8ZO5JxBlSYXe1qB5m3/w0R8LO5Q9S
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5835
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Aug 10, 2023 at 10:43:33AM +0100, Will Deacon wrote:
> On Thu, Aug 10, 2023 at 05:33:53PM +0800, Michael Shavit wrote:
> > > > > Sounds a lot like the existing s1fmt field. Can we keep it?
> > > >
> > > > If you are OK with the dead code, I don't object. But let's put it in
> > > > the struct arm_smmu_ctx_desc_cfg.
> > >
> > > Ok, we have a deal!
> > 
> > What dead code? Is the deal here that we keep the field, but still
> > infer the value to write from (cd_table->l1_desc == null) in
> > arm_smmu_write_strtab_ent??
> 
> Keep the field and write it directly when populating the ste (i.e. don't
> infer anything), but the field moves into 'struct arm_smmu_ctx_desc_cfg'.

Yes - the 'dead code' is that we introduce storage for a field that is
always a known constant (STRTAB_STE_0_S1FMT_64K_L2).

Jason