Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <735d00afbc1a7fd2ede19cda76bcdc2bcc7d8212.camel@hadess.net>
Subject: Re: [PATCH] HID: logitech-hidpp: Add support for Logitech MX
 Anywhere 3 mouse
From:   Bastien Nocera <hadess@hadess.net>
To:     Maxim Mikityanskiy <maxtram95@gmail.com>,
        Filipe =?ISO-8859-1?Q?La=EDns?= <lains@riseup.net>,
        Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc:     linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Thu, 10 Aug 2023 14:17:57 +0200
In-Reply-To: <20230809113832.123667-1-maxtram95@gmail.com>
References: <20230809113832.123667-1-maxtram95@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Wed, 2023-08-09 at 14:38 +0300, Maxim Mikityanskiy wrote:
> Add Logitech MX Anywhere 3 connected over Bluetooth to the device
> table
> to get hidpi scroll supported. USB connection over the Unifying
> receiver
> is already supported by the wildcard entry LDJ_DEVICE(HID_ANY_ID).
> 
> Signed-off-by: Maxim Mikityanskiy <maxtram95@gmail.com>

LGTM, thanks

Reviewed-by: Bastien Nocera <hadess@hadess.net>

> ---
>  drivers/hid/hid-logitech-hidpp.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-
> logitech-hidpp.c
> index 129b01be488d..61d68c96581a 100644
> --- a/drivers/hid/hid-logitech-hidpp.c
> +++ b/drivers/hid/hid-logitech-hidpp.c
> @@ -4647,6 +4647,8 @@ static const struct hid_device_id
> hidpp_devices[] = {
>           HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb02a) },
>         { /* MX Master 3 mouse over Bluetooth */
>           HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb023) },
> +       { /* MX Anywhere 3 mouse over Bluetooth */
> +         HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb025) },
>         { /* MX Master 3S mouse over Bluetooth */
>           HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb034) },
>         {}