Received: by 2002:a05:6358:51dd:b0:131:369:b2a3 with SMTP id 29csp1094319rwl; Thu, 10 Aug 2023 06:27:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEP5SK+gWpdEbwl8CjIh0GreXjEZZGg13BFRlShYWnYktgZ2QgTDgQg3/upK6+WQ3mYYYS0 X-Received: by 2002:a54:4101:0:b0:3a3:baf8:5b8a with SMTP id l1-20020a544101000000b003a3baf85b8amr2889325oic.13.1691674050614; Thu, 10 Aug 2023 06:27:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691674050; cv=none; d=google.com; s=arc-20160816; b=DDKOIlMXWRynV1w621XNQreOooERZAOwfzTdYmZiZSkBAI2VAdYBsXGhe9nKKkVIY/ Pcv3rQHWqTLAajSZP+RKEDR3To9tbU1zNd1jscbJyuypE4Knm8AXpOeE7RNns4GabYdu ZyuF9SGKfIh29xZbPUsdev1Im0jsPhdc9YrxJjJVIPMtN24SCG9LyspCdIfpSsYHqo7D A8RiJPXW8yDwkMOr8j9AHpL7zrlxFyXS9JqkE3KHKGOm0wt9iGd2QEMQrj0FSzXAVQQa rVn0WvbhI+jAydGVjl/CZz1Lzq2Jx30TltccpUOrzMDQ8/6ImD5zb8PU2TtbFD2XBqrE k/EA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=d2mTwC/A1bemPLD8wVSu1bItAbEwKoB4ThQwlpab2yo=; fh=4GQdNM/9R2zZC+59Eg7QHvdr4rJGo9J2QwAUVUfgiyc=; b=i5nZSAu+I4AwOG5OSH+o+HnZowgoEsxCefwze7sJgJPNlUp0E/6ppmL8TAXuHzBWnR RtV30vLXqTo4MMHc1kmF4wsY5DqtvoF9jtEh/7rfNCSr+DCZSVLJB4Tqy8hu2CgjFGjq vpgOv4JZ3d2UCdTX38hlW+AWzPAjfRitSXmsCUVdx7YdCT8AhRv4PEeylF3NzYtOXThq c7ewsG8Fsmypv3eOJihBRMRbsRa+PJZu4jylb21rW+9TDei811k2VSitx4teOMK34f5q 9GMreIUPgYYbdrbi7F743G3R9NZvtI1Y3eu5IQd6imsqJR5SBBIJK7od2jBTdi46ogs1 C/0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="U7EmSq/m"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e4-20020a630f04000000b0054fe6b9502esi1472744pgl.687.2023.08.10.06.27.18; Thu, 10 Aug 2023 06:27:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="U7EmSq/m"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234245AbjHJMMR (ORCPT + 99 others); Thu, 10 Aug 2023 08:12:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233381AbjHJMMQ (ORCPT ); Thu, 10 Aug 2023 08:12:16 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F7DE26AA for ; Thu, 10 Aug 2023 05:11:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691669497; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d2mTwC/A1bemPLD8wVSu1bItAbEwKoB4ThQwlpab2yo=; b=U7EmSq/mWoX7s/geXBLuG8OAWMFsxkAxKlv6ExJL8dSk+LR/yAaXK8e2BZ+GuxWRFX9a03 17VwExKWfcGQVFjm6NUDsYOyRQsHFkkyHtMJQmTzafoSpYZjfRRSgWbiiXCGAUdOFBvw9r zKbLSixe4gHMB9hiVGz01tCszg4wob4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-348-Mi8AftagPdmWdIKfePxX9g-1; Thu, 10 Aug 2023 08:11:36 -0400 X-MC-Unique: Mi8AftagPdmWdIKfePxX9g-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BB87285CBE7; Thu, 10 Aug 2023 12:11:35 +0000 (UTC) Received: from o.redhat.com (unknown [10.39.192.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0FB0140C2076; Thu, 10 Aug 2023 12:11:34 +0000 (UTC) From: heinzm@redhat.com To: linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org Cc: ncroxon@redhat.com, xni@redhat.com Subject: [PATCH 2/3] md raid1: make first_clone a bool Date: Thu, 10 Aug 2023 14:11:31 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: heinzm first_clone is used as a bool so make it one. Signed-off-by: heinzm --- drivers/md/raid1.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c index 913cd46b786b..0aed74efd758 100644 --- a/drivers/md/raid1.c +++ b/drivers/md/raid1.c @@ -1337,9 +1337,8 @@ static void raid1_write_request(struct mddev *mddev, struct bio *bio, struct bitmap *bitmap = mddev->bitmap; unsigned long flags; struct md_rdev *blocked_rdev; - int first_clone; int max_sectors; - bool write_behind = false; + bool first_clone, write_behind = false; if (mddev_is_clustered(mddev) && md_cluster_ops->area_resyncing(mddev, WRITE, @@ -1505,7 +1504,7 @@ static void raid1_write_request(struct mddev *mddev, struct bio *bio, atomic_set(&r1_bio->remaining, 1); atomic_set(&r1_bio->behind_remaining, 0); - first_clone = 1; + first_clone = true; for (i = 0; i < disks; i++) { struct bio *mbio = NULL; @@ -1528,7 +1527,7 @@ static void raid1_write_request(struct mddev *mddev, struct bio *bio, md_bitmap_startwrite(bitmap, r1_bio->sector, r1_bio->sectors, test_bit(R1BIO_BehindIO, &r1_bio->state)); - first_clone = 0; + first_clone = false; } if (r1_bio->behind_master_bio) { -- 2.41.0