Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230810091510.13006-1-jirislaby@kernel.org> <20230810091510.13006-2-jirislaby@kernel.org>
In-Reply-To: <20230810091510.13006-2-jirislaby@kernel.org>
From:   Max Filippov <jcmvbkbc@gmail.com>
Date:   Thu, 10 Aug 2023 05:37:33 -0700
Message-ID: <CAMo8BfJ5EBausUzk7u6LyNRm+Ybtbyg7LG0_hvYN30kZz8ECTg@mail.gmail.com>
Subject: Re: [PATCH 01/36] tty: xtensa/iss: drop unneeded tty_operations hooks
To:     "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Cc:     gregkh@linuxfoundation.org, linux-serial@vger.kernel.org,
        linux-kernel@vger.kernel.org, Chris Zankel <chris@zankel.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Aug 10, 2023 at 2:15=E2=80=AFAM Jiri Slaby (SUSE) <jirislaby@kernel=
.org> wrote:
>
> All ::flush_chars(), ::hangup(), and ::wait_until_sent() from struct
> tty_operations are optional. There is no need to provide them with
> empty bodies.
>
> tty_operations::put_char() needs not be provided if it is the same as
> tty_operations::write(tty, &ch, 1).
>
> So drop all of them.
>
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
> Cc: Chris Zankel <chris@zankel.net>
> Cc: Max Filippov <jcmvbkbc@gmail.com>
> ---
>  arch/xtensa/platforms/iss/console.c | 24 ------------------------
>  1 file changed, 24 deletions(-)

Acked-by: Max Filippov <jcmvbkbc@gmail.com>

--=20
Thanks.
-- Max