Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH 2/2] ethernet: atarilance: mark init function static
To:     Arnd Bergmann <arnd@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        "Paolo Abeni" <pabeni@redhat.com>
CC:     Arnd Bergmann <arnd@arndb.de>, Haoyue Xu <xuhaoyue1@hisilicon.com>,
        Guofeng Yue <yueguofeng@hisilicon.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230810122528.1220434-1-arnd@kernel.org>
 <20230810122528.1220434-2-arnd@kernel.org>
From:   Yang Yingliang <yangyingliang@huawei.com>
Message-ID: <e531089e-793c-6813-42d0-dfd9fffe61b8@huawei.com>
Date:   Thu, 10 Aug 2023 20:50:38 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <20230810122528.1220434-2-arnd@kernel.org>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk


On 2023/8/10 20:25, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The init function is only referenced locally, so it should be static to
> avoid this warning:
>
> drivers/net/ethernet/amd/atarilance.c:370:28: error: no previous prototype for 'atarilance_probe' [-Werror=missing-prototypes]
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Yang Yingliang <yangyingliang@huawei.com>