Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <38f4dcfd-ccee-3481-a862-58b269bc0acc@intel.com>
Date:   Thu, 10 Aug 2023 14:52:33 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
From:   Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: Re: [PATCH net v2 0/2] Fix VF to VM attach detach
To:     Petr Oros <poros@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
CC:     "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "Keller, Jacob E" <jacob.e.keller@intel.com>,
        "Maziarz, Kamil" <kamil.maziarz@intel.com>,
        "dawidx.wesierski@intel.com" <dawidx.wesierski@intel.com>,
        "Palczewski, Mateusz" <mateusz.palczewski@intel.com>,
        "Laba, SlawomirX" <slawomirx.laba@intel.com>,
        "Zulinski, NorbertX" <norbertx.zulinski@intel.com>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "horms@kernel.org" <horms@kernel.org>
References: <20230809151529.842798-1-poros@redhat.com>
Content-Language: en-US
In-Reply-To: <20230809151529.842798-1-poros@redhat.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZStFSHl4ZmVjK1hDV3RJOUN5YVYxcit5Zm9oMVVxSTRDOWdQc1g0T0xWc2lW?=
 =?utf-8?B?WWRUMnRhaThYYysxcDI5Z2tWeWQ0a3hHclpuRXBGUkZWT00xZ0ZJVm5EaGd0?=
 =?utf-8?B?ZVFUUlhpSHRVS2hRbGNPcGZyTUVZc3hxYmxLd3YwRlF4ei9hbTBPbGRLVmU0?=
 =?utf-8?B?eW1OempBQ3BrVm1OMVIxTXR2TG05MjBueDBHUFRVTVd5M21kY2FsS2ovN1dt?=
 =?utf-8?B?WGthNCswNWtJSHlWNENnYTFidFI5a0hpRkFoemFFcktvWm1GUG9pbWJnS09P?=
 =?utf-8?B?aWFEODVubjJVUDQ3UzBORlBtOENuOE9vVVBDc0g0TDNiN1MvbEV3dVhEeXRI?=
 =?utf-8?B?Mk53dE5jRnhrN3JKaFhXMTI2eUdtZ09Zd1J5K0JVWjFnZUxNMy8vdGVEV2Na?=
 =?utf-8?B?UFpEanNSTm1IaUNOUWJXRzFncEZ0eXRFMFJ5Um1zU20xenV0OVJrTTh3dE1O?=
 =?utf-8?B?enNmV2UyT29MaU1NZ2kxbmFmTXBzOWZSZzh2OVhlbWVyYy9wSmcxQk9QOCtL?=
 =?utf-8?B?eFUrUW8ybjlycmtnS0d5WXdjZVBCZGpkUStIT1Iwa25GRlRUQWNYeHdoeTZD?=
 =?utf-8?B?Z1VmVkNSMmVNQlNibk9Pdkd2TEZUQStaM3REOVdWNlhWaTZ1NGMyZGIwRWxm?=
 =?utf-8?B?MVhwc01hTjFXRThjd2RTakNpL3dBYTUzMHRmSmZhU3c4b2U1Zm1OVHVyTHhj?=
 =?utf-8?B?SmdDZEZhT1FCWnJCZjNaSXo1M3dQZE9QdDR0YTlIZTZHdUN1anpoQ2FHM0c5?=
 =?utf-8?B?UkdvQXpJQ2VJREw3dmZmaXhrZzNGOHJ6SDJjT01SWm9rT3BWU2FUSjZlU0c3?=
 =?utf-8?B?dVBob1d2SVE0WkxOcmRobWpWdHg5L2xoS3BsVzJLQXpvdCt4UHl6Vi9kRHdo?=
 =?utf-8?B?N3FLc3lFWXJPaTEvcDlQWVNuUjFvb3htbVFmZkE4UmxzRFFGRGl4RHhuTWs0?=
 =?utf-8?B?Ylg0N21nMkJaUVJnbkhJQ0d5L3lMMUg2c1RIVnRUbTlFWklwNmduVXRsQnlI?=
 =?utf-8?B?WUYvRG5RQ0pHOHg4SHhQdUZkcHZ6SSsrNWVlZ1lhYm5kenRCSFVkWU5Sb04v?=
 =?utf-8?B?dmdXSWdqM2pTOCs5SGI2SEFDR0xNaVJVL1dWb1VRTnNybkdjK3VUYzRQd1Uy?=
 =?utf-8?B?M1BzSDJiT2pVRG0yVVc3SWFKZUVTSkVNaFBnSEx1bHN2VnBBNHh2TitmMjRa?=
 =?utf-8?B?QytvNWwvZjhzU2p6TjRMMXU2L0NRV2RqQkNla29DVlplalVUNjB2Ulh1TlF3?=
 =?utf-8?B?eTNJQzNiYjg5M20rNVRSMlVBdFVYeTcvMk9xSlNRN0FEbHBlOVV5N3ZjMkt5?=
 =?utf-8?B?cFN2dUNsUUo1SkRvSjU1ZndrSjNNVGVqYzJlVjJCd2tVaEFqVWtLTmJXODcw?=
 =?utf-8?B?ZUgvQmdlTDdmM04xaWNFYjV0Z1FoeHlJa0dtbTl6UE0wRy91UGo4YjFLV0RI?=
 =?utf-8?B?WnpVZUpUMzFPdkpuUWZoWXhmMVplLzdkZXoyc05rUWo0cGR6M2ZPV0xtdnF2?=
 =?utf-8?B?SGs4NlNZVW5GN3Nia25OUEhRTnpwUmdzbHYwMUFqQVNmNHAzZEFsNlFGNzBP?=
 =?utf-8?B?b2VPemd3VlZ0T3loZnRPNUFpaTJiamloczZJQXljS1ZHbHpwTFdLSXNSWFhQ?=
 =?utf-8?B?aHN3YmF3Tm1XN2cydWpadVRaNlhSbzVGaU5LSSt0WUtYY1k3Y3lkdk12TzVI?=
 =?utf-8?B?VGp4UUhpcHZVTTkzR2lxb096amtHZEtSR0loL2tEelFYbmc2YnhSMCtIWUhE?=
 =?utf-8?B?aXdrczY4R2xNSHpRQ0s2WStvVEkyV2lENE83dU4veDRPOEYxWnI3Q20yWDUz?=
 =?utf-8?B?MTVCSEQzbjBmeFRoNmxUTHY3NjcyYkkyZUg1ZzRSRzNPZFV2ZytYMkNQZzF4?=
 =?utf-8?B?RTRuQ1dJZjNWRFhwcGowV2U5dWh4YkdiUXlKYmdzWU9pYkVnVS9IRmRiWnlt?=
 =?utf-8?B?c28rM3d2R2hsV1IvQWNPV1pSRnFncjRwb3hydDlpUDJQWE9wbXhNYkxPNENB?=
 =?utf-8?B?aWZmQzdwd1dNcUtnU1o4T25sOXgvTTdEcWpnMUpiSlEzMzJwa29QN00vd1ph?=
 =?utf-8?B?eW5sWUY3VFR2N2ZoRmVtZDBxL1VYNnpYK1FFNkhVNmUvZGdBRjJiWm1SSGZK?=
 =?utf-8?B?SGxaQkMzbU96KytpQ3NieHNqRlRCZitQN0owdzZXWmo3Q1I4ZXBjRUEzWUlI?=
 =?utf-8?B?Q3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 40b203af-8ac6-46ff-85cc-08db99a0b0b2
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3672.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 12:52:44.3808
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: W7PkJj9YLhAUku445hfpuixoFjxQq+HdgUiRTDt3IxRHVjuYic4enR2ep/W9/MyBGGWT7q5NMvpdoN6ssf6WZr1xqcONgUxYpyC6NOCeDLo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB8168
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/9/23 17:15, Petr Oros wrote:
> v2: fixed typos in the description of the second patch
> 
> v1: https://lore.kernel.org/netdev/20230807094831.696626-1-poros@redhat.com/
> 
> Petr Oros (2):
>    Revert "ice: Fix ice VF reset during iavf initialization"
>    ice: Fix NULL pointer deref during VF reset
> 
>   drivers/net/ethernet/intel/ice/ice_sriov.c    |  8 ++---
>   drivers/net/ethernet/intel/ice/ice_vf_lib.c   | 34 +++++--------------
>   drivers/net/ethernet/intel/ice/ice_vf_lib.h   |  1 -
>   drivers/net/ethernet/intel/ice/ice_virtchnl.c |  1 -
>   4 files changed, 12 insertions(+), 32 deletions(-)
> 

You have forgot to propagate reviewed-by tags from v1 (Simon's, Jake's, 
mine)

Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>

(I'm not sure if I should copy-paste not mine RBs here?)