Received: by 2002:a05:6358:51dd:b0:131:369:b2a3 with SMTP id 29csp1202261rwl; Thu, 10 Aug 2023 07:53:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEZ24xlkT+fnI48NpVvPseB6Ggh1v5UAoguWnTvcGuMgbh9lHdjmgW+/wdWHszZwq8g0WUS X-Received: by 2002:a05:6a20:12cb:b0:141:d54e:a908 with SMTP id v11-20020a056a2012cb00b00141d54ea908mr2945886pzg.41.1691679193437; Thu, 10 Aug 2023 07:53:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691679193; cv=none; d=google.com; s=arc-20160816; b=HiD5mrsFSFI2CuRoDiBBiUK9RtXKevY7rwH1M+uzrFP81X+d3jUzsDerNEaKLhSenC qad9Rwn1CaspopNVsJRYPm/eEddOxmlSc3hYGePlwSubrDO5CLHq29uqZPCaLr9Jz0az g8LEml+3pvI8v6pWCGrLIGIpRLMNJWQxguZVZLC9h4sZ6JU7IIogqBFELXBUzE7QlvFI PVKQjW90leTnNm6rTf38FGld2idSJvdoJngu5YBJLF+WlMmaYf4vhAb2GSskdO3sk3mW o18gJAP0YzcTvNdMGArjjevmM18xxbRACRX40Eb2f96NBXzi32dXtjXG5VuxRwlt1Y1Q 4TeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=lJmfLsW/k1z7fpv6J/HP22dV3Uwn1Y9ZTF1xoT2a8/A=; fh=ASMo9NSnjM4IoGAd/fn9gBpHZyLaMpLmoG5r5RpGFts=; b=BT1v4lYt02j2tC7OPOCrNCIOhXPZq9MJmsMhJVODp3yS1VhrgUYMW1yERS/Flj/IDh /0k78Y1srROP11+Z1UHWW0BfpTpS0Av7OTbHBy9Z5WNv3h/9lhcSTS7ntJuLks54oyJ0 N43jRJr2m+DbKJaOCccEWsgeSwQYoIJCB/8dxqrFn6bSPURGVxFNJJitud1DVzpVO5Yz bIIFzWHqdRRNJe/x6wwlcc+LmBwbk2SUJ5LeoJzOCwMMjhlmUpQLHatW0f4pIUrnVdSb y5TCvz0RKFdwVH9QJjb5H1Yt9SUy7gfMwo7hNgav9Hgk+jvQF3AtqeRAWWn9YYiwXPqS DGgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YizyZBQG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bt27-20020a056a00439b00b0068782a60b20si1642273pfb.330.2023.08.10.07.52.58; Thu, 10 Aug 2023 07:53:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YizyZBQG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235821AbjHJOiW (ORCPT + 99 others); Thu, 10 Aug 2023 10:38:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234883AbjHJOiS (ORCPT ); Thu, 10 Aug 2023 10:38:18 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 083272684; Thu, 10 Aug 2023 07:38:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8D64D65E46; Thu, 10 Aug 2023 14:38:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8AC1C433C7; Thu, 10 Aug 2023 14:38:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691678297; bh=dma8etxQj28F8UTj/qSKe+KW6fpXEEl/4Ff+L1nZ6Lg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YizyZBQGNHhqJ2u3CnZvafAwPR+Bogcyn+JN2WkFFI6k4hkFSk3WGW+dT1iGhQoBg CEL/bfruetDwwXgn4C784tctu0ACtE/BcnCTI//2B75K6mAc2emGGy1AwUEhnKdtef IEVqw6X9wbrQ0mUamgnQw/bAEtMsc4SoIFunzDSLXvekLNq7zLXE8/XJeZUsp2vNhs B/6w5KXE5ECTGlhJqnLSEO9zqy8oG1etYyXLVvPmDG1RkjyiK7RuL/+/rAbc9Tm4D9 4dexzTtS90+ppwCWhDo14xoggjBdsNJ9sKS1+QialOdMp2vnGjuvwVaAMmR5u/UuMm 7CcqurgX1r5Eg== Date: Thu, 10 Aug 2023 07:41:08 -0700 From: Bjorn Andersson To: Nitin Rawat Cc: mani@kernel.org, quic_nguyenb@quicinc.com, quic_cang@quicinc.com, quic_asutoshd@quicinc.com, avri.altman@wdc.com, martin.petersen@oracle.com, beanhuo@micron.com, bvanassche@acm.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, agross@kernel.org, konrad.dybcio@linaro.org, jejb@linux.ibm.com, linux-arm-msm@vger.kernel.org, quic_ziqichen@quicinc.com, Naveen Kumar Goud Arepalli Subject: Re: [PATCH V3] scsi: ufs: qcom: Align programming sequence as per HW spec Message-ID: References: <20230809151243.17531-1-quic_nitirawa@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230809151243.17531-1-quic_nitirawa@quicinc.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 09, 2023 at 08:42:43PM +0530, Nitin Rawat wrote: > Align clock configuration as per Qualcomm UFS controller > hardware specification. > > This change updates UFS_SYS1CLK_1US, CORE_CLK_1US_CYCLES, > PA_VS_CORE_CLK_40NS_CYCLES timer configuration for Qunipro > and UTP to align with Qualcomm UFS HW specification. "Code is wrong, make code right" I find it hard to believe that "the clock configuration is wrong" takes 207 lines of code to address. Please instead describe the problem you're solving, to ensure that current and future readers of this commit message have a chance to understand why this change was made. The "describing your changes" section in the documentation is good, please read it: https://docs.kernel.org/process/submitting-patches.html#describe-your-changes Regards, Bjorn