Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Aug 2023 07:44:52 -0700
From:   Nathan Chancellor <nathan@kernel.org>
To:     Andi Shyti <andi.shyti@kernel.org>
Cc:     Justin Stitt <justinstitt@google.com>, Ray Jui <rjui@broadcom.com>,
        Scott Branden <sbranden@broadcom.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@broadcom.com>, linux-i2c@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        llvm@lists.linux.dev
Subject: Re: [PATCH 1/2] i2c: i2c-bcm-iproc: fix -Wvoid-pointer-to-enum-cast
 warning
Message-ID: <20230810144452.GD1549244@dev-arch.thelio-3990X>
References: <20230809-cbl-1903-v1-0-df9d66a3ba3e@google.com>
 <20230809-cbl-1903-v1-1-df9d66a3ba3e@google.com>
 <20230810085632.xzonkmse27mu4yew@intel.intel>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230810085632.xzonkmse27mu4yew@intel.intel>
Precedence: bulk

Hi Andi,

On Thu, Aug 10, 2023 at 10:56:32AM +0200, Andi Shyti wrote:
> Hi Justin,
> 
> > @@ -1036,7 +1036,7 @@ static int bcm_iproc_i2c_probe(struct platform_device *pdev)
> >  	platform_set_drvdata(pdev, iproc_i2c);
> >  	iproc_i2c->device = &pdev->dev;
> >  	iproc_i2c->type =
> > -		(enum bcm_iproc_i2c_type)of_device_get_match_data(&pdev->dev);
> > +		(unsigned long) of_device_get_match_data(&pdev->dev);
> 
> I think this should be uintptr_t, as defined in types.h:
> 
>     typedef unsigned long uintptr_t;

Yes, that is a valid comment, although I will say that I have seen some
developers/maintainers prefer 'unsigned long' over 'uintptr_t', so it is
really a crapshoot which one to pick :)

> (I'm a bit puzzled to see a void *data cast to a 0/1 value.)

It is an odd pattern but as far as I understand it, the kernel uses it a
lot to pass platform specific data around (just grepping for
'.data = (void *)' shows a lot of instances.

Cheers,
Nathan