Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Aug 2023 11:56:00 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Will Deacon <will@kernel.org>
Cc:     Michael Shavit <mshavit@google.com>, iommu@lists.linux.dev,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        robin.murphy@arm.com, nicolinc@nvidia.com, jean-philippe@linaro.org
Subject: Re: [PATCH v5 6/9] iommu/arm-smmu-v3: Move CD table to
 arm_smmu_master
Message-ID: <ZNT6gFHtURU8HnJe@nvidia.com>
References: <20230808171446.2187795-1-mshavit@google.com>
 <20230809011204.v5.6.Ice063dcf87d1b777a72e008d9e3406d2bcf6d876@changeid>
 <20230809135024.GD4226@willie-the-truck>
 <CAKHBV27uY3TK3bWX8q1VHPo-ejeNmY53RAVNH_VqyYwZASKsNg@mail.gmail.com>
 <20230810143448.GB5795@willie-the-truck>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230810143448.GB5795@willie-the-truck>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NWxTejltOXBmMUg2dURjVDdnMElnd3pISHgvM2JCTEIrdDdYbGdpZzdJdXB6?=
 =?utf-8?B?eXM3VHZheFBXMzBNd25SeklkbFdISlRlUHZHZWZkc2hnRzdHRUxVUWxDNEZh?=
 =?utf-8?B?eGlnSERpNlNzaDdua2JtUVVWUlc3UGFTbDAzMng3MEtucmowa1lCY2VnYjR3?=
 =?utf-8?B?SkdLWGlDMHJFdi9QeUdkOXVBbC8zRjQ1TGJsdnlWMGNWTWRLVDF5NTROMVht?=
 =?utf-8?B?eE9QQUgxdjNXVERNN3pvaU5jelAzMVZ5YTFTQ0VWUnduQktXd3dUZlAvZW1J?=
 =?utf-8?B?RXJYUkZhU3o5dS95MmxaYUFyMndVMEFIcVdhZjIydlRhbDRzbGVkbkxHY2ZT?=
 =?utf-8?B?MEpia2JhTjhVQXd1b2VRWFhNaDdQS2VyakNsQjdlNm5icHkzSDFLNUczSmNP?=
 =?utf-8?B?TDZtNFZPL1FZWkNxL0Zabk5uUlNXNUVoNy9JOXJqQ01mVTlYUVN5Q29jZkUv?=
 =?utf-8?B?TFh5d05wUFlwbHZPcXlKcVcrZ1RENW8wWnJZRHg4eW9GZzdnS1ZqVDU4a0JN?=
 =?utf-8?B?SGNmOEU3M0t6WDZHSGhvSm1mL0lBWm4vTXovWHlrdmJCbUd6RXFkcVg2b1By?=
 =?utf-8?B?UTUvUXhZbW9KT0dMS3Rpa1dGYlJ3V1habVJqTlZGRDE1RVpTWmZYWXNaVytK?=
 =?utf-8?B?bFVoWmM0WFRnS3F5eGdRdkdIRFpCN2drV0hsclJTQ2d3TlhVWWtONFdPSmF0?=
 =?utf-8?B?YTc4UU1SalVZdHhxeWZFNmNla05IZ0Y2bVU1WS9UUUxDT0lhMXZUTmR3RU1z?=
 =?utf-8?B?K2psWmkwVXpEcklRMHpGeXBwaEx1Y29Vb0x2aFBrK3E3V1Jab0RxL09IT3dO?=
 =?utf-8?B?aXlVZklydFBVUEVNN3R1ZWVEdTBNazE3VDRmUDFpRk9Cc0Z1aVkxREhwY2Q3?=
 =?utf-8?B?S3FIcWdPYzRmN2IzUU05bVJFTDhCL2l1MDNTeWxCZWhoS0dUWUp2RXFXQWVj?=
 =?utf-8?B?MXNqV3A2eCtJUkZDUWZ1RnpEWGZqVkdqL3BUK2g5U2gvSDJOWEtHMFBtU1RV?=
 =?utf-8?B?d1hRYVl5OTZyOCsvd0VtSi9GK0gvdnAvNmJyQ1hNK2xpd3lnQURudVF0bnJl?=
 =?utf-8?B?SXRHdU1yTUFtSWc0Y1NRS21adjd4VTNTWW9NMGZYeURGZGtvd0dya0dpTHVr?=
 =?utf-8?B?SHNxWmJzNW9rRHpkWDZEeHNLa0RGOTZqUVpKZGNXbWx2ZDZYdGR2NHdSTnVy?=
 =?utf-8?B?MHJSKzJDVDNINXJieEw0Q1FrSVc5RFp1TjY1a3VCTTUrMHJOcVZ4elVKLzYy?=
 =?utf-8?B?Z2RLRGtnWmNvVzd5RU84Q2R2Rm45V2dzMnhPaXpVaVdzU2JyR1MxajZtbW04?=
 =?utf-8?B?K1hobmZSOWRLU3QxYWNsVE40bFdHdnZYcE9NWkphVmxid3EwMjkzVVBndmM0?=
 =?utf-8?B?VC8rSk02bzJjTjV3NERLNmxYQXB1d3hycVNuNGFPV2tPejI1ajU5NC9pM1Qz?=
 =?utf-8?B?VlZtQ1RwRGVTNlpWclJ2WTVsRlpVS29YY3R0emp0bGhVbnN3bkpEeDVYNW9M?=
 =?utf-8?B?RzByVlVhUThrUlh3bEI3VUNTaE9OV3BSV2VjNGRnb3JYZC8ySFJEZmpaNENi?=
 =?utf-8?B?NkNZZ3pKZ3VjN2ExMUZUSUtabjlSRWZMcEtjUEFCTzJvSmZWZnhKcDVzT2E5?=
 =?utf-8?B?ajByeEdLYXl0MkU4blpIU3hRL0ZTWGlsQnlLVDJDQ2VQZ0x5K0NxekZ4czJT?=
 =?utf-8?B?T2I1NkZHOGJwdmEzRVBMTlpRVHRqV2ZhUmtMSGZZTTdLb3VxZVVqcCtlM1NR?=
 =?utf-8?B?ZFdIY3pxaFUwQlJreWU5ZVBVeEFVc3ptOFFERDZIQ0UreHhYbU9BYzBRdzk2?=
 =?utf-8?B?UkVYVlI0VXREMnMvN2p0MlFoc3QrN1Z1dXJsdUlBVUsxNWdMalZKY0Q3ZGtN?=
 =?utf-8?B?NGZQbVJiTGhtZnF5N3UvaGtvVGV0MkpndU16alRaYllFam0xZjBOWUl6WjEw?=
 =?utf-8?B?NEZQLzRIc1RrUERrbzExb1piQ25USVNIakM1RVdld2lmTThlck5Zblh2Y1d1?=
 =?utf-8?B?YXdUQ2h0NE00dnlEWVpUTkFtUUZCV0dyZ3F0bHBYZklLcGZ6UTFsUVFxVUlk?=
 =?utf-8?B?S0RmSDlKQjdzOHRKMDI4MEovZjBvaytidnl6REFIVFVuOXd1cUhMazUyeExl?=
 =?utf-8?Q?k3+tP7gv20hZOIkUH66FoNpmo?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f1a938c5-21dd-4239-fe5a-08db99b1eadc
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 14:56:03.3216
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2VNUsp1BV3B6Nw/EUIyrItEP0KsTZw8nLznMoXcn2Gwfh+l/IsusoLV+c9qZgxMU
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB8370
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Aug 10, 2023 at 03:34:49PM +0100, Will Deacon wrote:
> On Thu, Aug 10, 2023 at 05:45:03PM +0800, Michael Shavit wrote:
> > On Wed, Aug 9, 2023 at 9:50 PM Will Deacon <will@kernel.org> wrote:
> > >
> > > On Wed, Aug 09, 2023 at 01:12:02AM +0800, Michael Shavit wrote:
> > > > @@ -2203,7 +2186,7 @@ static int arm_smmu_domain_finalise(struct iommu_domain *domain,
> > > >               ias = min_t(unsigned long, ias, VA_BITS);
> > > >               oas = smmu->ias;
> > > >               fmt = ARM_64_LPAE_S1;
> > > > -             finalise_stage_fn = arm_smmu_domain_finalise_s1;
> > > > +             finalise_stage_fn = arm_smmu_domain_finalise_cd;
> > >
> > > Why is this a better name? Now we have inconsistency with
> > > arm_smmu_domain_finalise_s2().
> > 
> > There was a time where s1cfg represented the entire STE and carried
> > the entire cd table. We've gotten rid of s1cfg, and now only store
> > arm_smmu_ctx_desc in the arm_smmu_domain for stage 1 domains.
> > arm_smmu_domain_finalise_cd is IMO more clear, especially given the
> > historical baggage around `s1`.
> 
> Ok, but it's the inconsistency I object to. I don't think it's clear at
> all to have arm_smmu_domain_finalise_cd() and arm_smmu_domain_finalise_s2().
> 
> The easiest thing is to leave it as-is.

Well the names have become wonky.

arm_smmu_domain_finalise_cd() is filling in the struct
arm_smmu_ctx_desc which is mostly the precomputed value for the CD
table entry, which is mostly redundant copies of the values of the
underlying pgtbl_cfg :\

But I agree keeping it named s1 is more consistent with the naming I
think we should use - domains are called S1 or S2 domains depending on
their IOPTE format. 

But arm_smmu_domain_assign_asid/vmid is a generally clearer name for
both :\

Jason