Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Aug 2023 08:13:56 -0700 (PDT)
Subject:     Re: [PATCH -fixes] mm: Add a call to flush_cache_vmap() in vmap_pfn()
In-Reply-To: <ZNQSTw4uoksSMYB5@infradead.org>
CC:     alexghiti@rivosinc.com, akpm@linux-foundation.org,
        urezki@gmail.com, Christoph Hellwig <hch@infradead.org>,
        lstoakes@gmail.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
From:   Palmer Dabbelt <palmer@dabbelt.com>
To:     Christoph Hellwig <hch@infradead.org>, dylan@andestech.com
Message-ID: <mhng-3d3afb21-bd40-4095-ba62-41cf40b782ca@palmer-ri-x1c9>
Mime-Version: 1.0 (MHng)
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Wed, 09 Aug 2023 15:25:19 PDT (-0700), Christoph Hellwig wrote:
> On Wed, Aug 09, 2023 at 06:46:33PM +0200, Alexandre Ghiti wrote:
>> flush_cache_vmap() must be called after new vmalloc mappings are
>> installed in the page table in order to allow architectures to make sure
>> the new mapping is visible.
>
> Looks good.  I somehow vaguely remember seing a patch like this floating
> around before as part of a series, but if that didn't make it it
> certainly should now.
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>

I think we're likely to end up with performance problems around here, 
but at least it's correct.  If someone has performance

Dylan: this fixes your breakage as well, right?

I've queued it up for testing, but I doubt QEMU would find any issues 
here.  My build box has been slow lately, but it should end up in fixes 
later today.