Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Aug 2023 10:25:35 -0400
From:   Stefan Hajnoczi <stefanha@redhat.com>
To:     "Tian, Kevin" <kevin.tian@intel.com>
Cc:     "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [PATCH 3/4] vfio: use __aligned_u64 in struct
 vfio_iommu_type1_info
Message-ID: <20230810142535.GD2931656@fedora>
References: <20230809210248.2898981-1-stefanha@redhat.com>
 <20230809210248.2898981-4-stefanha@redhat.com>
 <BN9PR11MB5276D1304E854E2AE7E8EFA18C13A@BN9PR11MB5276.namprd11.prod.outlook.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="uYWLEaQvqBpXEN2x"
Content-Disposition: inline
In-Reply-To: <BN9PR11MB5276D1304E854E2AE7E8EFA18C13A@BN9PR11MB5276.namprd11.prod.outlook.com>
Precedence: bulk


--uYWLEaQvqBpXEN2x
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Aug 10, 2023 at 03:25:37AM +0000, Tian, Kevin wrote:
> > From: Stefan Hajnoczi <stefanha@redhat.com>
> > Sent: Thursday, August 10, 2023 5:03 AM
> >
> > @@ -1303,8 +1303,9 @@ struct vfio_iommu_type1_info {
> >  	__u32	flags;
> >  #define VFIO_IOMMU_INFO_PGSIZES (1 << 0)	/* supported page sizes info
> > */
> >  #define VFIO_IOMMU_INFO_CAPS	(1 << 1)	/* Info supports caps */
> > -	__u64	iova_pgsizes;	/* Bitmap of supported page sizes */
> > +	__aligned_u64	iova_pgsizes;		/* Bitmap of supported page
> > sizes */
> >  	__u32   cap_offset;	/* Offset within info struct of first cap */
> > +	__u32   reserved;
>=20
> isn't this conflicting with the new 'pad' field introduced in your another
> patch " [PATCH v3] vfio: align capability structures"?
>=20
> @@ -1304,6 +1305,7 @@ struct vfio_iommu_type1_info {
>  #define VFIO_IOMMU_INFO_CAPS	(1 << 1)	/* Info supports caps */
>  	__u64	iova_pgsizes;	/* Bitmap of supported page sizes */
>  	__u32   cap_offset;	/* Offset within info struct of first cap */
> +	__u32   pad;
>  };

Yes, I will rebase this series when "[PATCH v3] vfio: align capability
structures" is merged. I see the __aligned_u64 as a separate issue and
don't want to combine the patch series.

Stefan

--uYWLEaQvqBpXEN2x
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmTU818ACgkQnKSrs4Gr
c8iySQf9FZbRiPNfdlBpBsLYscA+oOj9TOnEyxAcMVkvwRME3HsWH8AD5Esrn038
lG5gDBfNWcMl0Uxjzo01BYTKMhOIt0ywbGMmP1AZSJERt3N+MTUnveWsx7pxbr67
VQFlJJyV6JcqSAX7VaRyx4JWJcM1itdWDomC7AG/K8DvE2wupsGZ75tN6eBLQPOW
PS/5VLF14dHWcWRTDuTtsjiZC5uAxONA8nCir4Cm/u2oXcfVl4KGyoGNAK5HUHCg
ZCbiz1+Gf1Q+mDOtt/ZLqMtaD0CmzqzI6Y6EzWhy/W/N6fAAsuni18MU26t5X8Oo
jXsZ6lkXG/eOpZa0r1LswaPNLAzgwQ==
=dfMD
-----END PGP SIGNATURE-----

--uYWLEaQvqBpXEN2x--