Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Aug 2023 10:04:19 -0400
From:   Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To:     Tahsin Erdogan <trdgn@amazon.com>,
        Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
        Jason Wang <jasowang@redhat.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Herbert Xu <herbert@gondor.apana.org.au>
Cc:     Tahsin Erdogan <trdgn@amazon.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Message-ID: <64d4ee63a11e9_8e54c294a9@willemb.c.googlers.com.notmuch>
In-Reply-To: <20230809164753.2247594-1-trdgn@amazon.com>
References: <20230809164753.2247594-1-trdgn@amazon.com>
Subject: Re: [PATCH v4] tun: avoid high-order page allocation for packet
 header
Mime-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Tahsin Erdogan wrote:
> When gso.hdr_len is zero and a packet is transmitted via write() or
> writev(), all payload is treated as header which requires a contiguous
> memory allocation. This allocation request is harder to satisfy, and may
> even fail if there is enough fragmentation.
> 
> Note that sendmsg() code path limits the linear copy length, so this change
> makes write()/writev() and sendmsg() paths more consistent.
> 
> Signed-off-by: Tahsin Erdogan <trdgn@amazon.com>

Reviewed-by: Willem de Bruijn <willemb@google.com>