Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Aug 2023 07:36:45 -0700
From:   Bjorn Andersson <andersson@kernel.org>
To:     Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>
Cc:     Hugo Villeneuve <hugo@hugovil.com>, agross@kernel.org,
        konrad.dybcio@linaro.org, gregkh@linuxfoundation.org,
        jirislaby@kernel.org, bartosz.golaszewski@linaro.org,
        linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org,
        linux-kernel@vger.kernel.org, quic_msavaliy@quicinc.com,
        dianders@chromium.org, mka@chromium.org, swboyd@chromium.org,
        quic_vtanuku@quicinc.com
Subject: Re: [PATCH RESEND] tty: serial: qcom-geni-serial: Poll primary
 sequencer irq status after cancel_tx
Message-ID: <7mdlnuxzm7rxstl2r3kyyiuefbj3wpyqprzufdrsxe7hy5fvfo@tdwfhi6a27hj>
References: <1691583100-15689-1-git-send-email-quic_vnivarth@quicinc.com>
 <20230809091951.fbcc682d00deacd4d7b55b44@hugovil.com>
 <9be10770-d3df-467e-0541-8839bcd22fee@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9be10770-d3df-467e-0541-8839bcd22fee@quicinc.com>
Precedence: bulk

On Wed, Aug 09, 2023 at 10:51:54PM +0530, Vijaya Krishna Nivarthi wrote:
> Hi,
> 
> Thank you very much for the review...
> 

Thank you for the bug fix, Vijaya.

> 
> On 8/9/2023 6:49 PM, Hugo Villeneuve wrote:
> > On Wed,  9 Aug 2023 17:41:40 +0530
> > Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com> wrote:
> > 
> > > TX is handled by primary sequencer. After cancelling primary command, poll
> > > primary sequencer's irq status instead of that of secondary.
> > Hi,
> > it is not clear to me if this is a bug fix or an improvement?
> This is a bug fix.

Please describe the actual problem you're solving, to allow others
working in and around this driver to know what issue(s) are corrected.

This will save others debugging time, and it will teach others to help
you maintain this driver.

The section in the documentation on how to describe your changes is
good, please read it:
https://docs.kernel.org/process/submitting-patches.html#describe-your-changes

> > 
> > > While at it, also remove a couple of redundant lines that read from IRQ_EN
> > > register and write back same.
> > This should go into a separate patch.
> 
> The changes were too close by so I wasn't sure it could be split into 2
> patches.
> 
> I see that the earlier patch has already been signed off by Greg. (I did a
> RESEND after realising that I had Bjorn Andersson's email address incorrect)

Please use ./scripts/get_maintainer.pl on the upstream tree, as this
uses up to date information about recipients.

> 
> Will post another version if original patch doesn't get merged for any
> reason.
> 

Please double check linux-next [1], if it's unclear if Greg picked up
your previous patch (he's usually quite explicit about it...). I really
would like some more details on the bug fix...

[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/

Regards,
Bjorn