Received: by 2002:a05:6358:51dd:b0:131:369:b2a3 with SMTP id 29csp1270368rwl; Thu, 10 Aug 2023 08:46:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEdutGRrRHjmf4M291yBGqN23f4cc1vd9G6DL9tYQIe2nfBJW5yWdDCKcLNwyjw9eTZYo8m X-Received: by 2002:a17:906:3047:b0:99c:a23b:b4f4 with SMTP id d7-20020a170906304700b0099ca23bb4f4mr2526855ejd.2.1691682380742; Thu, 10 Aug 2023 08:46:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691682380; cv=none; d=google.com; s=arc-20160816; b=dig8Dy9pQdqREtTO54AZ/eLQv85i4wUKfV56oKlvrD/poKFdpcT6am8N5kbZae6wix qnRMCR2lDfSWyILgTHI7GQrHABFfpkieBJITXNnaBoxV6oLZ5jMd1+iEgB75E639xRkW RcHQIStKn77jkn5/5Vdtzg5ULdSDc58l/HC1DGCz3YTcSEKPnFl92axK7pbTTpkoFiUq Hts8HNdp3m/3astC6g4UNWIi7138NC0MbGqFwpPD0eSY344JANywbjcEp4AVVA0AHQaI jhS/nyP+ABfAsWYwUTa5bDRTqRSGSRzug9LGm58r6/buHyufwp6liGoE/lO4KtgkJJO1 Jb3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=qjUJdIFL1HZeT7ys7UKeK1mQkNu2fIAcouv/qSugj9Q=; fh=XbCdDhXV8ur38xFaHYMK2Xxk1Fn9iYAiw6iTuG9PVEc=; b=GPtqGxYR22KU7NJX4lkAOzhEeutnka0Hk9IOELiAq3xaoamj9qcs2TNm9BmYvhsIng DXqAO+qkyIjd5wnzcG4svMXJpEcD8cl4sSRZPjz+f9iPzX3rdOrxw8Mq5FI/O13PQzdi onGxITx2uc4stNzYNFdLX91xjV/F23uj/TRd/ohVAWGDz35imdrj7AsnTubIrJoexhjb y75PKKUqRR+612QcjGjnXhjg/OwRlxCutdzw3e3lD5ANZDynEcsuxflP0fXg/1zy5ewA qlgJAJc1ZW4m0zqc/RvSUw/+8MJAzskh5d47hzFu2mkQeiA/YBxwnUKFSVdR1gXYPYM+ /1Xg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=V43mVJhy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cf24-20020a170906b2d800b00988b90f50b3si1604690ejb.607.2023.08.10.08.45.44; Thu, 10 Aug 2023 08:46:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=V43mVJhy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235332AbjHJN3b (ORCPT + 99 others); Thu, 10 Aug 2023 09:29:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234838AbjHJN3a (ORCPT ); Thu, 10 Aug 2023 09:29:30 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC0E92115; Thu, 10 Aug 2023 06:29:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691674169; x=1723210169; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=EBF+COueCekwMR2I3qVFSbTuJOjqTaqeByXFOY1SFa4=; b=V43mVJhy0uKu/PV8VHWWRC4Ur/Z02/dR0wuHmF6kP602Ar9H4CwvUSzB XXzk/fIjM4ZGPl4snWZAwDjC18G6pwW5ssZ6RAPInCOvXn4268KjTfGAg 8Uc/SV7sekEcrl1SU3SBROBwZIOXyu8yrve12WsvV1nGMzZTVBYsOAYxg 6hKu4UbMoCZjFYgYvHpENJEGC/7wEVG8DHbtH4VWG+jaG8V0onReCx/Gk olIMBMWIGr6CTWHDZsIFebLaWkV1TQhnw7oD3m1IMO72/2FzmUqRJRAW2 503U5gU1eBR9oVeIVsBxc0cfIFDRptUcgekAdLtztG+d1EV4QXIhcwDmQ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10797"; a="374169989" X-IronPort-AV: E=Sophos;i="6.01,162,1684825200"; d="scan'208";a="374169989" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2023 06:29:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10797"; a="732231353" X-IronPort-AV: E=Sophos;i="6.01,162,1684825200"; d="scan'208";a="732231353" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga002.jf.intel.com with ESMTP; 10 Aug 2023 06:29:25 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qU5jB-002odo-3D; Thu, 10 Aug 2023 16:29:25 +0300 Date: Thu, 10 Aug 2023 16:29:25 +0300 From: Andy Shevchenko To: Matti Vaittinen Cc: Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Cameron , Lars-Peter Clausen Subject: Re: [PATCH v1 1/1] iio: accel: kionix-kx022a: Use correct header(s) instead of string_helpers.h Message-ID: References: <20230808164204.66818-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 09, 2023 at 09:00:39AM +0300, Matti Vaittinen wrote: > On 8/8/23 19:42, Andy Shevchenko wrote: > > There is nothing from string_helpers.h used in the driver, correct > > the header inclusion block accordingly. > > > > Signed-off-by: Andy Shevchenko > > Acked-by: Matti Vaittinen > > Out of the curiosity - is the goal to get rid of including choices from > helpers? (I think) then the header split would be more beneficial. At the end, yes. Thank you for acknowledging! -- With Best Regards, Andy Shevchenko