Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Aug 2023 18:19:17 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Bartosz Golaszewski <brgl@bgdev.pl>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Kent Gibson <warthog618@gmail.com>, linux-gpio@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH] gpiolib: fix reference leaks when removing GPIO chips
 still in use
Message-ID: <ZNT/9WqW4c0FwVlw@smile.fi.intel.com>
References: <20230810100335.9330-1-brgl@bgdev.pl>
 <ZNT/hvkZswZsZUFU@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZNT/hvkZswZsZUFU@smile.fi.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Thu, Aug 10, 2023 at 06:17:26PM +0300, Andy Shevchenko wrote:
> On Thu, Aug 10, 2023 at 12:03:34PM +0200, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

...

> >  void gpiod_free(struct gpio_desc *desc)
> >  {
> > -	if (desc && desc->gdev && gpiod_free_commit(desc)) {
> > -		module_put(desc->gdev->owner);
> > -		gpio_device_put(desc->gdev);
> > -	} else {
> > +	if (!desc)
> > +		return;

> 	VALIDATE_DESC_VOID() ?

If it is not possible to use, the comment should be added, like we have in
gpiod_to_irq().

> > +	if (!gpiod_free_commit(desc))
> >  		WARN_ON(extra_checks);
> > -	}
> > +
> > +	gpio_device_put(desc->gdev);
> > +	module_put(desc->gdev->owner);
> >  }

-- 
With Best Regards,
Andy Shevchenko