Received: by 2002:a05:6358:51dd:b0:131:369:b2a3 with SMTP id 29csp1319880rwl; Thu, 10 Aug 2023 09:24:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGLG+RzyqpjDeXgxpNcba5tX3cNnciAU/JzzJeR/HnhQzjLdCc2VgHG6FgPm0CFTp6AYOcm X-Received: by 2002:a05:6a20:2444:b0:140:3554:3f41 with SMTP id t4-20020a056a20244400b0014035543f41mr3441713pzc.54.1691684644363; Thu, 10 Aug 2023 09:24:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691684644; cv=none; d=google.com; s=arc-20160816; b=OkkeRqmDU02rbAY1gyXtpMhKTXtlfc0UKS0TZId5IL9G3QDRlFsDlfPk4fQJ9HB82e ggWQXcKeYUkX76iTLoYgvw4gNleUC2pS/fmgq+V3R783J9oYhx7ZbHFRyEBGLlxNcrxl 85MbDsHc9zfF6QgsUmzph6IVEF1XDM/MBRgtQO3Y908kDDopOiYSHHbVbzDPd1c8w93Z wv8LoMk4elX4TUBjmDfP1aBX+evnPRzACxswCPr92av0m2q1OpuJOkX1r7icqp3xkfff 5yZMznvqDW10EwHXSmLbcihyy9V5KHRNwS4zYEZrJHa4vPXUaSHLHA8Qhd1hBproxYLL krSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=ztgh/KJa3mGVj8PYr3funvOAXoUa+EZmzAt4oC8UWqw=; fh=woJdKc7Pl3s0sbPZtV5BBTGBSGnywl1OxnpFPlU6R+Y=; b=vAHUQzZXv7ChzZkSq5QxMpF9/vsPShxVRG4QYKma4sR65sgO65A7kcmPqul3f11D76 UYAouT3ahFU65fm4j9lcKuV3TeGnqHxRzgzUgoWECN8ZSDoUAUDPw+xIa/hcdS+ao1SP qF4f2Byw5bzf2x14QmQKmpCITJblsCEOvfd0i/pUzzygHcF0ht7/xrSqnHi/UVpNMrPH KDLz8MwxLCJSWnHL/5F0F8ddZ8o2sj8tiarJ9PNYD8yOuThALCvHHY3ibqbb9VjmSplH LcTsLxhs020uSTbGQWK9o6paeo8x2y5TAqQdam/Dcvp5wQFbjp27lvMStR+UAG2tENta CNuA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=eO8vzJse; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e4-20020a630f04000000b0054fe6b9502esi1710199pgl.687.2023.08.10.09.23.50; Thu, 10 Aug 2023 09:24:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=eO8vzJse; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236082AbjHJPYs (ORCPT + 99 others); Thu, 10 Aug 2023 11:24:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234177AbjHJPYr (ORCPT ); Thu, 10 Aug 2023 11:24:47 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8E272683; Thu, 10 Aug 2023 08:24:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691681086; x=1723217086; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=UvECL82g+PkLxcGldtfaglAh0LDEQ3C40it1tafVwr0=; b=eO8vzJseppjN0KutLRnZqlazTyep338gumlfakgjZ8LsUk3r8+epsdbZ qsrLJAOwRdq+1AZbm/q8w1i1xfKbJO/K5p5wGIlPOo2K2XlWd6LmMHsSP WX7m9OCCBoYgxrSnlSxtoLHCfWHyfmAO90j6iMExc2/5VVrIh/y3RPkTU EzF4T65gaqM+CiBl9fhsLqUOFewzq2y0ih0cXRcbHtelCenotuPr+UZNA rHg4skLCsh7we2UVQVrt+8qCYedf7wNbJAMFZlj7XZE9NssOSF7F12ojE p/Vv8im8uQ4jnV0fIb/0xoUKh6+yhlyW9Su43RPn00KZOIcKfPhd2PqlZ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10798"; a="457804600" X-IronPort-AV: E=Sophos;i="6.01,162,1684825200"; d="scan'208";a="457804600" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2023 08:24:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10798"; a="846438063" X-IronPort-AV: E=Sophos;i="6.01,162,1684825200"; d="scan'208";a="846438063" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP; 10 Aug 2023 08:24:15 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qU7WH-006jHL-2E; Thu, 10 Aug 2023 18:24:13 +0300 Date: Thu, 10 Aug 2023 18:24:13 +0300 From: Andy Shevchenko To: Tony Lindgren Cc: Greg Kroah-Hartman , Jiri Slaby , Dhruva Gole , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , John Ogness , Johan Hovold , Sebastian Andrzej Siewior , Vignesh Raghavendra , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Guenter Roeck Subject: Re: [PATCH] serial: core: Fix serial core port id, including multiport devices Message-ID: References: <20230810065737.47294-1-tony@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230810065737.47294-1-tony@atomide.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 10, 2023 at 09:57:34AM +0300, Tony Lindgren wrote: > We want to fix the serial core port DEVNAME to use a port id of the > hardware specific controller port instance instead of the port->line. > > For example, the 8250 driver sets up a number of serial8250 ports > initially that can be inherited by the hardware specific driver. At that > the port->line no longer decribes the port's relation to the serial core > controller instance. > > Let's fix the issue by assigning port->port_id for each serial core > controller port instance. ... > + unsigned int min = 0, max = ~0U; Shouldn't this be int? The max IIRC will be INT_MAX with this anyway. -- With Best Regards, Andy Shevchenko