Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c79f578f-74eb-c6ed-ead6-3058483f9982@quicinc.com>
Date:   Thu, 10 Aug 2023 20:15:47 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH 0/6] soc: qcom: llcc: Add support for QDU1000/QRU1000
Content-Language: en-US
To:     Komal Bajaj <quic_kbajaj@quicinc.com>, <agross@kernel.org>,
        <andersson@kernel.org>, <konrad.dybcio@linaro.org>,
        <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <conor+dt@kernel.org>, <srinivas.kandagatla@linaro.org>
CC:     <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20230810061140.15608-1-quic_kbajaj@quicinc.com>
From:   Mukesh Ojha <quic_mojha@quicinc.com>
In-Reply-To: <20230810061140.15608-1-quic_kbajaj@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

nit: Version v7 missed in subject..

-Mukesh

On 8/10/2023 11:41 AM, Komal Bajaj wrote:
> This patch series does the following -
>   * Refactor LLCC driver to support multiple configuration
>   * Add stub function for nvmem_cell_read_u8
>   * Add support for multi channel DDR configuration in LLCC
>   * Add LLCC support for the Qualcomm QDU1000 and QRU1000 SoCs
> 
> Changes in v7 -
>   - Changed the macro name as suggested by Mukesh.
>   - Added NULL check for llcc cfgs as suggested by Mukesh.
>   - Updated the num_config for qdu1000 to use ARRAY_SIZE().
>   - Link to v6: https://lore.kernel.org/lkml/20230802091429.20892-1-quic_kbajaj@quicinc.com/
> 
> Changes in v6 -
>   - Changed variable name from num_cfgs to num_config as suggested by Mukesh.
>   - Added a check for default llcc configuration as per suggestion from Mukesh.
>   - Updated the commit summary for the third and fifth patch.
>   - Fixed alignment in the fourth patch.
>   - Used ARRAY_SIZE() to calculate the num_config as per suggested by Konrad.
>   - Link to v5: https://lore.kernel.org/lkml/20230724084155.8682-1-quic_kbajaj@quicinc.com/
> 
> Changes in v5 -
>   - Separated out the secure qfprom driver changes to a separate series [1].
>   - Created a wrapper struct with a pointer to qcom_llcc_config and
>     length of array qcom_llcc_config.
>   - Added stub function for nvmem_cell_read_u8.
>   - Split commit 6/6 in the previous series into two commits.
>   - Link to v4: https://lore.kernel.org/lkml/20230623141806.13388-1-quic_kbajaj@quicinc.com/
> 
> Changes in v4 -
>   - Created a separate driver for reading from secure fuse region as suggested.
>   - Added patch for dt-bindings of secure qfprom driver accordingly.
>   - Added new properties in the dt-bindings for LLCC.
>   - Implemented new logic to read the nvmem cell as suggested by Bjorn.
>   - Separating the DT patches from this series as per suggestion.
>   - Link to v3: https://lore.kernel.org/lkml/20230512122134.24339-1-quic_kbajaj@quicinc.com/
> 
> Changes in v3 -
>   - Addressed comments from Krzysztof and Mani.
>   - Using qfprom to read DDR configuration from feature register.
>   - Link to v2: https://lore.kernel.org/lkml/20230313124040.9463-1-quic_kbajaj@quicinc.com/
> 
> Changes in v2:
>    - Addressing comments from Konrad.
>    - Link to v1: https://lore.kernel.org/lkml/20230313071325.21605-1-quic_kbajaj@quicinc.com/
> 
> [1] https://lore.kernel.org/linux-arm-msm/20230724082946.7441-1-quic_kbajaj@quicinc.com/
> 
> Komal Bajaj (6):
>    dt-bindings: cache: qcom,llcc: Add LLCC compatible for QDU1000/QRU1000
>    soc: qcom: llcc: Refactor llcc driver to support multiple
>      configuration
>    nvmem: core: Add stub for nvmem_cell_read_u8
>    soc: qcom: Add LLCC support for multi channel DDR
>    soc: qcom: llcc: Updating the macro name
>    soc: qcom: llcc: Add QDU1000 and QRU1000 LLCC support
> 
>   .../devicetree/bindings/cache/qcom,llcc.yaml  |  10 +
>   drivers/soc/qcom/llcc-qcom.c                  | 363 +++++++++++++-----
>   include/linux/nvmem-consumer.h                |   6 +
>   include/linux/soc/qcom/llcc-qcom.h            |   2 +-
>   4 files changed, 293 insertions(+), 88 deletions(-)
> 
> --
> 2.41.0
>