Received: by 2002:ac8:5491:0:b0:40f:fb00:664b with SMTP id h17csp604859qtq; Thu, 10 Aug 2023 10:16:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHdOdBNgrXEoPSLWnDHMDZkEivAcmEBoYLBGc2Gj8Vu40LtysDMkxc2KRBWGI7iWFLwEMov X-Received: by 2002:a17:907:2bf9:b0:98e:370c:be69 with SMTP id gv57-20020a1709072bf900b0098e370cbe69mr3367848ejc.6.1691687815761; Thu, 10 Aug 2023 10:16:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691687815; cv=none; d=google.com; s=arc-20160816; b=L+vJGAGPuE7GSg399aN9rDcVz0zGeBAzuyCOSDahzHMluDJmBAPCMO3UxZE8lfbGnW +wi+LhPiD8HqdcAxW51vlpVhNt0GrgiPpbzGmdQu+Kvtm+Ng0Gfc5Y7lrlVng+rny1TE q826E+A3e30E8uEUK/7SRl3va1hUrTiOh8tDOzNlAys4cHM0lyFAiLubxFydVDfAwN1V 42aQoumCgHdlWLT/cd5YXCK6dvQDoiT6vxKM7GUGgHs1bW2CsL12bcHA8l32J4qXx8l4 zwiSwr3JrrBXG1zU8VzsU6YdXVfx1UMmfyyWkELiBKkveICQtRUJnIHUjYJlT50zEcRu 7Apw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=FQTCIdCDZFdwitFmat+HWiYspb+Ntw8Z6YHrX5EBeRQ=; fh=yBPlnD05ny+VnP0TnWAkc61Jcp2MhG1ZxgIjU2akszo=; b=slxU6Mf4k/dvPlaiR3O+CDGY7fujVtP+hlOalu3cRSNoH/ZT3Km1cAm6OF/oeNKuAb ff00QiiZf6fSwgLaGKOnha01SqtU2k3HHTwPLZO4C52u5BCjWxYRz2yDmswRxfSWJ2O4 wxNt2MCrGdpkrRmy9UXZjd0eD0rYGTo43pH4kHsZonDSNMCIU8772+Ak4Mf1wP5zDTMP W7G/EGvDg1Qt8yJVpupfb79FM1wks/C+2DdJwH5jKHhaUI1yJBRFg6pGixIfRalNDLhN DmmGL8y6S4mGhtQg5WtJ7ibdZR6uUkABMDzZjKO3+Hhhi+QAz5W8dduJi/xU8c9VECX5 BcEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=aSq+mqx+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y9-20020a170906558900b0099bd00f8f73si1773296ejp.742.2023.08.10.10.16.30; Thu, 10 Aug 2023 10:16:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=aSq+mqx+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235531AbjHJPUd (ORCPT + 99 others); Thu, 10 Aug 2023 11:20:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230123AbjHJPUc (ORCPT ); Thu, 10 Aug 2023 11:20:32 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8571890; Thu, 10 Aug 2023 08:20:31 -0700 (PDT) Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37ADTO5g022254; Thu, 10 Aug 2023 15:19:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=qcppdkim1; bh=FQTCIdCDZFdwitFmat+HWiYspb+Ntw8Z6YHrX5EBeRQ=; b=aSq+mqx+9R+U3Kltk2BFd2Lg13jEMLyL9sxYpoTNTrQgG42WA+Egj81wnXn6h6TTY6WL ///Yd0dZPhlNMLPG8B5rpx9niWtQjwRln6npE6/TP7eXkPVdg7P7XPQMqozbh22znLf3 nQXOly7eWYGoQS4CS8AXBDOfp3V/5x9gEi36eaJMfr9XwaXsM2mVyKNQMURSNqkYZBOg yBYC7UOCt+9hdeqZcNTMCJOzKjWKS2oMtxvKHGWLvdZEL9ju79szHLgGe20bBjdfD8xb jrD2AaWQwJtIol9/9snycGIdeHm7+81B7Hx67fnTe6QKI9SITmkGysDP+9lryDETrHhy Jw== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3scqsj1f1v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Aug 2023 15:19:56 +0000 Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 37AFJdxM003329 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Aug 2023 15:19:40 GMT Received: from hu-bjorande-lv.qualcomm.com (10.49.16.6) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Thu, 10 Aug 2023 08:19:39 -0700 Date: Thu, 10 Aug 2023 08:19:38 -0700 From: Bjorn Andersson To: Varadarajan Narayanan CC: , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v7 2/5] phy: qcom-m31: Introduce qcom,m31 USB phy driver Message-ID: <20230810151938.GP1428172@hu-bjorande-lv.qualcomm.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01b.na.qualcomm.com (10.47.209.197) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: 4z3Pg5_OydcxxP-Hb2M4_Cj_bUNVhuis X-Proofpoint-GUID: 4z3Pg5_OydcxxP-Hb2M4_Cj_bUNVhuis X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-08-10_12,2023-08-10_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 impostorscore=0 phishscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 clxscore=1011 suspectscore=0 mlxscore=0 mlxlogscore=729 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2308100131 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 10, 2023 at 03:26:05PM +0530, Varadarajan Narayanan wrote: "qcom,m31" is quite DT-ish, how about: "phy: qcom: Introduce M31 USB PHY driver" > Add the M31 USB2 phy driver. Please expand this. The documentation [1] says "describe your problem", so you can at least state what the M31 driver is and/or where this block is found. [1] https://docs.kernel.org/process/submitting-patches.html#describe-your-changes Thanks for addressing my previous feedback. Regards, Bjorn