Received: by 2002:ac8:5491:0:b0:40f:fb00:664b with SMTP id h17csp609240qtq; Thu, 10 Aug 2023 10:24:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHBx1YjTC127VmbW5g0kQL2KgpYboO8TbVWpQBjEJljhBuyevTkWNoeas5bWii/Qnr/6qzH X-Received: by 2002:aa7:cfd8:0:b0:522:d6f4:c0e9 with SMTP id r24-20020aa7cfd8000000b00522d6f4c0e9mr2628809edy.38.1691688247345; Thu, 10 Aug 2023 10:24:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691688247; cv=none; d=google.com; s=arc-20160816; b=VrwDE0v5cM2RMzfUB3mgRn7sRQSL9bcs+feI/B420KWG+Gx6ChY97bzXJG55Ya8Wks Ph56osWRcLPVZxfwYm68qUkAm0SiSBr3FxiclVxZ4mtTqWT7HV22FbxgFfuP7NKt5OGN jaqWNLxdqHIPjDtFQsXhvw8pKAT5WRqBHs2JC8wfaqFLMAzdVHqps+Rz6Gu4M9KE9j5y R4pbxKCXMxYFNJ07ZChH+ujNKZuB0+Ri02Feay4C1gJPRBc3VoZqkaVjxKAJHTFqA5wC DIRtLJF/uarCDaJhhadLTpJTVRf/pyBDDCLu1H2ec9t0iwdXUsEJNOqrLZZH5sga1kru ddMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=bVRyY1bhsaY6Jo9NKzEguwua3pCnw4meOhY+f6OVpI0=; fh=woJdKc7Pl3s0sbPZtV5BBTGBSGnywl1OxnpFPlU6R+Y=; b=VPidK5Tk1MaDYC2dzqtQsTkn08VEkdlRNvQZfMU7diNFTKAJXcx9RGadeF6Q0qfQfx pm+rC7ejrKHHop/9PgX1C2XPeRgA9pPeZXyMEZCJMEhXfEyJaXfD2onNI1n12FUuJAXD bR9/6RvhP0T6qQemYy54nfHOQ1intKwBx9fQcCPeN/mqiXT5GBzeUxJazibCtTtNb4p6 xEyrZ7aMNMEktCS4ARcFsR48cCF2AxpNxlSllixwwvazyrFWKKpv0+9pmwiA76dWhYl7 dykUaYc1LRClNrgsaeZqwOggO1WsldzZtg66AT3zqGuSWrwFWTLmoYjnd19UKM5dFzfE W/1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=euSPaAUP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z23-20020aa7d417000000b00522c1ee3579si1809938edq.640.2023.08.10.10.23.42; Thu, 10 Aug 2023 10:24:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=euSPaAUP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236109AbjHJP1A (ORCPT + 99 others); Thu, 10 Aug 2023 11:27:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236142AbjHJP07 (ORCPT ); Thu, 10 Aug 2023 11:26:59 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DAEA32683; Thu, 10 Aug 2023 08:26:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691681218; x=1723217218; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=vItw+p71ekRR6tJeARewzkH/w4ZrU+DYKsLqvhy5igA=; b=euSPaAUPakUNPt5OGERePHoJcZ3oLQiKL9T8oUcndTIr2I1G9C4uk6vH C/J9JIVo9wsDmPRJZ44aW3Q4t/fCFOtWeIzunUnqhjcxCPGFxtw4xwucu HL+NZNL0YDEzRtGxmvlyXrarq2AfTSLWthiEJg/n9whuE9s748VQZ66AP 6tg2SeK84bYj/cP54fQq3CK7Gg/npn16tdo/i9ArigNDW1w6gL2sFh7N+ f7xjGIypgquKSgco3oesHvO8dWUP9QlIH2aB5ISOMC++osAO77/8ARapR x40NhzFkerJvEtbZIHDlKiqTMjb+hEC7iK+vkUjc5v4vSvljZILuS51zL g==; X-IronPort-AV: E=McAfee;i="6600,9927,10798"; a="457805201" X-IronPort-AV: E=Sophos;i="6.01,162,1684825200"; d="scan'208";a="457805201" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2023 08:26:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10798"; a="846438500" X-IronPort-AV: E=Sophos;i="6.01,162,1684825200"; d="scan'208";a="846438500" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP; 10 Aug 2023 08:26:55 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qU7Yr-006p5v-2o; Thu, 10 Aug 2023 18:26:53 +0300 Date: Thu, 10 Aug 2023 18:26:53 +0300 From: Andy Shevchenko To: Tony Lindgren Cc: Greg Kroah-Hartman , Jiri Slaby , Dhruva Gole , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , John Ogness , Johan Hovold , Sebastian Andrzej Siewior , Vignesh Raghavendra , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Guenter Roeck Subject: Re: [PATCH] serial: core: Fix serial core port id, including multiport devices Message-ID: References: <20230810065737.47294-1-tony@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 10, 2023 at 06:24:13PM +0300, Andy Shevchenko wrote: > On Thu, Aug 10, 2023 at 09:57:34AM +0300, Tony Lindgren wrote: ... > > + unsigned int min = 0, max = ~0U; > > Shouldn't this be int? The max IIRC will be INT_MAX with this anyway. Ah, and then you can supply is as 0 (IIRC). -- With Best Regards, Andy Shevchenko