Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Frank Sorenson <frank.sorenson@gmail.com>
From:   Frank Sorenson <frank@tuxrocks.com>
Message-ID: <85cc0147-2fd0-de22-4ff6-57705983c968@redhat.com>
Date:   Thu, 10 Aug 2023 13:04:21 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH 1/2] fat: remove i_version handling from fat_update_time
To:     Jeff Layton <jlayton@kernel.org>,
        Christian Brauner <brauner@kernel.org>,
        OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
        Jan Kara <jack@suse.com>
Cc:     linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
References: <20230810-ctime-fat-v1-0-327598fd1de8@kernel.org>
 <20230810-ctime-fat-v1-1-327598fd1de8@kernel.org>
Content-Language: en-US
In-Reply-To: <20230810-ctime-fat-v1-1-327598fd1de8@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 8/10/23 08:12, Jeff Layton wrote:
> commit 6bb885ecd746 (fat: add functions to update and truncate
> timestamps appropriately") added an update_time routine for fat. That
> patch added a section for handling the S_VERSION bit, even though FAT
> doesn't enable SB_I_VERSION and the S_VERSION bit will never be set when
> calling it.
>
> Remove the section for handling S_VERSION since it's effectively dead
> code, and will be problematic vs. future changes.
>
> Cc: Frank Sorenson <sorenson@redhat.com>
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---

Reviewed-by: Frank Sorenson <sorenson@redhat.com>

>   fs/fat/misc.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/fs/fat/misc.c b/fs/fat/misc.c
> index ab28173348fa..37f4afb346af 100644
> --- a/fs/fat/misc.c
> +++ b/fs/fat/misc.c
> @@ -354,9 +354,6 @@ int fat_update_time(struct inode *inode, int flags)
>   			dirty_flags |= I_DIRTY_SYNC;
>   	}
>   
> -	if ((flags & S_VERSION) && inode_maybe_inc_iversion(inode, false))
> -		dirty_flags |= I_DIRTY_SYNC;
> -
>   	__mark_inode_dirty(inode, dirty_flags);
>   	return 0;
>   }
>