Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <2322cf5f-66e2-cba1-a95a-83bceb3aa2c8@roeck-us.net>
Date:   Thu, 10 Aug 2023 11:01:29 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] Add Silicom Platform Driver
Content-Language: en-US
To:     Huibin Shi <henrys@silicom-usa.com>,
        =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc:     "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "bp@alien8.de" <bp@alien8.de>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "x86@kernel.org" <x86@kernel.org>, "hpa@zytor.com" <hpa@zytor.com>,
        "hdegoede@redhat.com" <hdegoede@redhat.com>,
        "markgross@kernel.org" <markgross@kernel.org>,
        "jdelvare@suse.com" <jdelvare@suse.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "platform-driver-x86@vger.kernel.org" 
        <platform-driver-x86@vger.kernel.org>,
        "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
        "hb_shi2003@yahoo.com" <hb_shi2003@yahoo.com>,
        Wen Wang <wenw@silicom-usa.com>
References: <20230718160104.2716-1-henryshi2018@gmail.com>
 <94cbb7d-68a-765-8bdf-5c8f8e41891@linux.intel.com>
 <PA4PR04MB922224D96319862CF987FE459A06A@PA4PR04MB9222.eurprd04.prod.outlook.com>
 <58da791d-866c-ce2f-94bb-1feff8506c2@linux.intel.com>
 <PA4PR04MB922238E924D10FE9A5B2625D9A13A@PA4PR04MB9222.eurprd04.prod.outlook.com>
From:   Guenter Roeck <linux@roeck-us.net>
In-Reply-To: <PA4PR04MB922238E924D10FE9A5B2625D9A13A@PA4PR04MB9222.eurprd04.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 8/10/23 10:48, Huibin Shi wrote:
> Ilpo,
> 
> See my comments below.
> 
> Thanks.
> Henry
> ----Original Message-----
> From: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Sent: Thursday, August 3, 2023 8:07 AM
> To: Huibin Shi <henrys@silicom-usa.com>
> Cc: tglx@linutronix.de; mingo@redhat.com; bp@alien8.de; dave.hansen@linux.intel.com; x86@kernel.org; hpa@zytor.com; hdegoede@redhat.com; markgross@kernel.org; jdelvare@suse.com; linux@roeck-us.net; linux-kernel@vger.kernel.org; platform-driver-x86@vger.kernel.org; linux-hwmon@vger.kernel.org; hb_shi2003@yahoo.com; Wen Wang <wenw@silicom-usa.com>
> Subject: RE: [PATCH] Add Silicom Platform Driver
> 
> Caution: This is an external email. Please take care when clicking links or opening attachments.
> 
> 
> On Fri, 28 Jul 2023, Huibin Shi wrote:
> 
>> Ilpo,
>>
>> Thanks for the comments. See my comments below.
>>
>> Updated patch will be sent out later after review comments from other reviewer are addressed.
>>
>> Henry
>> -----Original Message-----
>> From: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
>> Sent: Wednesday, July 19, 2023 8:13 AM
>> To: Henry Shi <henryshi2018@gmail.com>
>> Cc: hbshi69@hotmail.com; tglx@linutronix.de; mingo@redhat.com;
>> bp@alien8.de; dave.hansen@linux.intel.com; x86@kernel.org;
>> hpa@zytor.com; hdegoede@redhat.com; markgross@kernel.org;
>> jdelvare@suse.com; linux@roeck-us.net; LKML
>> <linux-kernel@vger.kernel.org>; platform-driver-x86@vger.kernel.org;
>> linux-hwmon@vger.kernel.org; hb_shi2003@yahoo.com; Huibin Shi
>> <henrys@silicom-usa.com>; Wen Wang <wenw@silicom-usa.com>
>> Subject: Re: [PATCH] Add Silicom Platform Driver
>>
>> Caution: This is an external email. Please take care when clicking links or opening attachments.
>>
>>
>> On Tue, 18 Jul 2023, Henry Shi wrote:
>>
>>> The Silicom platform (silicom-platform) Linux driver for Swisscom
>>> Business Box (Swisscom BB) as well as Cordoba family products is a
>>> software solution designed to facilitate the efficient management
>>> and control of devices through the integration of various Linux
>>> frameworks. This platform driver provides seamless support for
>>> device management via the Linux LED framework, GPIO framework,
>>> Hardware Monitoring (HWMON), and device attributes. The Silicom
>>> platform driver's compatibility with these Linux frameworks allows
>>> applications to access and control Cordoba family devices using
>>> existing software that is compatible with these frameworks. This
>>> compatibility simplifies the development process, reduces
>>> dependencies on proprietary solutions, and promotes interoperability
>>> with other Linux-based systems and software.
>>>
>>> Signed-off-by: Henry Shi <henryshi2018@gmail.com>
>>> ---
>>>   drivers/platform/x86/Kconfig            |   12 +
>>>   drivers/platform/x86/Makefile           |    1 +
>>>   drivers/platform/x86/silicom-platform.c | 1123
>>> +++++++++++++++++++++++
>>>   3 files changed, 1136 insertions(+)  create mode 100644
>>> drivers/platform/x86/silicom-platform.c
>>>
> 
>>> +void lock_io_modules(void)
>>> +{
>>> +     mutex_lock(&mec_io_mutex);
>>> +}
>>> +EXPORT_SYMBOL(lock_io_modules);
>>> +
>>> +void unlock_io_modules(void)
>>> +{
>>> +     mutex_unlock(&mec_io_mutex);
>>> +}
>>> +EXPORT_SYMBOL(unlock_io_modules);
> 
> These are unused.
> 
> Henry: This will be used by another Silicom driver, which source code is not pushed to kernel repository.
> 

Besides, those function names are _way_ too generic for public symbols,
and even more so for exports.

Guenter