Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Aug 2023 20:26:44 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Hari Nagalla <hnagalla@ti.com>
Cc:     andersson@kernel.org, mathieu.poirier@linaro.org,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        conor+dt@kernel.org, s-anna@ti.com,
        linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: remoteproc: k3-dsp: correct optional sram
 properties for AM62A SoCs
Message-ID: <20230810-dramatic-disregard-c254d763e1fe@spud>
References: <20230810110545.11644-1-hnagalla@ti.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="pXtfXRWhPXTRbs8a"
Content-Disposition: inline
In-Reply-To: <20230810110545.11644-1-hnagalla@ti.com>
Precedence: bulk


--pXtfXRWhPXTRbs8a
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Aug 10, 2023 at 06:05:45AM -0500, Hari Nagalla wrote:
> The C7xv-dsp on AM62A have 32KB L1 I-cache and a 64KB L1 D-cache. It
> does not have an addressable l1dram . So, remove this optional sram
> property from the bindings to fix device tree build warnings.
>=20
> Also set the 'memory-regions' property as optional. This is because
> the remote processors can function without carveout regions.

I thought I already said this today, but must be hallucinating - this
second part here seems like it in an unrelated change that should go in
its own patch..

>=20
> Signed-off-by: Hari Nagalla <hnagalla@ti.com>
> ---
>  .../bindings/remoteproc/ti,k3-dsp-rproc.yaml     | 16 ++++++++++++++--
>  1 file changed, 14 insertions(+), 2 deletions(-)
>=20
> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc=
=2Eyaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> index f16e90380df1..8dd22c57e22d 100644
> --- a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> @@ -111,7 +111,6 @@ else:
>      properties:
>        compatible:
>          enum:
> -          - ti,am62a-c7xv-dsp
>            - ti,j721e-c71-dsp
>            - ti,j721s2-c71-dsp
>    then:
> @@ -124,6 +123,20 @@ else:
>          items:
>            - const: l2sram
>            - const: l1dram
> +  else:
> +    if:
> +      properties:
> +        compatible:
> +          enum:
> +            - ti,am62a-c7xv-dsp
> +    then:
> +      properties:
> +        reg:
> +          items:
> +            - description: Address and Size of the L2 SRAM internal memo=
ry region
> +        reg-names:
> +          items:
> +            - const: l2sram
> =20
>  required:
>    - compatible
> @@ -135,7 +148,6 @@ required:
>    - resets
>    - firmware-name
>    - mboxes
> -  - memory-region
> =20
>  unevaluatedProperties: false
> =20
> --=20
> 2.34.1
>=20

--pXtfXRWhPXTRbs8a
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZNU59AAKCRB4tDGHoIJi
0ujdAP9/gwpeMbJnjqYnN0kVayzEgItu2KClO+kgQ81UuQw4NgEA5Y6J+VbZyben
m5NLRRbeqxk7L2omT+VGx0b9piUZ5AM=
=czQE
-----END PGP SIGNATURE-----

--pXtfXRWhPXTRbs8a--