Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230808091849.505809-1-suhui@nfschina.com>
In-Reply-To: <20230808091849.505809-1-suhui@nfschina.com>
From:   Amir Goldstein <amir73il@gmail.com>
Date:   Thu, 10 Aug 2023 20:58:16 +0300
Message-ID: <CAOQ4uxhtZSr-kq3G1vmm4=GyBO3E5RdSbGSp108moRiRBx4vvg@mail.gmail.com>
Subject: Re: [PATCH] fanotify: avoid possible NULL dereference
To:     Su Hui <suhui@nfschina.com>
Cc:     jack@suse.cz, repnop@google.com, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Aug 8, 2023 at 12:19=E2=80=AFPM Su Hui <suhui@nfschina.com> wrote:
>
> smatch error:
> fs/notify/fanotify/fanotify_user.c:462 copy_fid_info_to_user():
> we previously assumed 'fh' could be null (see line 421)
>
> Fixes: afc894c784c8 ("fanotify: Store fanotify handles differently")
> Signed-off-by: Su Hui <suhui@nfschina.com>'

Reviewed-by: Amir Goldstein <amir73il@gmail.com>

> ---
>  fs/notify/fanotify/fanotify_user.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/notify/fanotify/fanotify_user.c b/fs/notify/fanotify/fano=
tify_user.c
> index f69c451018e3..5a5487ae2460 100644
> --- a/fs/notify/fanotify/fanotify_user.c
> +++ b/fs/notify/fanotify/fanotify_user.c
> @@ -459,12 +459,13 @@ static int copy_fid_info_to_user(__kernel_fsid_t *f=
sid, struct fanotify_fh *fh,
>         if (WARN_ON_ONCE(len < sizeof(handle)))
>                 return -EFAULT;
>
> -       handle.handle_type =3D fh->type;
>         handle.handle_bytes =3D fh_len;
>
>         /* Mangle handle_type for bad file_handle */
>         if (!fh_len)
>                 handle.handle_type =3D FILEID_INVALID;
> +       else
> +               handle.handle_type =3D fh->type;
>
>         if (copy_to_user(buf, &handle, sizeof(handle)))
>                 return -EFAULT;
> --
> 2.30.2
>