Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Aug 2023 20:30:21 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Guido =?iso-8859-1?Q?G=FCnther?= <guido.gunther@puri.sm>
Cc:     David Heidelberg <david@ixit.cz>, Marek Vasut <marex@denx.de>,
        Stefan Agner <stefan@agner.ch>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Liu Ying <victor.liu@nxp.com>, kernel@puri.sm,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Rob Herring <robh@kernel.org>, dri-devel@lists.freedesktop.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: mxsfb: Exclude i.MX8MQ from power-domains
 requirement
Message-ID: <20230810-embroider-seduce-ee4506e7608b@spud>
References: <20230730184120.94984-1-david@ixit.cz>
 <ZMonFSqutQRqs61n@qwark.sigxcpu.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="yVk3JZ7fl+mjKj73"
Content-Disposition: inline
In-Reply-To: <ZMonFSqutQRqs61n@qwark.sigxcpu.org>
Precedence: bulk


--yVk3JZ7fl+mjKj73
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Aug 02, 2023 at 11:51:17AM +0200, Guido G=FCnther wrote:
> Hi,
> On Sun, Jul 30, 2023 at 09:41:20PM +0300, David Heidelberg wrote:
> > i.MX8MQ uses as secondary compatible fsl,imx6sx-lcdif, which triggers
> > requirement of power-domains, thou it's not required.
> >=20
> > Fixes: f62678a77d58 ("dt-bindings: mxsfb: Document i.MX8M/i.MX6SX/i.MX6=
SL power-domains property")
> >=20
> > Signed-off-by: David Heidelberg <david@ixit.cz>
> > ---
> >  .../devicetree/bindings/display/fsl,lcdif.yaml        | 11 +++++++++--
> >  1 file changed, 9 insertions(+), 2 deletions(-)
> >=20
> > diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b=
/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> > index fc11ab5fc465..2d868276b0f9 100644
> > --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> > +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> > @@ -129,8 +129,15 @@ allOf:
> >                - fsl,imx8mp-lcdif
> >                - fsl,imx93-lcdif
> >      then:
> > -      required:
> > -        - power-domains
> > +      if:
> > +        properties:
> > +          compatible:
> > +            not:
> > +              contains:
> > +                const: fsl,imx8mq-lcdif
> > +      then:
> > +        required:
> > +          - power-domains
>=20
> We currently enable the mipi power domain for the mipi dphy and nwl
> bridge only but not for LCDIF itself assuming it's not needed (as there's
> other outputs LCDIF can drive). I *think* this is correct but maybe
> Marek or Liu can confirm?

I'm happy to Ack this, but I've been sitting on it waiting to see if
Marek or Liu popped up..

--yVk3JZ7fl+mjKj73
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZNU6zQAKCRB4tDGHoIJi
0s2nAP9Dmws9nUO7FWU2dnCYapILH8BgEDhPZlOjfqFaw+mE+QD/atHR0u47ijBF
egbmUZYBYV2cDqiKmos4DpMp6XI4WAY=
=OYJ6
-----END PGP SIGNATURE-----

--yVk3JZ7fl+mjKj73--