Received: by 2002:a05:7412:6592:b0:d7:7d3a:4fe2 with SMTP id m18csp635276rdg; Thu, 10 Aug 2023 14:20:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IERhq2FU9WGwOKsyZpgSXDHxf3LlLiWa3MBgYm4tmb8w/Xlli8dG5QrnQMmcV4Lc0G32y+n X-Received: by 2002:a17:902:db03:b0:1b8:9b17:f63d with SMTP id m3-20020a170902db0300b001b89b17f63dmr4200984plx.23.1691702425410; Thu, 10 Aug 2023 14:20:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691702425; cv=none; d=google.com; s=arc-20160816; b=08i7MXct+u9GvtLbrMIOokwxup6HAzSgoJJp6XV7kC2iloP8PId5S5bN5pwjD40REM a0PKlc5zAvo2L/QZmOVhTX0zb2hFK3f7iIEZ8Q+c2464bYh9v0Ls3z2BgzcXC0KRwTfo FGeWUZmnCiGJdols+kpdC6d9I7YmygKD0MohbzLdfeNuZYd2YUY4l7duxTAqiH3c8I6T Rb4vOY23oHxbUZajFC1BP5G4RD7fIwvfn9PbefCwcL1Lr4BeNV2vadItSZ3zbr4C2OPK eYUMdKT/LQbjyHFk1KbtKeM4/pM5fM2iF5OjBKas3vy4ET14iV5eRdO+uPaMFGwB9RAx X+Nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=mTP2DRBRmsnPZQwxDHVj0VRoZbB8fN71zlah4Js1n+A=; fh=8ATHuATV7EJq37KFFdxCqju7Iiyb9ne09LyMCkx3MMk=; b=AtsDZaynvQpL8qqggmszwGzpM5S69YXhf/05NOpdxxit1wiIIlFClcO9uiqhQkPpMF Pw12T1R0uKKSMDG2VySV5aobMeUNm6cDbnikuQibKFRO2KdXmgMGb5nTdLiQz9fpOyW8 aTbyD1tgQgSeZanrqtUpDPLJ2Rf+BU2oL4l0BJmJU19u61H+bWiZQL2vPZ2Tu9dyt/uU La83G2k6Thi0jSLEfSYqt/daCo8JggdINda7ne14iKm2qBqKdP0sbbfCMNAxCwv253Jf C4HBvUX3q4ikbfheESxeIGHhMbfVhG4hygqQj5QY47md8eegCAPCbZd3mRIMpzZvENS6 KoqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DSf0elE5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u15-20020a170902e5cf00b001bb95a5cb9fsi2145934plf.522.2023.08.10.14.20.13; Thu, 10 Aug 2023 14:20:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DSf0elE5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235004AbjHJUqb (ORCPT + 99 others); Thu, 10 Aug 2023 16:46:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232956AbjHJUqb (ORCPT ); Thu, 10 Aug 2023 16:46:31 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D19C1BF7 for ; Thu, 10 Aug 2023 13:46:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2242C63DFA for ; Thu, 10 Aug 2023 20:46:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12D18C433C9; Thu, 10 Aug 2023 20:46:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691700389; bh=/L1/FoIolTCX5+WO1AdKsvpi/9tkJrtA02vyz07SQxI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DSf0elE5/+x+ysK6HrH2O7I9Zc8jcBnZLRrpmX5p32f00gEXV58IY3TspVfxphrVx vbfHvAGur24PsvXR66o0FN+OeK5fwQ+gHISM9LZ6KQsoHTn7+6uHP3dPddTv+KFnC8 qpnb1EUjGtkb6BqS9Dj1Hu20kn+3Mfqqs7SyQNkILQrf4TCygqkiLxOmgje6Crxbua dW2BUae3XS06mcR05vZdBSLsx0i5YjAtwGL0oSTgdp1Rwrj68LROeMVYhWTfYN5KOO sFo0EtpRXo0+XAAPXYQzcm2asCtDNENXxqC3WKWKBfrL6OLsPMR9NumlQq/J0SCkVD H7HvMLIUSUkrQ== Date: Thu, 10 Aug 2023 22:46:23 +0200 From: Simon Horman To: Arnd Bergmann Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Arnd Bergmann , Geoff Levand , Petr Machata , Piotr Raczynski , Wolfram Sang , Liang He , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] ethernet: ldmvsw: mark ldmvsw_open() static Message-ID: References: <20230810122528.1220434-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230810122528.1220434-1-arnd@kernel.org> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 10, 2023 at 02:25:15PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > The function is exported for no reason and should just be static: > > drivers/net/ethernet/sun/ldmvsw.c:127:5: error: no previous prototype for 'ldmvsw_open' [-Werror=missing-prototypes] > > Signed-off-by: Arnd Bergmann Reviewed-by: Simon Horman Tested-by: Simon Horman # build-tested