Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Aug 2023 13:50:17 -0700
From:   Ashok Raj <ashok.raj@intel.com>
To:     Peter Zijlstra <peterz@infradead.org>
CC:     Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>, <x86@kernel.org>,
        Borislav Petkov <bp@alien8.de>,
        Arjan van de Ven <arjan@linux.intel.com>,
        Ashok Raj <ashok.raj@intel.com>
Subject: Re: [patch 28/30] x86/microcode: Handle "offline" CPUs correctly
Message-ID: <ZNVNibrpZ9bJLok7@araj-mobl.amr.corp.intel.com>
References: <20230810153317.850017756@linutronix.de>
 <20230810160806.562016788@linutronix.de>
 <20230810204605.GF212435@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230810204605.GF212435@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BzD6WPNBgpKIl+DcgNt3p57dURHt3vBu8ytWidfI+o6uTuHNwOQvQVjeHhYa?=
 =?us-ascii?Q?keu7s6Fb/hfwvx9y9U8QzcEe07UBq1d7DNMowhZZg7fCPg/G1p5x47YIXPk/?=
 =?us-ascii?Q?pFLEavA06PLHGHYbvPyfQz+17luPpdZ/BhE0UhsNPNgv+y7T7iuULN3O2AS4?=
 =?us-ascii?Q?hr+lvqw9w5FrQ6e09ZccVMNb/PNuJoJwkAquHhfQkKKchO5XVbFUdEupoo2z?=
 =?us-ascii?Q?qAfLS/zUYjbip/uSsnsLGUisfEl+oQM29wjlnKIy0glki6qC+J/yEAHF1EXY?=
 =?us-ascii?Q?YnoSB0vKYyzAkAd+VE4p/Dl7vCXwuzjq3KhOg5bfkGG8+VBMCHqvCKNxBvfp?=
 =?us-ascii?Q?seKbbvMmRL3cp903fmn1/CyC/7+Z6uNOZuTohNWcJIGVklhgdsFbZz1ihAUv?=
 =?us-ascii?Q?V42hZuji/k0W07d802V3GM/1wfp8zDWByuY9ujIrbpGHrmcdIY/YPHzEjNtN?=
 =?us-ascii?Q?Jrg8uSnlt2YVotDndoFdfua2ydAGWmcJ/YL6alELfY4mF03piF2ydxqEGTjk?=
 =?us-ascii?Q?tvNC3bCmgqXBQwIV8lpDE2C7mOVYTwCfspdyS1BsM4Z0ib0lAN9pjRH8KSRC?=
 =?us-ascii?Q?Q2xBh0x21ZAGYgYEYfFeQMRfaQ8Aj5op+rE76XJeAe1nlkYDxmSc+mt2aj5B?=
 =?us-ascii?Q?iCUCpxcV+voG1P2j4wwaO/7qsTlkBjUJoit+3V48vUkmiaQ/DbuSe3c2+KV7?=
 =?us-ascii?Q?Uo4ryoxITnI3LP6puwyUWvMI4g0sSwV7t/DxM+XW71rzRAZ+H9aYmC0YsO5h?=
 =?us-ascii?Q?Bl8W6YCOwtLb+Pq8lDcPH0MaYF726hkFDPvvhPrSCk/APAtOw2awxHy8cxfP?=
 =?us-ascii?Q?0ehPhPO2DCEBgDf9pE642gWZRT1uWlr4lF9fW/NFXG6sde9mrgv3hYM/V7R3?=
 =?us-ascii?Q?G7VpolGsev6uAxw2uruKT20hB5tXyrUn6FV9rUerHthOLTrcEcZLHTEntO8n?=
 =?us-ascii?Q?iNs1dA163ZH3LUhK7vwo+oYwgYAdRsUxPvE7IBdtg50R/Szlp8CMRfXlPqKP?=
 =?us-ascii?Q?gs3ulpHXkJ9VbIlQPfuIYLcFm/l9X3DWbNJd51P6qzsIOqH13ZBjxO2jXqvu?=
 =?us-ascii?Q?GGYnyn7NcbUfOBOjDv7z8S+gu8b1vdlNu3sALbjKcxMneIwU/Z/Ea+JVxNqt?=
 =?us-ascii?Q?batHXP3YazEXmI4PhJdCqEYgF5WQC2sCh5MYH6WJ9tix6jaXdMWUJAiJBHpU?=
 =?us-ascii?Q?cRGLzmqvS2yCBRNJI8+dyyNnnxebldmLpk5dXB60OhjqzdSt3whIiFAlz/bR?=
 =?us-ascii?Q?ojEb6ZPy2i2xd7PdBIh78MZdiHA8eYud9QHzAuDAIL+mEs6XwT2go0WOT6XT?=
 =?us-ascii?Q?L0SzM3UsT85ebTZukzHCHDDpoDRfYGXPEj0qKdAO0ohtbnFmScQ2wSsFKhl7?=
 =?us-ascii?Q?kBRn1DHGKn1UqvH7O/JVk1+LfPFldBt5Q7Z7ROY7m/Q7wYLR28e0Sjv6qMqy?=
 =?us-ascii?Q?ezPxrkeWwGTvq6N6EbR9ehD80cIIfAu6jkTIdTwNvqKKEaiCgWLIxopco2lS?=
 =?us-ascii?Q?ppay6W1QklAizkPb82xmBb0sWTAw2fpnxAo30dX9o06XWj2hO9UDL4789QZY?=
 =?us-ascii?Q?b1HUFRfE0EBe/FbBTeQxgwTHBuM+cWNFHAcF3J3S?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 472d39a6-7715-48af-08e4-08db99e3690d
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6201.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 20:50:20.3341
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MN3+Vo6lh5c6Z28b7k2j7e2dWMY6rwV6+KB5EztI6nd2q64v0gTSBV6evUTjJjOixEHXSi1qLHtXXNpf3o7tcA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB8097
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Aug 10, 2023 at 10:46:05PM +0200, Peter Zijlstra wrote:
> On Thu, Aug 10, 2023 at 08:38:07PM +0200, Thomas Gleixner wrote:
> 
> >  	for_each_cpu_and(cpu, cpu_present_mask, &cpus_booted_once_mask) {
> > +		/*
> > +		 * Offline CPUs sit in one of the play_dead() functions
> > +		 * with interrupts disabled, but they still react on NMIs
> > +		 * and execute arbitrary code. Also MWAIT being updated
> > +		 * while the offline CPU sits there is not necessarily safe
> > +		 * on all CPU variants.
> > +		 *
> > +		 * Mark them in the offline_cpus mask which will be handled
> > +		 * by CPU0 later in the update process.
> > +		 *
> > +		 * Ensure that the primary thread is online so that it is
> > +		 * guaranteed that all cores are updated.
> > +		 */
> >  		if (!cpu_online(cpu)) {
> > +			if (topology_is_primary_thread(cpu) || !allow_smt_offline) {
> > +				pr_err("CPU %u not online, loading aborted\n", cpu);
> 
> We could make the NMI handler do the ucode load, no? Also, you just need
> any thread online, don't particularly care about primary thread or not
> afaict.

Patch 25 does that load in NMI. You are right, we just need "a" CPU in each
core online. 
> 
> >  				return false;
> >  			}
> > +			cpumask_set_cpu(cpu, &cpu_offline_mask);
> > +			per_cpu(ucode_ctrl, cpu) = ctrl;
> > +			continue;
> >  		}