Received: by 2002:a05:7412:6592:b0:d7:7d3a:4fe2 with SMTP id m18csp669602rdg; Thu, 10 Aug 2023 15:57:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHLIYD4ZEt5y7tNVZeKfkhTm5Ogi+pHlUxHz2KkD8zWCzWVLXDd1KxesIHZ7fS0lx9qasI9 X-Received: by 2002:a17:907:1de9:b0:99b:55e3:bbd with SMTP id og41-20020a1709071de900b0099b55e30bbdmr218374ejc.34.1691708241399; Thu, 10 Aug 2023 15:57:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691708241; cv=none; d=google.com; s=arc-20160816; b=h+PRezFX0ZwqSHpNz+TdGiGVKwK5M1pbA91KjNZefD7BxEmGreQi1isecev0rdIBCH A72K0ckqSfzTiFuNJrMrp3KGVuY5mKnfe/mZuZpRway1NLdUQZGgWUoHGR7UOUaKkG0t e+cgH+XUXlSjbcBC9UHdbgOrOlNNEaGjz/KSnWZ52vpqlbi+WhVm3X1ddwxQZ+5P5/wN C6eBCuV2iAqtE2gsmqERnDZzAxvHGf+LnMUKVIAZq6nEOJ+C4jF8P6Cb2PEdTbvyNH6n gCo2jUzhwgsaBEehpJ+TxKjJFimLdbp804UwvGn15RyJ2Vc4jSQJN2X3EdD8V4dk3SL4 NznQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=yetdEohBxdSXG8oQ+EWSj71lcBF11oBupgPVk6hbrgg=; fh=D9eUsgpb5hu7jc7cZRLTi8uWTnbPVfl47u4AbJiILZA=; b=nmYmoYMg2XHYx+02I/IaK+PNA8g7ULHbmP3X7GUXdOU0wiIzkSrvZXU1rJ7bxgdB9D M93pi+x6uqCR/kdHNB0B5og3uppg7O47axIpWY4EGmjVqgKXYkvQksUNejyRleDAOk2H IFw2/D8PVZ9BkbCHA0o2na8Ju8CQDXEHpuIWiUR3C4ShxSPlmsVeNBI+N3k4FFV+tlw3 saYgLxn0+4YBjo5jysm+qgsOF0DVjF0EyoMlBLslcP18D0TuHwFIur0/JZ6Fcno2TN5U zVcdlk2+vYqxO7AIhRu6EKOqMeurmDXBWdKqeNU/DKqE0zRtLrzOPl4lqF36ta9LrrQV 6hXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YmW+gMTn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jo25-20020a170906f6d900b0099bc106611esi2382800ejb.824.2023.08.10.15.56.56; Thu, 10 Aug 2023 15:57:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YmW+gMTn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231430AbjHJWA6 (ORCPT + 99 others); Thu, 10 Aug 2023 18:00:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229907AbjHJWA5 (ORCPT ); Thu, 10 Aug 2023 18:00:57 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8BA62123 for ; Thu, 10 Aug 2023 15:00:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6C89960A5C for ; Thu, 10 Aug 2023 22:00:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73C7DC433C8; Thu, 10 Aug 2023 22:00:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691704855; bh=s5QIG+X19estRlbIsKWn9bmkPv61euAyFKFlJLfA9uA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YmW+gMTn+RNUvBFT+Vxz6ayGWIm7w8UdC/fGyXCmtPb2ORtcqxu3CVWLSib/XFoiT +b79K5P5RkyvSfakLAbmiDgwqPs5bjBVCn90e2Lg4hSJlmqDIZh2Hm0FMwGoUvOoJs 2m1nw2CJqyULtvqdgft3Fmj5v+QHCnov9Y+dWcP/awKQj4/jPkdPum2FmysCV2Hytd XPLKEc/z/48d3fYkc9XXV70vdjOA2kb69sFq3UaeKfsG0RjF6YA23BMjm2Z0TAinza i68lPdEiioUMvSAjNNUPgWbcSr0GpeR86tviPqfqdRRSE5mL/+cMrtKvBLSpApbumS r4hkpAc+TSLpg== Date: Thu, 10 Aug 2023 15:00:54 -0700 From: Jakub Kicinski To: "Michael S. Tsirkin" Cc: Maxime Coquelin , xieyongji@bytedance.com, jasowang@redhat.com, david.marchand@redhat.com, lulu@redhat.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, xuanzhuo@linux.alibaba.com, eperezma@redhat.com Subject: Re: [PATCH v3 0/3] vduse: add support for networking devices Message-ID: <20230810150054.7baf34b7@kernel.org> In-Reply-To: <20230810174021-mutt-send-email-mst@kernel.org> References: <20230705100430.61927-1-maxime.coquelin@redhat.com> <20230810150347-mutt-send-email-mst@kernel.org> <20230810142949.074c9430@kernel.org> <20230810174021-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 10 Aug 2023 17:42:11 -0400 Michael S. Tsirkin wrote: > > Directly into the stack? I thought VDUSE is vDPA in user space, > > meaning to get to the kernel the packet has to first go thru > > a virtio-net instance. > > yes. is that a sufficient filter in your opinion? Yes, the ability to create the device feels stronger than CAP_NET_RAW, and a bit tangential to CAP_NET_ADMIN. But I don't have much practical experience with virt so no strong opinion, perhaps it does make sense for someone's deployment? Dunno..