Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Aug 2023 15:38:50 -0700 (PDT)
From:   Ilkka Koskinen <ilkka@os.amperecomputing.com>
To:     John Garry <john.g.garry@oracle.com>
cc:     Ilkka Koskinen <ilkka@os.amperecomputing.com>,
        Ian Rogers <irogers@google.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Will Deacon <will@kernel.org>,
        James Clark <james.clark@arm.com>,
        Mike Leach <mike.leach@linaro.org>,
        Leo Yan <leo.yan@linaro.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-perf-users@vger.kernel.org,
        Dave Kleikamp <dave.kleikamp@oracle.com>
Subject: Re: [PATCH 2/4] perf vendor events arm64: AmpereOne: Mark affected
 STALL_* events impacted by errata
In-Reply-To: <d3da2a30-9e9-73c3-b1aa-aca508bd259@os.amperecomputing.com>
Message-ID: <265ae2c0-d355-f282-4463-4a677d9969cd@os.amperecomputing.com>
References: <20230803211331.140553-1-ilkka@os.amperecomputing.com> <20230803211331.140553-3-ilkka@os.amperecomputing.com> <b690cae6-ee9c-2c6b-a19e-60088cb8cb19@oracle.com> <d3da2a30-9e9-73c3-b1aa-aca508bd259@os.amperecomputing.com>
Content-Type: text/plain; charset=US-ASCII; format=flowed
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?oeWjxPX08foZe0uPWVmjkD1iCFyEYIK2le6qkryFEnlp8AlEbtvh/X4qHfhc?=
 =?us-ascii?Q?wp3jTio7FGR5mN7BjKxeWpUo+Ta5ZuPGiN9Twx0IlUf8bVd3axCde8KMsWM/?=
 =?us-ascii?Q?sqUvktj1ZnLv81YNTwyJzWzsol3BRmzL3yMgdGwbHR7p75VM8n9LkaZgLgUg?=
 =?us-ascii?Q?V7PQ8hl7PI6jtUPREQny6y37Nqx1NGnPjm6qSQcf53Q2ovQwbMUIn2Q83ZUC?=
 =?us-ascii?Q?kt4V+xwbWK9BTKWapkCkI0D+3H2u0lyWFvPmmNmpFSnAcvfe1eR8gzcGQ1AS?=
 =?us-ascii?Q?6Zd7nEvTOvLOAoPDKgdk2DnIxfry/P6pmRg6rw+Z6Q7fSki3dD5lsFobInd/?=
 =?us-ascii?Q?10/Sqj0CLad/c4m3bh/lT6DBlFPQgUwY4H8hkjLSCP5vDvs3EI6M6YCJfvkH?=
 =?us-ascii?Q?ZoSdLhl9HKQU24YD69LKcoSOZhACgKExFtmRaJpSTeIGQ2U6kZbzNda+0EVC?=
 =?us-ascii?Q?yUIISEZhR3LkrOrAmpEYfyzPjsLYCYepOmKSApK373UdBVXf+Eu4dfIqfanD?=
 =?us-ascii?Q?nTST2v9IQOdhOS/h07FdD2UH0KsQO4rnVA7GKKuun3K/Wv6NOdCEjyaUZ44Z?=
 =?us-ascii?Q?uBZAKVbRrInHNilcGlReoKTtpKBw+xxTZrLggP+wCxOt/g1d1gxvE4NRs0Ju?=
 =?us-ascii?Q?hMo2k6UBCWg17iXNUCK3zGQCvCqCNWmM5LAKJJe/dzCKe54/zAu+UWxs0S6K?=
 =?us-ascii?Q?QBrfiLSuFA8+STPIGS8M7ua6fVwD62jlXUbt7HVCIeGJgqmfiKsZYhbr3dHd?=
 =?us-ascii?Q?jneex4eWrXRxwr71Oh0nH5CInBtOnGEAsVRhFDdnlnZTsdjQH8646+jSahts?=
 =?us-ascii?Q?O1sWW5KQmPUrfG4efzYrl9aCYcE7PEgcvOiNpvQ8LyurlvfyToZ/F0nZTCCt?=
 =?us-ascii?Q?CLdGFlqSV0r5ZgmbccS7V/O4WTOvdj/FjeTtj347HgyfjIHFGxzgZV50ZSsJ?=
 =?us-ascii?Q?ANbPlvuQYIs8oXRMQWbl3timgxcWOkHkDH3VF0V7fyviFUHbdvN4ZcNINZ9y?=
 =?us-ascii?Q?u4Bk8Vu/wVWtiQQb6aTfs18niSD3FMAhMODoiESgHIQ8AjAoKGrZCXv8bzGA?=
 =?us-ascii?Q?2sD8Jav5ltfEBTnZH+0STD6bjTdl8pFdRFwzRAUUxTnNZSjHSK//rwYJVgYA?=
 =?us-ascii?Q?OKJOSj3+q2nRVYyGifrhpMWJJt+UlEVqoFJ6syNYXh6Aoh/uES30DpQTG/xN?=
 =?us-ascii?Q?D+g1M9f6+3p8SHEmhT0ZXC58cmr75KRniBTBt9uQyzuJ15uViIKPg7ZT8Y8x?=
 =?us-ascii?Q?PD1Zt7dOA1GlFhZV8KAnu+9dAfO0I6zoqEx6FCSAOm0teGBxSGCZo09efaR7?=
 =?us-ascii?Q?qK9fnb880GNYOVNPkFI2/oxMPTtX5xstr9zfbjLdDK9xQUlt8oez3Qffiwjk?=
 =?us-ascii?Q?El18LYZlv2xvtEr22savVkJYKoO6ybhURrFuaiV+i61rdhni+qNIfWijAb1H?=
 =?us-ascii?Q?I/VYg9188ZUlJXo6BUiC3vEmceMISIbOzoTpe+y83GGwIuFoWX8Vhl0pxn5d?=
 =?us-ascii?Q?6Td6MrbtdNcGS6BXESDGsCZMsGmdUT538RSZSR17gR4fmcbh4/Po426B5eGg?=
 =?us-ascii?Q?1cmvgLyJrohbCMrRP6pYu6Z9TBYIvR6nZ+mRgVF+DRK6ubTIhhiwy6lIC76I?=
 =?us-ascii?Q?Evm7+K2bIoLfh6x68gUyjHg=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 557bcfa6-e9ad-4fad-d937-08db99f29ac9
X-MS-Exchange-CrossTenant-AuthSource: DM5PR0102MB3590.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 22:39:06.4442
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QG/jpqdDjvY9iAA6geBIvClweymTQmBeO0rGjFztzU4g29E9bOaxU8HBx5urNLOFia8OFl1b3SKt7iJRe5NQwXKQ/achHSHlfZ2zlxPkConauzCmXUJBieJZ/of0Cf1V
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR01MB7878
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On Fri, 4 Aug 2023, Ilkka Koskinen wrote:
> On Fri, 4 Aug 2023, John Garry wrote:
>
>> On 03/08/2023 22:13, Ilkka Koskinen wrote:
>>> Per errata AC03_CPU_29, STALL_SLOT_FRONTEND, STALL_FRONTEND, and STALL
>>> events are not counting as expected. The follow up metrics patch will
>>> include correct way to calculate the impacted events.
>>> 
>>> Signed-off-by: Ilkka Koskinen <ilkka@os.amperecomputing.com>
>> 
>> Reviewed-by: John Garry <john.g.garry@oracle.com>
>> 
>>> ---
>>>   .../arch/arm64/ampere/ampereone/pipeline.json        | 12 +++++++++---
>>>   1 file changed, 9 insertions(+), 3 deletions(-)
>>> 
>>> diff --git 
>>> a/tools/perf/pmu-events/arch/arm64/ampere/ampereone/pipeline.json 
>>> b/tools/perf/pmu-events/arch/arm64/ampere/ampereone/pipeline.json
>>> index f9fae15f7555..711028377f3e 100644
>>> --- a/tools/perf/pmu-events/arch/arm64/ampere/ampereone/pipeline.json
>>> +++ b/tools/perf/pmu-events/arch/arm64/ampere/ampereone/pipeline.json
>>> @@ -1,18 +1,24 @@
>>>   [
>>>       {
>>> -        "ArchStdEvent": "STALL_FRONTEND"
>>> +        "ArchStdEvent": "STALL_FRONTEND",
>>> +        "Errata": "Errata AC03_CPU_29",
>>> +        "BriefDescription": "Impacted by errata, use metrics instead -"
>> 
>> why end with a '-'?
>
> That's a great question! I wish, I remembered why I did that. Looking at 
> other events with Errata field, they use '.'. I can fix those and submit the 
> patchset again.

John, I took a look at it and it seems that if I use '.', perf will remove 
it. Here are two examples:

metrics.json:
"BriefDescription": "Impacted by errata, use metrics instead."

# perf list
[Impacted by errata, use metrics instead Spec update: Errata AC03_CPU_29]

vs.

"BriefDescription": "Impacted by errata, use metrics instead -"

# perf list

Impacted by errata, use metrics instead - Spec update: Errata AC03_CPU_29

---

So, I believe, I probably used the hyphen to make the 'perf list' output a 
little "prettier". Well, I just change to dot and it's fine.

Cheers, Ilkka


>>
>>>       },
>>>       {
>>>           "ArchStdEvent": "STALL_BACKEND"
>>>       },
>>>       {
>>> -        "ArchStdEvent": "STALL"
>>> +        "ArchStdEvent": "STALL",
>>> +        "Errata": "Errata AC03_CPU_29",
>>> +        "BriefDescription": "Impacted by errata, use metrics instead -"
>>>       },
>>>       {
>>>           "ArchStdEvent": "STALL_SLOT_BACKEND"
>>>       },
>>>       {
>>> -        "ArchStdEvent": "STALL_SLOT_FRONTEND"
>>> +        "ArchStdEvent": "STALL_SLOT_FRONTEND",
>>> +        "Errata": "Errata AC03_CPU_29",
>>> +        "BriefDescription": "Impacted by errata, use metrics instead -"
>>>       },
>>>       {
>>>           "ArchStdEvent": "STALL_SLOT"
>> 
>> 
>