Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <26949c92-95a0-414f-918a-8b8cc11e3e9c@intel.com>
Date:   Fri, 11 Aug 2023 07:09:33 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] zswap: don't warn if none swapcache folio is passed to
 zswap_load
To:     Yu Zhao <yuzhao@google.com>
CC:     <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
        <akpm@linux-foundation.org>, <willy@infradead.org>,
        <hannes@cmpxchg.org>
References: <20230810095652.3905184-1-fengwei.yin@intel.com>
 <CAOUHufYb2LiZYqhyk7GZ2roUbHUEUf3iKkvmSThHBS21EewHiw@mail.gmail.com>
Content-Language: en-US
From:   "Yin, Fengwei" <fengwei.yin@intel.com>
In-Reply-To: <CAOUHufYb2LiZYqhyk7GZ2roUbHUEUf3iKkvmSThHBS21EewHiw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TGhlaVJOdXQvd2gzcHVxZndzVE10YTlnSDV6K2pEQ3BPUTVFQ25ZaTlYeDBF?=
 =?utf-8?B?Z0NQdU9XbVgxZWdEN0JRN3VPZXJ0c0pRUG84VHQ0Z0RtU2ZqbUovbFIzS0pw?=
 =?utf-8?B?Y1BqS1l4UFdhc0R5ckhpQ3cwaGpITjlQbXUvV2dBUCttT00xb2JrMmdlOEVy?=
 =?utf-8?B?Skk1MTdoazZZakp2UVFzbnljcnZvdlF4Ly81OU55ckV0ajFkOXM3cnZhTk5P?=
 =?utf-8?B?RzVWczRBbXB0SlNMdjlHYnM0bWp1bTlWQUhHaVZZSm5iZ1lKTndJOEtsRG45?=
 =?utf-8?B?aTkzWllnbmpJUGk2Qi9tRTU0NExUUDVFakkwaU5sTU9IY2xyRmxoRW9pOEZa?=
 =?utf-8?B?dENnVFhUWVMyQ0xJM3VUNDIwK3VOdlNOWDVsaHhDbnJwK2pvazVVRUd0N09C?=
 =?utf-8?B?SFRkRWhFWUFwZG1TbER0N1VEalFKYjFtTnU3b2tnVVpwM1RvUmFMeWswTjl5?=
 =?utf-8?B?Y01nNlNYMnRBV2ROMVlJWUE2ekpaZmR6eFloR0NoOGRVQ1ljUm5aYmpENmh4?=
 =?utf-8?B?QUFYcHk0aG9QSVhYbTRjNkRwbkYwRDVjRXdERVhWRXUvVXprWFRvTWE2SWFr?=
 =?utf-8?B?TmNiOEhKSlVMcHIvaTNMeURleUdkc0Q0bmV6YmZjdms2cnJSMWlwT3FBcDQy?=
 =?utf-8?B?MjBQbkxMS1Z1V0xqRHF6UEJBYUlDR2tBYkZNVG5Zd2hqMG9aRmZ2NmZoNG94?=
 =?utf-8?B?d2hlS3FCL2ROcmk3M1NKdmV0M2NEemhaTnlQMCtlM0trclR3WFI0UlR5T0xs?=
 =?utf-8?B?Uk5LQ3hINnNXLzBTb1J4NjQ0b2hiYzRCVm04ZERkRG9HWkd4NVJHZGtmU2h4?=
 =?utf-8?B?U05VRFNZQ0JNNnRLSXNNMlFlbWZiQXhhSTUrZ2s1Y1U4Uy9CTHFEelo1Z1p4?=
 =?utf-8?B?SHJqKzQvZXNETjhkSlo3K3hKTEZFSDRSY1BrZWVKRjV2czhtcm1rNGJhOWFT?=
 =?utf-8?B?cGRQL0pnSlkxZ09GRUl4NW1EcngxUUNlMm8rYjBPMjhnZWRDUEVYZHM1L0NB?=
 =?utf-8?B?dk5SeS9SRGc3NXZPa2lhMkRFZ3ZIN2NGdm01b0VQOXQzbUQ4NEJWcHMzN0tx?=
 =?utf-8?B?bjFYRitmNTNFa0ZqVkI3bi8zcjQ1U0pUODljbHpVYW1LRTNoYXVuOVM2Rm1x?=
 =?utf-8?B?NUFITUVqeTVOVEZhajIyUWV0Qm1YZ2NZMkxoanJzVXRFcHFFNXNacjl6ZTdB?=
 =?utf-8?B?eTZvVDhSYThXdjR4OWd1NUMyM1VKUnhCbTZpeFZuNnpaakFpMDhTR3pvdXQr?=
 =?utf-8?B?VERLbHdjWnE1dFF5b3FsQmpPczYvUS95N09KV0xNQ004Q1hJV1F6Q05sazV5?=
 =?utf-8?B?UnRiRmRzODZTa01abFltOHQxK0I4bHo0UWJBTWF6MEpBNWFiZzVZUFAzR3Nw?=
 =?utf-8?B?YU1QQ2E0eWhIdTJzK0F3SWJiMlhFcjJDbnRPanlZQzdHUDNLb0NSMFJ2YWhs?=
 =?utf-8?B?cUMvNzk4YnZtMWMza0NFaXNSR0RVaWpLMkNBVGwxTTZPd3JuVFRZQzM1OFh3?=
 =?utf-8?B?a1B4aU1lNlZBQng5V0F2c3lZK1lhSTBEcFdpbjVmdGg0ZnEvUXduRDU4RlZo?=
 =?utf-8?B?WFVzWEpWVnJ6dktncWl1MnZsWUFOSS9TclUwN3pZUVVJMCswQ2poRkZpU2Fl?=
 =?utf-8?B?Y0M1d2pwK2JyeGJTTTdZNHZOQ3V0WGU3bGVJL0FoTjgwcFNUSGpKUWtrdzdF?=
 =?utf-8?B?TWFGZndxc2dseFVOa0xydTFreXFoUlJvcVVnSndLaFkyMlhKYzl5OExXbkFK?=
 =?utf-8?B?b1VETHZpWEtXc25RN3dENWtTNW11dHRKa1VrU00zbUtRWFN0Yk90YjVUNWQ1?=
 =?utf-8?B?UFpEbVZ4VDIwZTU1YkxTR0VNcXI1WlRnUFdnL3ovN3pydkU0OFlqcVoweHYz?=
 =?utf-8?B?Y1JWSWV5czA2SUJnbFlJNytxN1FDWUxmSEkwVFNtVGk0RGU0MDFlLzZsL3p1?=
 =?utf-8?B?QWg2VXpRT0M4OEllZUpqbHVLc3UyOE9oekNGRmFoT1dQRkpGUW41ckErd0J1?=
 =?utf-8?B?WlhWQkFvUDZxazNEczg3dnYxMmthTVQzWVFyZ0g1bTJGTUpoZTZHSGdtY3l1?=
 =?utf-8?B?b2NKL1BhVEhPTXhSUXp5bmx3ZHJ4cU1TbkZTc0ttb1NuY1dUa1BldmQxSUts?=
 =?utf-8?B?SHQxUkFHTWV3ZDM2TXFkc1R6Rzh3d1VFWkFQWW1iLzJJTzM1K25teWtiSG1w?=
 =?utf-8?B?S2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3dc4a14a-6424-4eed-2fb1-08db99f6e027
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 23:09:40.8019
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: I1jlxSvUWVj+bzUozT/PMm/D7/b/UIuqU18bBZDOqfT0Qp6fVIJh/2sJv89JkpS2FYc75GN9Ma+ePAxVsG1+7w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7244
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 8/11/2023 2:44 AM, Yu Zhao wrote:
> On Thu, Aug 10, 2023 at 3:58 AM Yin Fengwei <fengwei.yin@intel.com> wrote:
>>
>> With mm-unstable branch, if trigger swap activity and it's possible
>> see following warning:
>> [  178.093511][  T651] WARNING: CPU: 2 PID: 651 at mm/zswap.c:1387 zswap_load+0x67/0x570
>> [  178.095155][  T651] Modules linked in:
>> [  178.096103][  T651] CPU: 2 PID: 651 Comm: gmain Not tainted 6.5.0-rc4-00492-gad3232df3e41 #148
>> [  178.098372][  T651] Hardware name: QEMU Standard PC (i440FX + PIIX,1996), BIOS 1.14.0-2 04/01/2014
>> [  178.101114][  T651] RIP: 0010:zswap_load+0x67/0x570
>> [  178.102359][  T651] Code: a0 78 4b 85 e8 ea db ff ff 48 8b 00 a8 01 0f 84 84 04 00 00 48 89 df e8 d7 db ff ff 48 8b 00 a9 00 00 08 00 0f 85 c4
>> [  178.106376][  T651] RSP: 0018:ffffc900011b3760 EFLAGS: 00010246
>> [  178.107675][  T651] RAX: 0017ffffc0080001 RBX: ffffea0004a991c0 RCX:ffffc900011b37dc
>> [  178.109242][  T651] RDX: 0000000000000000 RSI: 0000000000000001 RDI:ffffea0004a991c0
>> [  178.110916][  T651] RBP: ffffea0004a991c0 R08: 0000000000000243 R09:00000000c9a1aafc
>> [  178.112377][  T651] R10: 00000000c9657db3 R11: 000000003c9657db R12:0000000000014b9c
>> [  178.113698][  T651] R13: ffff88813501e710 R14: ffff88810d591000 R15:0000000000000000
>> [  178.115008][  T651] FS:  00007fb21a9ff700(0000) GS:ffff88813bc80000(0000) knlGS:0000000000000000
>> [  178.116423][  T651] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
>> [  178.117421][  T651] CR2: 00005632cbfc81f6 CR3: 0000000131450002 CR4:0000000000370ee0
>> [  178.118683][  T651] DR0: 0000000000000000 DR1: 0000000000000000 DR2:0000000000000000
>> [  178.119894][  T651] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7:0000000000000400
>> [  178.121087][  T651] Call Trace:
>> [  178.121654][  T651]  <TASK>
>> [  178.122109][  T651]  ? zswap_load+0x67/0x570
>> [  178.122658][  T651]  ? __warn+0x81/0x170
>> [  178.123119][  T651]  ? zswap_load+0x67/0x570
>> [  178.123608][  T651]  ? report_bug+0x167/0x190
>> [  178.124150][  T651]  ? handle_bug+0x3c/0x70
>> [  178.124615][  T651]  ? exc_invalid_op+0x13/0x60
>> [  178.125192][  T651]  ? asm_exc_invalid_op+0x16/0x20
>> [  178.125753][  T651]  ? zswap_load+0x67/0x570
>> [  178.126231][  T651]  ? lock_acquire+0xbb/0x290
>> [  178.126745][  T651]  ? folio_add_lru+0x40/0x1c0
>> [  178.127261][  T651]  ? find_held_lock+0x2b/0x80
>> [  178.127776][  T651]  swap_readpage+0xc7/0x5c0
>> [  178.128273][  T651]  do_swap_page+0x86d/0xf50
>> [  178.128770][  T651]  ? __pte_offset_map+0x3e/0x290
>> [  178.129321][  T651]  ? __pte_offset_map+0x1c4/0x290
>> [  178.129883][  T651]  __handle_mm_fault+0x6ad/0xca0
>> [  178.130419][  T651]  handle_mm_fault+0x18b/0x410
>> [  178.130992][  T651]  do_user_addr_fault+0x1f1/0x820
>> [  178.132076][  T651]  exc_page_fault+0x63/0x1a0
>> [  178.132599][  T651]  asm_exc_page_fault+0x22/0x30
>>
>> It's possible that swap_readpage() is called with none swapcache folio
>> in do_swap_page() and trigger this warning. So we shouldn't assume
>> zswap_load() always takes swapcache folio.
> 
> Did you use a bdev with QUEUE_FLAG_SYNCHRONOUS? Otherwise it sounds
> like a bug to me.
I hit this warning with zram which has QUEUE_FLAG_SYNCHRONOUS set. Thanks.


Regards
Yin, Fengwei