Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <41e8dee7-e5f8-4c6e-24e9-4e33cf53fb38@intel.com>
Date:   Fri, 11 Aug 2023 09:06:06 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
Subject: Re: [PATCH 0/5] Share sva domains with all devices bound to a mm
To:     Baolu Lu <baolu.lu@linux.intel.com>,
        "Tian, Kevin" <kevin.tian@intel.com>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        Michael Shavit <mshavit@google.com>
CC:     "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20230808074944.7825-1-tina.zhang@intel.com>
 <184044ad-880f-5452-727b-f7fd18330c22@linux.intel.com>
 <BN9PR11MB52766D5CF4F959D58E60C9238C12A@BN9PR11MB5276.namprd11.prod.outlook.com>
 <86ecc67a-8567-f3b3-02c9-572474af8e72@linux.intel.com>
Content-Language: en-US
From:   Tina Zhang <tina.zhang@intel.com>
In-Reply-To: <86ecc67a-8567-f3b3-02c9-572474af8e72@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dTBWOTQ4eG51N3RRdHAyOUUzRnVoMzNLeHNJVUNkdzR6QjNHTTlxOHlySE42?=
 =?utf-8?B?eFV0WkNYN1k3RDdncVp3aHRGcG9DTHhnMjN3MXJOOFRkeGFBalRBSnRVSFlF?=
 =?utf-8?B?dkV2S284WUIvT28yNGh6OEFWaVNSYjdOZi9lRy9wMWVkOFo5OHpxS1cxK29J?=
 =?utf-8?B?T0ZseXVvcG5aNWJQNE81aXpEaDdVbklUZlZpa3E4UjRGWWxOQkRsYks5WDRG?=
 =?utf-8?B?azdPZ2RIZDVqMDRwNEFQMElURE5LZWN3aUFNeTgxOHpMYXIrR205UTFZZThB?=
 =?utf-8?B?Mm9TamRtaXltRUZrVW5Sbng4ZWNLVVlJUkdVRnNoYTM2Q1VucmUxSEF0QTBO?=
 =?utf-8?B?Tnh2ZnBMWTk1azM3RVRLcCt4WU51MnphbHNrUXYwS0xNRlN6dGptTTZqWVNT?=
 =?utf-8?B?ZGZOeGhUcWkyRU5USTZmSmRwcThGSEFSTCtXQUoybE9wUEJzQjNSVUZWMXR5?=
 =?utf-8?B?U213bEZJNitrWGM4ZGpiT3BFLzEyY0NKalNVN1ByZHg3TXVhWmJvZVpZMVpF?=
 =?utf-8?B?VGRTM0JOak1xb0s5NzRlS0FDakVNR1NHd0lWTi90QnJWTWpsM2tmc1QwMkEw?=
 =?utf-8?B?dWhnY0ZudUI2R0oyb2E5WGhZNmh5OFEyTnFnaHlxT0owVFp2amZ1bzcwSllX?=
 =?utf-8?B?ckNtVFdYVjFUSmVPK1JUS1ArMDNLeUNmU3RlWUREdWJ4WWFXZllWWGczbmJU?=
 =?utf-8?B?K2RHZ043UkRMeWR6VlFhaS9jamUzYUpNQ1RPcklYSVNiRVRxT1ByYzY2cVFn?=
 =?utf-8?B?UmxkWmpLM1k2VHVzQzlJdzdLd25BL0tPSVJ1NWdyZ1VTY201RGNHYkxiY2NG?=
 =?utf-8?B?NXVwdUEveTZmeFl5ZHcxaWhibERVWmdUTy9IaE52SDNZalIzdTY4NFZIUk1N?=
 =?utf-8?B?TUVSRklCT2ZnSCtwWmxjbVAxRVRvcDExQW81Y05QMEFZdW14R2sxdFBnSDNX?=
 =?utf-8?B?aVlTOHk4UzBTSDB2MkNPVUkvSGMrV1lHZW1qZ0QyNG9HZTJtU084aGZvd1pS?=
 =?utf-8?B?d25KYVZESUlTT242L1ZDTXo1YVVWdmx2TEkxYm1VMks1V2VXTGRFNzZIN2h0?=
 =?utf-8?B?TVhGeTBVRW5jWGJaWmxLaDJmLzg3d1dsblMxRVJ3ek9GMUFRYTBrdTlObWxX?=
 =?utf-8?B?b2cvQVFmWE12MTB4blBZeU5CWUNHblpXa05VTERpWEJLTnJ1cmtraXZPZElC?=
 =?utf-8?B?UloyVkJHdzhHbEppRDRtNnl6TW5KVExkeXVyeFJ3NExaWHFkNmtUaVYrMHdB?=
 =?utf-8?B?bzNpc0I1K3dsUzlua1FvWXFMNXpBVlZGTm01Nmd6MDR5dkt5NkVTcWd0WkhW?=
 =?utf-8?B?WXB0bWI0VXBPTjZ1TklZdXVxdVEzcVB0MXFQQ0RISTQ5N0g4QkNwM1FnMFBw?=
 =?utf-8?B?TWcrU1l2TzljNnR2QVpEcm9sMlhTT0hmNHU4Tm1NUm1sVk9LQlpaS0tWTkxa?=
 =?utf-8?B?RFFzMlY4aVB4TnZQVWpqbkZHcUx2OXhQVnF3ejBTMnZLaGVXcFNFTWJrTHdm?=
 =?utf-8?B?NlNkYjNySXU0ZWRXQlZWcno3b2ViUVoxT3dvVVNaQ0UxNWRwUlVkK3hSZ1Zo?=
 =?utf-8?B?Y2M5eHBZUDFLOUg5QzMvQVJ6MG9UQldQVVRZMy9sRjZobUtvcUJiR21maDB4?=
 =?utf-8?B?VW9ieEtlRFlaUllENDBXdmo2QzZpTlJlNHlYM1VGWnM0Z0FRbVJQdHVOVXJV?=
 =?utf-8?B?azhaYWF5aXNFWStzeUpUSkJWWFZKY1hiaTVqRkxWc1ppMCs5WTh2ZlZBMnBp?=
 =?utf-8?B?bzUrNEJ0Y282d29Bd3NYa0VaSUVnUDNLNVJhd3IwMFhtZFRJYkk2U29qazJ3?=
 =?utf-8?B?ZW15T1puK2NydllVUGxtcnhTZVBHam9uR3NIaUFqZVhkNTlUN2pBQkRxZDJz?=
 =?utf-8?B?TlBTM0N0OTc5bmNjWnkxbXMrZ3RtZ1kvVzJOMEl5NTZEZzlSc2ZrL3J1YW5k?=
 =?utf-8?B?dFhmYnF4b1hDVlhwMmVHbmJSY0l6Ti9vOWRtVUhENGJTc1BrVHM2blY1T2N3?=
 =?utf-8?B?WnN1TVRqZTZ2UFI1K09OUzE4Z2s2S1NsT1lMTmNLdUNpOWJFL1Q5ZXFVdnp5?=
 =?utf-8?B?b2JJcUZaOXRhNTZwNzR5ZVYwM3VUZW50aldpU0JkNkdnaUtHNU9IRXBzSzVW?=
 =?utf-8?B?VkJhT1N6NkUwcjVncXBzMjkwNEdTY1hkbHZQTmU1dUNXcS9NT1IwU1czbHpD?=
 =?utf-8?B?UEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4a8e9f5d-a49d-439a-57e9-08db9a0729a4
X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5881.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2023 01:06:16.0126
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nGeJZhKeLsm+9pgvRM58904v6nnhAgEWbJwC2bIiiCnUfyX1DrSO9FbGGy/nodXkgT0Cb0n3lkMFoJE+JLM9mg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7862
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On 8/9/23 18:51, Baolu Lu wrote:
> On 2023/8/9 17:44, Tian, Kevin wrote:
>>> From: Baolu Lu<baolu.lu@linux.intel.com>
>>> Sent: Wednesday, August 9, 2023 8:18 AM
>>>
>>> On 2023/8/8 15:49, Tina Zhang wrote:
>>>> A sva domain's lifetime begins with binding a device to a mm and ends
>>>> by releasing all the bound devices from that sva domain. Technically,
>>>> there could be more than one sva domain identified by the mm PASID for
>>>> the use of bound devices issuing DMA transactions.
>>>>
>>>> To support mm PASID 1:n with sva domains, each mm needs to keep both
>>> a
>>>> reference list of allocated sva domains and the corresponding PASID.
>>>> However, currently, mm struct only has one pasid field for sva usage,
>>>> which is used to keep the info of an assigned PASID. That pasid field
>>>> cannot provide sufficient info to build up the 1:n mapping between 
>>>> PASID
>>>> and sva domains.
>>> Is it more appropriate to have the same life cycle for sva domain and mm
>>> pasid? I feel that they represent the same thing, that is, the address
>>> space shared by mm to a device.
>>>
>> iirc it's a simplification to free mm pasid at __mmdrop() otherwise the
>> implementation is tricky, but I don't remember all the detail...
> 
> Yeah, probably we could also free the sva domains in __mmdrop()? Remove
> the refcount for sva domain just like what we did for pasid (at the
> beginning we had refcount for each pasid...).

For sva usage, mm->mm_count is increased in iommu_sva_domain_alloc(), 
and gets decreased when the domain has no users (which is checked in 
iommu_sva_unbind_device()).

So, in a mm's life time, there could be multiple sva domains, though 
they are using the same PASID. I think it makes sense to mm. Because it 
makes no sense to keep a sva domain alive when no users are using it, 
even though the mm is alive.

Regards,
-Tina

> 
> Best regards,
> baolu