Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0651ed3c-7239-0235-ac14-b0379fe06297@windriver.com>
Date:   Fri, 11 Aug 2023 13:02:39 +1100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH 1/2] lib/stackdepot: Bail out in __stack_depot_save() if
 the stack_table is not allocated
To:     Vlastimil Babka <vbabka@suse.cz>, catalin.marinas@arm.com,
        akpm@linux-foundation.org, glider@google.com, andreyknvl@gmail.com,
        zhaoyang.huang@unisoc.com
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org
References: <20230810074704.2042664-1-xiaolei.wang@windriver.com>
 <20230810074704.2042664-2-xiaolei.wang@windriver.com>
 <08dd143e-3eb4-1854-eddd-508f997dd810@suse.cz>
Content-Language: en-US
From:   wang xiaolei <xiaolei.wang@windriver.com>
In-Reply-To: <08dd143e-3eb4-1854-eddd-508f997dd810@suse.cz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NlVKS3J0UWkzK01TcWtuR0xyWlNtYXppcGpWM3lHVGcxTGVMWTdQOHBDbElG?=
 =?utf-8?B?UjFRUW1JbzdRSVAzMkw3Y2oxOWlBa0cyRERsczl6ZFJXR0RadkVuVWlxaUxx?=
 =?utf-8?B?QW1TR21XN0pwTkZ3a1VjeU40cGpnYnpvV1hjZ0F3QTVpRG9UTDBVVUVCY3ll?=
 =?utf-8?B?R05XdmU3ZFNFNG9obEYveEtGZFc1RjVMRmJBNGN1NlNuMzFBUUxGWkxLUkFM?=
 =?utf-8?B?aythNlptQk92czNBV2RmMnBjcG5ESGFZSW1obmhKUS95WndVa0swZGllMG82?=
 =?utf-8?B?cWNsKzVyalNnVG5GQ29PSVJ4bHpZQVlmZ0FWdE9qRkhzaVpoMW0wZGRXd0RG?=
 =?utf-8?B?eFcwZ2VMUzcyalNtdWVoZmllSkdBSk1nNmxPdXRHT2p6VzNuL052ZWJ5VHFk?=
 =?utf-8?B?VWxSYTBMZHN2eXFrb3hnL1diQnNhZ1dreVFwVmtKZkhVQTY4VDBQZ1NQVkxB?=
 =?utf-8?B?cGJ6bnBNYnVPMEpyQjhPZENrNXVrWXhMdStuWTlJaFEvMWxNdE13Nkhsc2Ur?=
 =?utf-8?B?UHVLdHVSR1U5ZVFWQzdKQ3BianFabE1zOXkrdFlibUUxWGJSbUc0UkNYMmU5?=
 =?utf-8?B?VFFCOEo1R2ZxRXAyazUxVy9MT0lwazVsTUxuSTNidnlYNnZoQzdHeDBrbEt4?=
 =?utf-8?B?NmhXQjRTelpKVW1kL1hLMGw3SkRQUGp0OXFYd1V3WWJKdVduSDlnREJGeHJX?=
 =?utf-8?B?Ni9oWHlrdlMwU01wc29wRXR0Z1JJVFU1UW56TUc4M3NZdFFZbFl6eG9vV2th?=
 =?utf-8?B?Tkl5c3pOeFJRS0JRK3ZaK0lQU2YvaU9velFwTUtiWFp3U3pNNTVvYWVzbUto?=
 =?utf-8?B?NGhmUzE0TStNRjk2TDlKekU2ak9qNThoMUNSUHpMNHhxWjVDOWszMjJrcXA0?=
 =?utf-8?B?M1BuVlNyUlovMlE4Y2ZNd1ozaFFyN3NvYUVZTGFRSGU4a2NPNVVhSzZadWs1?=
 =?utf-8?B?UXJpSUlIQzZtZVRpcmgrbU1UV1FCenNUeVJiSGkxMUFRaE5SRjZUaUNIWENv?=
 =?utf-8?B?R2d5QVJQdEdYZ0ViL1lMN05JWURRY1U1dW1mVFZidWtPbm1BM0FUZnVmVDZ6?=
 =?utf-8?B?Q2duMERIVFE0ZDNFV2dySVpkUXVWb0JJM3IvUitMeFV5VW1FT1NQWGlqZW1N?=
 =?utf-8?B?VG9tdnQ5VU9ER0owVDFUSWNQVTRuNndmSWxsSnpEUEJBalUvL1ZZdjloUjY5?=
 =?utf-8?B?ZXlGSXJZSkZZMG4yR3l6cFd4a0d0LzdtZHhaMVpuUjIrS295ajZ1anpVbFBH?=
 =?utf-8?B?MzNEd3p0ZVZlSW5ybFcxWmxqcFRFUjRRQmk0NFY1dnQ4QVpWVFgrSlVyQ05B?=
 =?utf-8?B?aTN5TEZFNVUxWnE5akpUeWdBc3EyYWtkVXUwazVkd2pSaG54U3Z4R2trWkNS?=
 =?utf-8?B?T3Q2b2U3MzZibXFkcExRTjVOSmRKOEhPeXhyWlpjUk5YTzRYQ2FIeXRSQkhS?=
 =?utf-8?B?OVdjMFpxNTNkYkdhZitTWGhvOUY0UWJoODZzVis0Y1ZJWlFZcHZoYzdIM3hR?=
 =?utf-8?B?VlpFUlh2NDBMN2VTT2c4VDA3VElFVC9kckdvazBENWprM1o2QWN5SG5IVVYv?=
 =?utf-8?B?ai9NckVyVE9Md3RaTVhkT2ZkV3N3bS9QUFp0Y1FxMjFNQTJYNjBMQUZsQlV0?=
 =?utf-8?B?dHJYRythNnlDY1dpb1lJQmtKTk9kVVdnZm5XZWVDclQ1YnpobTJuUkZEZjl5?=
 =?utf-8?B?MHZJTExzQlZhY0VCMjRRYS9HczhpMDIvNENmZ1E2Ujh4dGNMNUk5T3VZMEIv?=
 =?utf-8?B?S3JCYUxnSldMQXJ4ZmlUYStna0VPV2dYVGhmTGZFMUQ2VzR4SWpPdUs3bmpE?=
 =?utf-8?B?eFR0SnV6aTE1YlVhODUvT1Q0M0dKOHVZaEQ1VHV0bTU4WHF2eENBREZBUWJV?=
 =?utf-8?B?dWU0MFlsb0dWRFk3T3pRL3QxTlF3SXJkc1hkWVU5emk2YkJIUjBPL1V6L1Nq?=
 =?utf-8?B?TEZRcEVZTVFOTnp4MXI2TmJjQVVhVzZPQURRa3VRSGRhRWoxWWNRaDh2MHgv?=
 =?utf-8?B?N3BvSHZzVFpPdXd6RVByRnVMUTlZWHdnOG1aUDAzK3JRK0xCLzRwcklsSTI3?=
 =?utf-8?B?akJ1dTlWenVLZ0FnWlRGRkdkcnRtMFhJRE9PTkR4V2lrMWZmaXZWS3p4QWU2?=
 =?utf-8?B?UDY5TzZzSGFoeEdUUm5YaWpPbTVuc1ZiWmN5K3FzVjlHSlVBTWdBYXN1am5t?=
 =?utf-8?B?YnpSMzU3NkNGRUJhb0h1eVdVVUtzVWZ1a1BaODBOTU55aWQzYmErZm9QVHF1?=
 =?utf-8?B?dG5lYW9CV3I3a0xDd1lJODlvM3RnPT0=?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e2b29209-6747-497c-9626-08db9a0f1255
X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5764.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2023 02:02:52.8002
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hCPNIiHtnx82ZmBhaTvaEZjZFynlEKAt8k5v6J/4qbA+nwikG+jlGzp90os6B8fgiZ+p52wmNbZQHVytIT7gdlYXegTTQXo3blxpNtaeo6Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7464
X-Proofpoint-ORIG-GUID: xQAfqYQLo-JPyiokJ2t87p49YmQB6MQJ
X-Proofpoint-GUID: xQAfqYQLo-JPyiokJ2t87p49YmQB6MQJ
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-08-10_20,2023-08-10_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 spamscore=0
 lowpriorityscore=0 mlxlogscore=849 clxscore=1015 impostorscore=0
 phishscore=0 mlxscore=0 malwarescore=0 priorityscore=1501 suspectscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.19.0-2306200000 definitions=main-2308110017
X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 8/10/23 8:53 PM, Vlastimil Babka wrote:
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and know the content is safe.
>
> On 8/10/23 09:47, Xiaolei Wang wrote:
>> The __stack_depot_save() may be used by some subsystems even before
>> the stack depot is initialized.
> Does that currently happen, or only after patch 2/2 it starts happening via
> kmemleak?
Yes, currently it happens after patch 2/2 it starts happening via kmemleak,

The reason why I take it as the first patch is because I think this can 
avoid

exceptions when there is only patch2, such as when we use git bisect to 
debug

>
>> So add a check of stack_table in
>> __stack_depot_save() to make sure no oops in this case.
>>
>> Fixes: 56a61617dd22 ("mm: use stack_depot for recording kmemleak's backtrace")
> In case it's only after 2/2 I don't think this is truly "Fixes"?

Yes, it is indeed for patch2 at present, it is to fix the situation that 
kmemleak

has no backtrace in the boot phase, and at the same time, it can also 
prevent

patch2 from entering the stable kernel and causing panic

thanks

xiaolei

>
>> Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
>> ---
>>   lib/stackdepot.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/stackdepot.c b/lib/stackdepot.c
>> index 2f5aa851834e..a0651d013a0d 100644
>> --- a/lib/stackdepot.c
>> +++ b/lib/stackdepot.c
>> @@ -376,7 +376,7 @@ depot_stack_handle_t __stack_depot_save(unsigned long *entries,
>>         */
>>        nr_entries = filter_irq_stacks(entries, nr_entries);
>>
>> -     if (unlikely(nr_entries == 0) || stack_depot_disabled)
>> +     if (unlikely(nr_entries == 0) || stack_depot_disabled || unlikely(!stack_table))
>>                goto fast_exit;
>>
>>        hash = hash_stack(entries, nr_entries);