Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wei Fang <wei.fang@nxp.com>
To:     Jesper Dangaard Brouer <hawk@kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        Shenwei Wang <shenwei.wang@nxp.com>,
        Clark Wang <xiaoning.wang@nxp.com>,
        "ast@kernel.org" <ast@kernel.org>,
        "daniel@iogearbox.net" <daniel@iogearbox.net>,
        "john.fastabend@gmail.com" <john.fastabend@gmail.com>,
        "larysa.zaremba@intel.com" <larysa.zaremba@intel.com>,
        "aleksander.lobakin@intel.com" <aleksander.lobakin@intel.com>,
        "jbrouer@redhat.com" <jbrouer@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
CC:     dl-linux-imx <linux-imx@nxp.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "bpf@vger.kernel.org" <bpf@vger.kernel.org>
Subject: RE: [PATCH V5 net-next 1/2] net: fec: add XDP_TX feature support
Thread-Topic: [PATCH V5 net-next 1/2] net: fec: add XDP_TX feature support
Thread-Index: AQHZy1dCnxQwOLKBq0eoj4kIh1yvrq/jjtGAgAC/ZrA=
Date:   Fri, 11 Aug 2023 01:26:56 +0000
Message-ID: <AM5PR04MB3139BB2A930C4D7297FDA3348810A@AM5PR04MB3139.eurprd04.prod.outlook.com>
References: <20230810064514.104470-1-wei.fang@nxp.com>
 <20230810064514.104470-2-wei.fang@nxp.com>
 <a7ede79c-8d5f-0036-7b8d-67c736cea058@kernel.org>
In-Reply-To: <a7ede79c-8d5f-0036-7b8d-67c736cea058@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?c07j2UyWvc0OEKkwmlUFGFks7pPwlKF5nlp0c+7CbyTRmktgrhHKdsQMEe2g?=
 =?us-ascii?Q?Lh/UDO71OTTtqveFbYKr8N/xFMzwT3dgZ05lGkVi65kjQlrtA0gPNEV4NZzN?=
 =?us-ascii?Q?NxyjhZ+b7JQsw0qYT4cy7gi5IPfb5nubv+kmxmrO82zvndR0Bs/OOgFarg1E?=
 =?us-ascii?Q?332s711LWOVL4dHAqGF1rIc2nhrqDa+VG9Ar9101J5vCqjwwE38zexjIKZ8y?=
 =?us-ascii?Q?x/RWpg3/gQ4WRnagpXQXbwHSKwXd0XwV9rVt18HQzfDvVYbH7YZURZCBimQI?=
 =?us-ascii?Q?9gqcqACbJkHYMZCcRffGtBCjY5BqZ17ee8coNM/N15Sl6Rl+Nci88M6Kxas9?=
 =?us-ascii?Q?P5+ngAuib+tmNPAIxDaCZjTzqxJWLY3pnsrQfrFIyoZ9zFRuL4D+uHLTC4ni?=
 =?us-ascii?Q?ApIIc7fg24+qoJQcJ7ZVEw8d+JcJfvjwMwgnv1mjD5sI6qtBRBbfwpm8oi9Z?=
 =?us-ascii?Q?wchT7arTynvpU4czPbNZ14Iko3RyVyIIe9KZSsFRq5ntABv+IVvcPEO063mO?=
 =?us-ascii?Q?kcn17sid63Z1EEQpp3uZimo9/UUudOW/sDDLXJBWilemk0/i4770btvD9IYJ?=
 =?us-ascii?Q?u8eYQwWdLn++4cvgK1NX2DqZioJXJ9yE39H4X37Flm2PbISzmYRXdUWulzod?=
 =?us-ascii?Q?4TqN9qln9K0kBuKbU2e5kOvA7bZqF/wPQI09fKNqp0g0red/Ikqg1pC7VYFu?=
 =?us-ascii?Q?XkftR26k1SRLpfvX0kvLBf/C53ZgkBixSdI+8LlLBZWeXEST+OO7Yo5fHeDZ?=
 =?us-ascii?Q?NCB+rEEWgNh9CptrxFM6pW9ZtmboJFkpRHk8kGP0rYZr4Izb/DKE2d7TzJYl?=
 =?us-ascii?Q?H9iuvG7KOGqI3qr+C9FTYdRzOtHYC0DUbEN33M6Wy5G+oOP/fpOUp6on2e8q?=
 =?us-ascii?Q?yuOJPLR3grjPGtS/ODnhCB4q1D5MviMZH3AZKsJozOMlQgPWkSGc7qW7/cmg?=
 =?us-ascii?Q?DPl+SaCtBHkR83BBj5rK1c+3PlDYTkI+rIQPe70PQ0+wxRBwDColcDioJmSY?=
 =?us-ascii?Q?Np+xXyLQVmgVsIb9ete/xCjrxbAlqvhka+Dljt8B6o/cEVYIao7wMyMdIisr?=
 =?us-ascii?Q?iOekiFbKTPrWrAlShYDPnMSfMB4PnOgp+6QngCrT7qWcWCTn6ip96vTrIMlE?=
 =?us-ascii?Q?vHyTQi/aRSoRTYzU9FKGdvoE0J22rBGWAgUk9XlNBuwQm4wDERUa51HDo3Fx?=
 =?us-ascii?Q?/rJInnbzZlzZ31xLOpnHazrgJjvS3ocgi2p3ettsnY4ShVLGUh7bS7nO3s6w?=
 =?us-ascii?Q?02DS/m9ABr9U+s7N+pQVYSGgj6UImE43B2E7+LmaRoaidk+x4+4tT9V8nQWN?=
 =?us-ascii?Q?4QGifUo/mExxQeny9cdtrJ0udeBCiMrJ8HpbSFJLtdISld/LRNPlCnhhnu4U?=
 =?us-ascii?Q?vrlIeljFuPcuknTIqDh93+qvN5fdl+ERfAv1aAQaUjPoHP9wZ3XmT3Rc4sGe?=
 =?us-ascii?Q?Mj+Gbp+FEcDw5xiYDc1JNJ3FCCdutYm3puAPNBDkBqPnFejWfemYkQggPSMb?=
 =?us-ascii?Q?u2yTXTxVAAb/z14CVw/pj/44AU5OlmGEJgw5LAIQO8izr0rWGQBSL5rcLR6S?=
 =?us-ascii?Q?+fCGryJwTG9+FU1YCQQ=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM5PR04MB3139.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b65045f2-6445-4e0a-7aed-08db9a0a0d26
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Aug 2023 01:26:56.3745
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: iHZWb8kvqJZKQdBB4/qpORfGa6UN2/5fIU7Dlt8PaTaka0c2hRER9r4VbLtMa/JpK4W3BvooJs9CogXxAXAv6g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6852
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> If you add below code comment you can add my ACK in V6:
>=20
Okay, I will add the annotation to the code in V6. Thanks.

> Acked-by: Jesper Dangaard Brouer <hawk@kernel.org>
>=20
> > @@ -1482,7 +1488,13 @@ fec_enet_tx_queue(struct net_device *ndev,
> u16 queue_id, int budget)
> >   			/* Free the sk buffer associated with this last transmit */
> >   			dev_kfree_skb_any(skb);
> >   		} else {
> > -			xdp_return_frame(xdpf);
> > +			if (txq->tx_buf[index].type =3D=3D FEC_TXBUF_T_XDP_NDO) {
> > +				xdp_return_frame_rx_napi(xdpf);
> > +			} else {
> > +				struct page *page =3D virt_to_head_page(xdpf->data);
> > +
>=20
> I think this usage of page_pool_put_page() with dma_sync_size=3D0 require=
s a
> comment, else we will forget why this okay...
> I suggest:
>=20
> /* PP dma_sync_size=3D0 as xmit already synced DMA for_device */
>=20
> > +				page_pool_put_page(page->pp, page, 0, true);
> > +			}
> >
> >   			txq->tx_buf[index].xdp =3D NULL;
> >   			/* restore default tx buffer type: FEC_TXBUF_T_SKB */
> @@ -1541,7