Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Jason Gunthorpe <jgg@ziepe.ca>
CC:     Baolu Lu <baolu.lu@linux.intel.com>,
        "Zhang, Tina" <tina.zhang@intel.com>,
        Michael Shavit <mshavit@google.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 2/5] iommu: Call helper function to get assigned pasid
 value
Thread-Topic: [PATCH 2/5] iommu: Call helper function to get assigned pasid
 value
Thread-Index: AQHZyczxCRfFMGhSVk2JCjxjKYlmLq/hG1GAgACeSCCAAC6iAIABQplwgACTOACAALMLgA==
Date:   Fri, 11 Aug 2023 03:18:40 +0000
Message-ID: <BN9PR11MB52762D093310D12FE5E5C76D8C10A@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20230808074944.7825-1-tina.zhang@intel.com>
 <20230808074944.7825-3-tina.zhang@intel.com>
 <f3d8692e-b13d-97ee-2288-c2be1858dcfa@linux.intel.com>
 <BN9PR11MB52767F29A6C11157659D375B8C12A@BN9PR11MB5276.namprd11.prod.outlook.com>
 <ZNOH9lPdTnltb9JZ@ziepe.ca>
 <BN9PR11MB5276A5E619DF6638677DFFA58C13A@BN9PR11MB5276.namprd11.prod.outlook.com>
 <ZNUSEiXTYbV7ML6x@ziepe.ca>
In-Reply-To: <ZNUSEiXTYbV7ML6x@ziepe.ca>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?86z2zc3beYo2Oimsz5795LnRim+cS/KiRIGE1CdZueciwAIrsXHQ0AII5eMl?=
 =?us-ascii?Q?yXI4XSKlrySmFu/rKvdcBa0sYPFQADNYtvy/cyXsNVmadUTols5A+28vZRuo?=
 =?us-ascii?Q?/fhxJe+5+HaqAv/+mmxc5FkDAZNQfOwO3rUk1YcxEGi6KVgXGLkflAdEDjFh?=
 =?us-ascii?Q?Efrh/SRL5DiPNhHD3sxUsp4D1aX9PeDynor2UudoWsWyTK/LphZxk8d1q0XG?=
 =?us-ascii?Q?N/neZZHHhVrzrjiYgKPmURnlfyNy9L3KsKylcjTVKSotCzD2+LSl9tF/pU3I?=
 =?us-ascii?Q?OP34W1wUXNsiqeYHRvuLP4tgjU1V207Fl8LgnG3lkfh6zFx6MffR4ULR0RDR?=
 =?us-ascii?Q?4vwkoi+n6N7m1KCSZNNkcRWi7DL7+/MHTrKtzIfwGAROKkxN2jU6XY3IPkPR?=
 =?us-ascii?Q?zUoqBM6BdpinXYSX4mr/kNSD3YMfDtnemNnlPzn1jATr4PLOWoGyXS6FTaNQ?=
 =?us-ascii?Q?yJeCpeAgq2jsNsTwlZAmUDUFuFsFL6E3XcBPPvQqjJ3K58sE4cQu4K3ZLLji?=
 =?us-ascii?Q?BaAf8ZEyxfxXIGTygnfYqOcUvtKAVNzGUvSJehv/EkL6+5kR5W4dyM8GJ+qP?=
 =?us-ascii?Q?Nigezf+CrlPdQPw2xUfBbWnIFZ6q9odJlJ7meufZ6lzvcFoZM9Z+mSodLeWe?=
 =?us-ascii?Q?Y5kwFkvCC9fb8FsTM9K6N6haulUuRMpTNmbAIf6LOWB8fla0rLqKPGENfsXF?=
 =?us-ascii?Q?hSQV/rl0Hb4mq3TmBJCKNTWiE0HxW/Br/BEMboCG7Bj+q5cHi5Tsm7y/wIea?=
 =?us-ascii?Q?Amny4POAwjwr9QZIBbUj63g6cy0CSD4KNvh7jti3A0aM0SH+0YsWAyPtwND2?=
 =?us-ascii?Q?aX6dcHG6UFJDoVfTkkZEAYJt9tL/y2C60LifB8340EWFLHaLDupiHICrNYrW?=
 =?us-ascii?Q?m0fFj/aJISeyL8SxTUKzn2FNfFckHHyGdMKe8F98CFIv9Cy1uQji8GXOCWPn?=
 =?us-ascii?Q?JMDqj6nTg9ZNDCe3AEsmnne+2mSC7S62BXreVW8xZHfhX7AhlsKNtz8M1eVM?=
 =?us-ascii?Q?A1bMB1kAD+D5KiX1Q+hSKgS3sZ8iWQm664ly5v8NMWIMcjTIV9Lki26wrlSV?=
 =?us-ascii?Q?FJ9yMOWWfwNzaIMgBHf8DfHgf/5+btVAr110q67zvJEX6zVVDFzor7wF+uy5?=
 =?us-ascii?Q?3MXAeTi0og6h76/WHGLECXWU9bZQf4zp0hhqTOspfO8V/W9KFOpBPOjPYN2E?=
 =?us-ascii?Q?Xx0REdDX3oSWy+JvbOQsqjkdWHgRgizVeN1AQfTMs8EJJ+F/ukqUbeon3kNx?=
 =?us-ascii?Q?jT4Sw6WDNsnhUI7Q+ERo7YYVRCMcWrrKtW9LT0SveTx1tLxVetY0XU/QYFjS?=
 =?us-ascii?Q?Nl1RFojmtAboUduhtvALf+LHTzitYGSsRC1iQ8tnF01oXHwqugiUGB8cwuQe?=
 =?us-ascii?Q?l+bM2SW/Fk5p0nDI58nMyQiz0sOZmk0/KtKKOIOXWhPXy6ZtHLgW0hCJOZaV?=
 =?us-ascii?Q?FaaFYkupLgZSlttnuIZ7MwvrUV6BYYGvmUtew6uQwxrbsxMXIseQvPAZE4kQ?=
 =?us-ascii?Q?9hXOycFErFLIQYgw7B8ukpbKJZarV3/v2vRRvNAFrbvysbnitqwc52bypFwm?=
 =?us-ascii?Q?ZcRZm+neSGojhQlzTPb6OhK8SW1zUTCYar1uMo0i?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7cafaf41-d325-4061-091f-08db9a19a94d
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Aug 2023 03:18:40.7754
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ImI/4ffFNX798bjuQtHHoNOVkzWaIl9BNfOTVwos4L1gqa7/2tTRFyyGrnxpRe6DmIFpQiYjAfbc94ZswTyTxg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6780
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Jason Gunthorpe <jgg@ziepe.ca>
> Sent: Friday, August 11, 2023 12:37 AM
>=20
> On Thu, Aug 10, 2023 at 07:52:52AM +0000, Tian, Kevin wrote:
>=20
> > > The driver should rely on there being exactly one iommu_domain for SV=
A
> > > per mm so it can hang the mm_notifier off the iommu_domain
> >
> > I'm confused. Isn't this series trying to allow multiple domains per mm=
?
>=20
> It is doing both.
>=20
> The main objective is to allow de-duplicating the SVA domains in the
> core code. The driver should be able to assume one SVA domain per
> instance, or even one SVA domain per compatible instance. The driver
> should not do any de-duplication.
>=20
> But we can't just store a single iommu_domain in the mm_struct - we
> have the same problem as iommufd and we need to create more domains if
> the domains we already have are incompatible with the device.
>=20
> Arguably this should not happen, and in any sane configuration we
> should have only 1 type of IOMMU driver that needs only 1 SVA domain.
>=20
> But right now things like SMMUv3 have problems crossing domains across
> instances, so we could have one SVA domain per IOMMU instance until
> that is fixed.
>=20

Thanks for the explanation. Tina, please include this information in your
next version so others can easily understand the motivation of introducing
multiple sva domains per mm.