Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Ying Liu <victor.liu@nxp.com>
To:     Conor Dooley <conor@kernel.org>,
        =?iso-8859-1?Q?Guido_G=FCnther?= <guido.gunther@puri.sm>
CC:     David Heidelberg <david@ixit.cz>, Marek Vasut <marex@denx.de>,
        Stefan Agner <stefan@agner.ch>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        "kernel@puri.sm" <kernel@puri.sm>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Rob Herring <robh@kernel.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] dt-bindings: mxsfb: Exclude i.MX8MQ from power-domains
 requirement
Thread-Topic: [PATCH] dt-bindings: mxsfb: Exclude i.MX8MQ from power-domains
 requirement
Thread-Index: AQHZwxWBRtjRdjXmIUGhn7S5iRfipK/Wx5iAgA00cYCAAKVY4A==
Date:   Fri, 11 Aug 2023 05:49:04 +0000
Message-ID: <AM7PR04MB7046A5CD36B2A8B24B8F7CB09810A@AM7PR04MB7046.eurprd04.prod.outlook.com>
References: <20230730184120.94984-1-david@ixit.cz>
 <ZMonFSqutQRqs61n@qwark.sigxcpu.org>
 <20230810-embroider-seduce-ee4506e7608b@spud>
In-Reply-To: <20230810-embroider-seduce-ee4506e7608b@spud>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?Psv415TBk6hCkGuWCDY3aj2c+zFKpTuycE3aYoxyLyB33uvLdTvUA356hN?=
 =?iso-8859-1?Q?77+wnxBWOdFbUm5q+fldr44yQ+StCeqCf/J78rp5TcmQgbEAoN/aNXkYbz?=
 =?iso-8859-1?Q?KP4E0qaXB0AVFo573whHvRB+ooQCUM5Yin9n4RO+M9QSYJQXEu4VXydZ5P?=
 =?iso-8859-1?Q?+r6kEthMqSjbw7EADKkRWVvXmQ01laZdZziR3Jjy8ZezknSycxIpuNn8//?=
 =?iso-8859-1?Q?EJaE5oB/lHF8pP/eyr0c3StoOc/hdWXAjPPGq+36vlSUgHs4DpxLCJ+RzW?=
 =?iso-8859-1?Q?ZmdEwOowMJJJGdqItWt/mfNvUHlSRxVY4wiFXiErLvIXi2JBCNjMF7jJLY?=
 =?iso-8859-1?Q?yhny8KWMnj39/aeaMh/aYAAKjF2eGAfJqNbKYFILflpUQbz+Cz5YID/qOc?=
 =?iso-8859-1?Q?FvEUwRm80LrekUicXWyCWlDHmQk69bAwA8xGeRgjcqcDs2pnyLuIx1hC/I?=
 =?iso-8859-1?Q?8Nqn7jKAP1QZdNcJX2Vp1vSCV1imUNbQaIAtzhsG4byUH6tcpUMbHdbD2c?=
 =?iso-8859-1?Q?p/ePfZc6TpO9IxQIycwesHTz0NBf3CYd+apMVdDxwUqVxnl1ic2eo+An8M?=
 =?iso-8859-1?Q?0rLdtllO9s7lhH/fIMj5os/I4qt/MlQFEnmixRBRP/tezVs6tltKCxEic5?=
 =?iso-8859-1?Q?iPPiNGXo6veUtntAitagzsxJgAGuLWgFRxAV2dyaJYQ2OMwXUVYDKxtdz9?=
 =?iso-8859-1?Q?gcZNSHxEXpHBHjcxaIkr9CmfHwB3RjwSCfOJ8kn5KzAI3VlVmVY+/9d+yQ?=
 =?iso-8859-1?Q?TscZ0hAuuAyyYul/xz4sRPJqbEFIVipgSrBL2dCntFf/sFGYfXiI97pGSB?=
 =?iso-8859-1?Q?7NyfVS5MEtbktuKNcyL4z9kkjKkSXe4gq9Bj6r3BIwyjg/SpqebkJbKCf7?=
 =?iso-8859-1?Q?oMBEMddhaB4iUo0N8ZLpWUjwDQshOnYmT+2bxs5+fE0JcGijg7+RLt3ZJm?=
 =?iso-8859-1?Q?gCA/cI49wKbPF1+iLI8pQe5VI89/fSCXFMzydIsWDzceLyPKH5kCINh475?=
 =?iso-8859-1?Q?aIFTevjJhCNWr33PIWPAsoIdIPR8X0vp7IqirkWn4f8He6nwcuLPkHfKcd?=
 =?iso-8859-1?Q?hD48phq6wr+L0mVWqVZAE7KwWC8DUlVKY5wYTN0iPy+nRU13VaipwxEaux?=
 =?iso-8859-1?Q?JIW2qPhVv7QPQAxTKERjZshNAS0+70BGyHdKnPAoLrqh2rer6Guwaol4ci?=
 =?iso-8859-1?Q?ywE5fyeh3VNVt/X7YLVqcZk2rFx8KaSeLDyZpcl3IQpA+n1xT59QmzWgUP?=
 =?iso-8859-1?Q?iXf9CHg94rYIoYMu42xu3qceBGQltxRKQJEnsiT2lPerHuK+BSvSTtmMNz?=
 =?iso-8859-1?Q?gv8fcEoZShz0IxQM/lvgTgM8qppeQUFVVgbFVRAF0PeicYj2pOAIgjfMm+?=
 =?iso-8859-1?Q?F3xn4j54XKCT4S92m24Tr1AlNYigK69FB0SydBJ86fkS4dPboAELD6wcFB?=
 =?iso-8859-1?Q?WtfxcjAWaGJwh6MYdX07N6SPnerVe5YkFq7W3CuzopXrtoSngAl1yIQKjH?=
 =?iso-8859-1?Q?ZmhulBYQDmKCok8r08hOw++FjDk/R4WG4lrpmDg9Q3jKaKN+QfbMcmXjh3?=
 =?iso-8859-1?Q?DjImI5K34489VNvkHW52kBJWNXIruh+VdISUhuMTRLh3f5c8v+yDnEFs2Y?=
 =?iso-8859-1?Q?LLfF12JFUcTkM=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c3fdfa91-a7b9-452c-73ce-08db9a2eabf2
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Aug 2023 05:49:04.6768
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6qZQZnmPLH8uWT8xDUMoFjSmbTo3iosbpSUqcY4AJCKBHpYZ4XyXCM+DokoNDGiK7PTOl5dCRu9a9rPbEflhdw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7079
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Friday, August 11, 2023 3:30 AM Conor Dooley <conor@kernel.org> wrote:
>=20
> On Wed, Aug 02, 2023 at 11:51:17AM +0200, Guido G=FCnther wrote:
> > Hi,
> > On Sun, Jul 30, 2023 at 09:41:20PM +0300, David Heidelberg wrote:
> > > i.MX8MQ uses as secondary compatible fsl,imx6sx-lcdif, which triggers
> > > requirement of power-domains, thou it's not required.
> > >
> > > Fixes: f62678a77d58 ("dt-bindings: mxsfb: Document
> i.MX8M/i.MX6SX/i.MX6SL power-domains property")
> > >
> > > Signed-off-by: David Heidelberg <david@ixit.cz>
> > > ---
> > >  .../devicetree/bindings/display/fsl,lcdif.yaml        | 11 +++++++++=
--
> > >  1 file changed, 9 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> > > index fc11ab5fc465..2d868276b0f9 100644
> > > --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> > > +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> > > @@ -129,8 +129,15 @@ allOf:
> > >                - fsl,imx8mp-lcdif
> > >                - fsl,imx93-lcdif
> > >      then:
> > > -      required:
> > > -        - power-domains
> > > +      if:
> > > +        properties:
> > > +          compatible:
> > > +            not:
> > > +              contains:
> > > +                const: fsl,imx8mq-lcdif
> > > +      then:
> > > +        required:
> > > +          - power-domains
> >
> > We currently enable the mipi power domain for the mipi dphy and nwl
> > bridge only but not for LCDIF itself assuming it's not needed (as there=
's
> > other outputs LCDIF can drive). I *think* this is correct but maybe
> > Marek or Liu can confirm?
>=20
> I'm happy to Ack this, but I've been sitting on it waiting to see if
> Marek or Liu popped up..

I see DCSS and HDMI controller/PHY sit in displaymix in a system
bus diagram(internal only), but LCDIF and MIPI DSI controller/PHY
are not in that mix.  So, it seems that the "gpc_disp" power domain
defined in imx8mq.dtsi supplies power for DCSS and HDMI
controller/PHY only, though nxp,imx8mq-dcss.yaml doesn't even
allow a "power-domains" property...

Assuming that system bus diagram is correct and "gpc_disp" power domain
does supply power for everything in displaymix only:
Reviewed-by: Liu Ying <victor.liu@nxp.com>

P.s., there are still a few warnings from dtbs-check, see build log[1].
Hope they can be addressed...

[1] https://gitlab.com/robherring/dt-review-ci/-/jobs/4767324570/artifacts/=
raw/build-dtbs-1814673.log

Liu Ying