Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230810112015.3578-1-aboutphysycs@gmail.com>
In-Reply-To: <20230810112015.3578-1-aboutphysycs@gmail.com>
From:   Alexandru Ardelean <alex@shruggie.ro>
Date:   Fri, 11 Aug 2023 08:57:24 +0300
Message-ID: <CAH3L5QqXMAmiiDF5cNM9fY68hiqXeH6GKHdrQYG5Mh9H9Nrc3w@mail.gmail.com>
Subject: Re: [PATCH] thermal: k3_j72xx_bandgap: removed unneeded call to platform_set_drvdata()
To:     Andrei Coardos <aboutphysycs@gmail.com>
Cc:     linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
        rui.zhang@intel.com, amitk@kernel.org, daniel.lezcano@linaro.org,
        rafael@kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Aug 10, 2023 at 2:20=E2=80=AFPM Andrei Coardos <aboutphysycs@gmail.=
com> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Als=
o,
> the private data is defined in this driver, so there is no risk of it bei=
ng
> accessed outside of this driver file.
>

Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>

> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
> ---
>  drivers/thermal/k3_j72xx_bandgap.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/thermal/k3_j72xx_bandgap.c b/drivers/thermal/k3_j72x=
x_bandgap.c
> index 5be1f09eeb2c..b91743dbd95a 100644
> --- a/drivers/thermal/k3_j72xx_bandgap.c
> +++ b/drivers/thermal/k3_j72xx_bandgap.c
> @@ -502,8 +502,6 @@ static int k3_j72xx_bandgap_probe(struct platform_dev=
ice *pdev)
>         writel(K3_VTM_ANYMAXT_OUTRG_ALERT_EN, data[0].bgp->cfg2_base +
>                K3_VTM_MISC_CTRL_OFFSET);
>
> -       platform_set_drvdata(pdev, bgp);
> -
>         print_look_up_table(dev, ref_table);
>         /*
>          * Now that the derived_table has the appropriate look up values
> --
> 2.34.1
>