Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To:     Daniel Wagner <dwagner@suse.de>
CC:     "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        Chaitanya Kulkarni <kch@nvidia.com>,
        Max Gurtovoy <mgurtovoy@nvidia.com>,
        Hannes Reinecke <hare@suse.de>,
        Sagi Grimberg <sagi@grimberg.me>,
        James Smart <jsmart2021@gmail.com>,
        Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCH blktests v2 05/12] nvme/{041,042,043,044,045,048}: Remove
 local variable hostnqn and hostid
Thread-Topic: [PATCH blktests v2 05/12] nvme/{041,042,043,044,045,048}: Remove
 local variable hostnqn and hostid
Thread-Index: AQHZy3uz1xpR6Nr34U2dUvx8v8aZKq/km7oA
Date:   Fri, 11 Aug 2023 06:02:04 +0000
Message-ID: <lbjgs7ebcywpk2nyli37pgpco2xgbprq7jexm7oksv2dbrofam@u6gbtsmcqw3j>
References: <20230810111317.25273-1-dwagner@suse.de>
 <20230810111317.25273-6-dwagner@suse.de>
In-Reply-To: <20230810111317.25273-6-dwagner@suse.de>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pvhW7MbiXSZB4Ir2aajpIs1CtGYuW/jektj3lGLdK354UVmixMK0vZA0/4lF?=
 =?us-ascii?Q?hzMqYYM/sVr6vVnIaPWJXtPYQlqNwYkHOG1ao/JZqvCAc5xUmFulidiDIR1T?=
 =?us-ascii?Q?M/jnGGdhMkXY17RP4IRaUtPAw87p8RL48Jqb2NoiKSLda3pRxH0nXc3AjdwL?=
 =?us-ascii?Q?CBm//u1d15s6ko5uTXaNUkgpwwP7oIRSrZ6fthttR/qzd0+VfU1vPHLtFZrI?=
 =?us-ascii?Q?81A7uWmlKVNKKluitVFWope/iUcGon+yCq6V7ibpIRMKHJxU0D/03bpa2GjB?=
 =?us-ascii?Q?i9Ixo8igYl/Jq6BTGxjCFZbxYeQo4/ubyOTWHIm/EqX53qA3YY+GCqYQs5bD?=
 =?us-ascii?Q?7El8cjhHY9JTqR8j9bKaYyWVsd6EqCKo2dZ+MK4Mq9WDadFgQgCeujsSin4d?=
 =?us-ascii?Q?dC1XvN6Gmq0DUBJA/5daJDcJjnbZBrd0DRaSDHtAbf1d599qMINed3MnqaDn?=
 =?us-ascii?Q?1l/4CXK6ecfGlkKjWFHJQCLOr26TXJiHIV0+vpzMkSgdTucU3NSyMnojT++R?=
 =?us-ascii?Q?f4hvmmFO97ffJVxcUE6fPuGj2OGi5NSmw1ucgaHnL7cjsY3RuCttVWm/Zrgo?=
 =?us-ascii?Q?zsrvOSA9UnX7t04R7eUXPiolRiIRkneGnFXBUGk9yuoRGCDTK4iu0fazbx4M?=
 =?us-ascii?Q?GNz5ZUHgRx/TaERpDj6N67ZCiGidtR07u8eV3rqPyZm+OJfIF2UR1wv+sGkC?=
 =?us-ascii?Q?vH28uPJGpf1xP5WI4uGmrQ62Nfabg55yTvq62zXrw93mAgeErBSKw9v0JDl6?=
 =?us-ascii?Q?QOfHVrBKAsN8in4aZP05RYKM/uThac5F9Mx82oTzYW2OtWFIUsihSRHWmRNH?=
 =?us-ascii?Q?f135YaS85cRu73cRN7aBjnh7MYzw2xpqDWrH0B7+vcXB6tR2pjPMecutgT3w?=
 =?us-ascii?Q?2RxckMtZ+Hmd3MRHMKgsdKOk+oiVJZy1XvIJVQdwCum0dJkMu9IqonySONg3?=
 =?us-ascii?Q?mQm+CAOUjZ8+7DLaZ5kV/AS/He+cWfCdbKg+xYTJZF1EwMwUoE6pMPsnRL/L?=
 =?us-ascii?Q?qXCRoo7qruCeUmo47/ZHrt8D+yYyMPRuISUPDMi6rPgE79MVVqdhkxFbwqyW?=
 =?us-ascii?Q?5odvlR6MLaI8w8UNnOxipcQx6BC/tuZmS6dcnnxE5m6H/SZWmBj4F1Jer62f?=
 =?us-ascii?Q?ittVCs3b5bqfZNr2Sc9IbruoBGtYaCwCBi3NU90pmwdvi9M16EJu2fYwVKmp?=
 =?us-ascii?Q?ZgKgrScJvVlSdb8cn1E3Dg4KZVaK/U5cVKt+ScLZWTEQWDzF8Se9fMFO4gv+?=
 =?us-ascii?Q?xq0Z8LuliE8Q9NkzYYHcvs6qaUQiEMSHqU6TWpO9KZDMU0FFRBRoB8hTguJn?=
 =?us-ascii?Q?2sWfQBKT4dUtsO9ApNQaEV3PNOB0Ctw8tbSzoRagy22KCEaoetPnN6VhJX5C?=
 =?us-ascii?Q?V4n5R9D7f1h0NPDoksnN/qmIHzDeejyDL3cIMe2Qw8p301vyQy7cTnuLXW4M?=
 =?us-ascii?Q?XaBtW23XwAFOWOhO7EXAGNODZfGnZwnT14EWhKntaiAUJPLTtjYpiyVtnl0e?=
 =?us-ascii?Q?hUAd/dx/2wLFDN1GAXboQ3b5KOX/z35HniWB3Ry0My8M3C3aWqk9uj4xuLhs?=
 =?us-ascii?Q?BvH7tCrOMP5FU7sQwRzcPULY2iBhdn5Mp2IFZkJqS2Mo6LhbAAVPMg7xR/5C?=
 =?us-ascii?Q?OCuAZh6krXDLd53/ZNXubTg=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <AD85BD99EC11A6439E261581F645EF8E@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?qtOaVytp+MDbjlO3DOQ0OhSpCY+SoRgCP4JqS0L7X4o0ehV945WZ+CG6lWss?=
 =?us-ascii?Q?KIBWayNenimo+D6TUCqkY1r3HJQFLVpH8MDGuRZPrprynesXtibeQLriYbVe?=
 =?us-ascii?Q?yAenrium9jq2Ar+5kUlFKvtrO7MndxVaPij2Kw6pThR7JwlRPYUbkHSRlGPX?=
 =?us-ascii?Q?rgNszMcYiiJcRfc/ZR7eKYxvejineVRzvDkvquinoY0HooO2NZv1umZ8HuUp?=
 =?us-ascii?Q?wdhlb6VPQVoJu9LsiGPHrfVEoUxp5ul3nEMSrfo6ck42xPD5IbJ1+2nuUTIz?=
 =?us-ascii?Q?ILENcvV0IESr1GTnuLh0PbSZQpepH1RsrqcR4JrcbQewAqLpyPpegPm7CvpK?=
 =?us-ascii?Q?hhK0j5IigFYPDxJAJ4zZg5TtQXEIKqSLz4mro0t7eADeS8miMXamMG2G1KGw?=
 =?us-ascii?Q?pMDEcbFKe+BTn5zTJz097V/g+1E0SeHKKEZLJK8/f1RGWKMSo2Vad2xt0gGl?=
 =?us-ascii?Q?VCJ+m7xRvjEcDZWEDlx4yoHO0MZ72iikmydLiTqBlW/rBGAD67KDwiaDw3sE?=
 =?us-ascii?Q?AEl1Y4E7USyXetxm9U0+Qqm+B8eWzhHm/tcoOIZjDbUHeBy0jDwYUl76FgEi?=
 =?us-ascii?Q?Db0Q7l3zBgQ/Og+KF668fIi0wiC7y4hDtoFp5JODlAoGTvkQQW1EjL9fTa74?=
 =?us-ascii?Q?haWz0yMD5J3+1VLT189i0DCJHUksADBSVxjgpCXGBjVQzCwYoLLFg/F4t7yP?=
 =?us-ascii?Q?nTxNekCdMPhgGRifOtBbKHstxeBRavQcZ0AYug4ld78ibU9ORsbgbE/3TmfH?=
 =?us-ascii?Q?4azDr96Em1CD/3fc3mjfoQ1AbmVnh6ouoqKtPbdL+Usp0YLIzOyJ2GH0DqCL?=
 =?us-ascii?Q?jXe+VCnNzl0q/WZUhOD/pO/djE0UUNpP2pHjvQGOKNu3QM5KOc1cFGvXb4mz?=
 =?us-ascii?Q?xl45/E8R4ShVRsQz8WAs2BaajqzNkrpkiCtXW+bfwgebmiWtoO3yfGOlOTiz?=
 =?us-ascii?Q?TtGSSzTsIi2IJCGQrinLow=3D=3D?=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR04MB8037.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 65d7488a-c56a-4807-964e-08db9a307c86
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Aug 2023 06:02:04.0484
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: cCXHPnGsEZbt7cQGVkE8wTqhriEnhDG+/HDxI1Spa4+8c+WYIdw1QQvetigp8r7xSMXoD+Gk/IHMUhhwFPN13l6FD5fqM7HeNo7RURhDdeg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR04MB8716
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        SPF_HELO_PASS,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Aug 10, 2023 / 13:13, Daniel Wagner wrote:
> Commit acc408477e85 ("nvme/{041,042,043,044,045,048}: Use default
> hostnqn and hostid") switched the test over to use the default
> hostnqn. It missed the change to remove the local variable and
> use the def_hostnqn/def_hostid directly.
>=20
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
[...]
> diff --git a/tests/nvme/043 b/tests/nvme/043
> index 3dc543fd55d3..5569a7a58ad5 100755
> --- a/tests/nvme/043
> +++ b/tests/nvme/043
> @@ -26,18 +26,13 @@ test() {
>  	_setup_nvmet
> =20
>  	local port
> -	local subsys_name=3D"blktests-subsystem-1"
> -	local hostid
> -	local hostnqn
>  	local file_path=3D"${TMPDIR}/img"
>  	local hash
>  	local dhgroup
>  	local hostkey
>  	local ctrldev
> =20
> -	hostid=3D"${def_hostid}"
> -	hostnqn=3D"${def_hostnqn}"
> -	hostkey=3D"$(nvme gen-dhchap-key -n ${subsys_name} 2> /dev/null)"
> +	hostkey=3D"$(nvme gen-dhchap-key -n ${def_hostnqn} 2> /dev/null)"

This part changes the -n option value from ${subsys_name} to ${def_hostnqn}=
.
According to "man nvme-gen-dhchap-key", this fix looks valid for me. It wou=
ld be
the better to note it in the commit message for clarification, even though =
it is
a minor fix.