Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230811030750.1335526-1-guoren@kernel.org> <cf25b0f4-ee4b-40bd-a928-afdc4cad5c2e@app.fastmail.com>
In-Reply-To: <cf25b0f4-ee4b-40bd-a928-afdc4cad5c2e@app.fastmail.com>
From:   Guo Ren <guoren@kernel.org>
Date:   Fri, 11 Aug 2023 16:13:47 +0800
Message-ID: <CAJF2gTQ9vJZrDJ32nzq67XmYOqtXjYdsx=L2ob9yGP94fM-G5w@mail.gmail.com>
Subject: Re: [PATCH] csky: Fixup -Wmissing-prototypes warning
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     "linux-csky@vger.kernel.org" <linux-csky@vger.kernel.org>,
        linux-kernel@vger.kernel.org,
        Linux-Arch <linux-arch@vger.kernel.org>,
        Guo Ren <guoren@linux.alibaba.com>,
        Arnd Bergmann <arnd@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Aug 11, 2023 at 3:33=E2=80=AFPM Arnd Bergmann <arnd@arndb.de> wrote=
:
>
> On Fri, Aug 11, 2023, at 05:07, guoren@kernel.org wrote:
> >
> > Link: https://lore.kernel.org/lkml/20230810141947.1236730-17-arnd@kerne=
l.org/
> > Reported-by: Arnd Bergmann <arnd@kernel.org>
> > Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
> > Signed-off-by: Guo Ren <guoren@kernel.org>
>
> Thanks for addressing these!
>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
>
> > --- a/arch/csky/kernel/vdso/vgettimeofday.c
> > +++ b/arch/csky/kernel/vdso/vgettimeofday.c
> > @@ -3,24 +3,35 @@
> >  #include <linux/time.h>
> >  #include <linux/types.h>
> >
> > +extern
> > +int __vdso_clock_gettime(clockid_t clock,
> > +                      struct old_timespec32 *ts);
> >  int __vdso_clock_gettime(clockid_t clock,
> >                        struct old_timespec32 *ts)
> >  {
> >       return __cvdso_clock_gettime32(clock, ts);
> >  }
> >
>
> This works, but it would be a bit nicer to move the
> declarations into a header. I see that we already handle
I know you concern, but I didn't find a proper header file. So I
copied riscv solution, let's solve that in riscv first, then csky
would follow up. Thx.

> this in three different ways across x86, arm and arm64,
> and you picked method from x86 (and loongarch) here, so
> I can't really complain.
>
> What we should probably have instead is a new header
> in include/vdso/ that  declares the functions for
> every architecture.
>
>       Arnd


--=20
Best Regards
 Guo Ren