Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230809052952.323-1-wenchao.chen@unisoc.com> <CAPDyKFoykxdP70t2pjeiX0pkKuUCZ2AeFM4yT4-wfVijxB7OHw@mail.gmail.com>
 <CA+Da2qx52QVk5Hz2PdY78qHRmspkDkXbWCWbUOGXCt2nbjNW0Q@mail.gmail.com>
In-Reply-To: <CA+Da2qx52QVk5Hz2PdY78qHRmspkDkXbWCWbUOGXCt2nbjNW0Q@mail.gmail.com>
From:   Ulf Hansson <ulf.hansson@linaro.org>
Date:   Fri, 11 Aug 2023 10:42:20 +0200
Message-ID: <CAPDyKFoHwg3MvyNTTTnZLhsEA0Zhj6ZU+fZkhf8rGeoTsnTDJA@mail.gmail.com>
Subject: Re: [PATCH] mmc: core: Add host specific tuning support for SD HS mode
To:     Wenchao Chen <wenchao.chen666@gmail.com>
Cc:     Wenchao Chen <wenchao.chen@unisoc.com>, adrian.hunter@intel.com,
        linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
        zhenxiong.lai@unisoc.com, chunyan.zhang@unisoc.com,
        yuelin.tang@unisoc.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, 11 Aug 2023 at 09:23, Wenchao Chen <wenchao.chen666@gmail.com> wrot=
e:
>
> On Wed, Aug 9, 2023 at 6:09=E2=80=AFPM Ulf Hansson <ulf.hansson@linaro.or=
g> wrote:
> >
> > On Wed, 9 Aug 2023 at 07:30, Wenchao Chen <wenchao.chen@unisoc.com> wro=
te:
> > >
> > > Added .prepare_hs_tuning and .execute_hs_tuning host
> > > callbacks to support host-specific tuning for SD high
> > > speed mode.
> >
> > This certainly needs to be clarified more. Especially why it's needed
> > for the sdhci-sprd variant.
> >
>
> First of all, Unisoc's IC provides cmd delay and read delay to ensure
> that the host can
> get the correct data. However, according to SD Spec, there is no need
> to do tuning in
> high speed mode, but with the development of chip processes, it is
> more and more difficult
> to find a suitable delay to cover all the chips.
> Therefore, we need SD high speed mode online tuning.

Thanks for sharing this information - and please add some of this in
the commit message next time.

[...]

> > > +static int mmc_send_tuning_data(struct mmc_card *card)
> > > +{
> > > +       u8 status[64];
> >
> > We use kmalloc-ed data for data transfers.
> >
>
> Why is it better to use kmalloc-ed data?

If you use DMA for example. From the core point of view, all data
should be kmalloc-ed, if it's a data transfer and possibility that
that DMA is used. Hence, it seems reasonable to conform to this
behaviour when using this helper function from the core.

[...]

Kind regards
Uffe