Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 11 Aug 2023 12:38:21 +0300
From:   Andy Shevchenko <andriy.shevchenko@intel.com>
To:     Tony Lindgren <tony@atomide.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>, Dhruva Gole <d-gole@ti.com>,
        Ilpo =?iso-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        John Ogness <john.ogness@linutronix.de>,
        Johan Hovold <johan@kernel.org>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
        Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH] serial: core: Fix serial core port id, including
 multiport devices
Message-ID: <ZNYBjafHuutSrN4B@smile.fi.intel.com>
References: <20230810065737.47294-1-tony@atomide.com>
 <ZNUBHaDTsAXVNNLZ@smile.fi.intel.com>
 <ZNUBvZQcbBbCziXU@smile.fi.intel.com>
 <20230811051121.GL11676@atomide.com>
 <ZNYAxb3eSJ63w7U9@smile.fi.intel.com>
 <ZNYA/JDs4cqC9CJn@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZNYA/JDs4cqC9CJn@smile.fi.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Fri, Aug 11, 2023 at 12:35:56PM +0300, Andy Shevchenko wrote:
> On Fri, Aug 11, 2023 at 12:35:01PM +0300, Andy Shevchenko wrote:
> > On Fri, Aug 11, 2023 at 08:11:21AM +0300, Tony Lindgren wrote:
> > > * Andy Shevchenko <andriy.shevchenko@intel.com> [230810 15:26]:
> > > > On Thu, Aug 10, 2023 at 06:24:13PM +0300, Andy Shevchenko wrote:
> > > > > On Thu, Aug 10, 2023 at 09:57:34AM +0300, Tony Lindgren wrote:

...

> > > > > > +	unsigned int min = 0, max = ~0U;
> > > > > 
> > > > > Shouldn't this be int? The max IIRC will be INT_MAX with this anyway.
> > > > 
> > > > Ah, and then you can supply is as 0 (IIRC).
> > > 
> > > The returned id will be INT_MAX, but idr.h uses unsigned int:
> > > 
> > > int ida_alloc_range(struct ida *, unsigned int min, unsigned int max, gfp_t);
> > > 
> > > If there's some reason to limit max id we can do it, otherwise it's just
> > > a don't care flag.
> > > 
> > > Please clarify if I'm not following what you are suggesting :)
> > 
> > 	... max = 0;
> > 
> > Will have the same effect with more explicit intention "use whatever maximum is
> > default". With ~0U I would expect to see something bigger than INT_MAX, but it
> > won't ever appear.
> 
> You can put a comment on top
> 
> 	/* Use 0 for max to apply IDA defaults */

Hmm... Looking into the implementation code it seems better to have

	/* Use -1 for max to apply IDA defaults */
	int min = 0, max = -1;

And supply like that.

-- 
With Best Regards,
Andy Shevchenko