Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 11 Aug 2023 13:13:40 +0530
From:   Dhruva Gole <d-gole@ti.com>
To:     Nishanth Menon <nm@ti.com>
CC:     Stephen Boyd <sboyd@kernel.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-pm@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
        Vibhore Vardhan <vibhore@ti.com>
Subject: Re: [PATCH V4 1/2] dt-bindings: opp: Convert ti-omap5-opp-supply to
 json schema
Message-ID: <20230811074340.jspxuw6zeaxdh2yf@dhruva>
References: <20230811031458.957624-1-nm@ti.com>
 <20230811031458.957624-2-nm@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230811031458.957624-2-nm@ti.com>
Precedence: bulk

On Aug 10, 2023 at 22:14:57 -0500, Nishanth Menon wrote:
> Rename ti-omap5-opp-supply to be bit more generic omap-opp-supply and
> convert the free text binding to json-schema.
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> Changes since V3:
> * Rewrote the description of the binding to something more relevant to
>   current style of documentation.
> 
> V3: https://lore.kernel.org/all/20230809023045.1870410-2-nm@ti.com/
> V2: https://lore.kernel.org/all/20230801233341.1416552-2-nm@ti.com/
> V1: https://lore.kernel.org/all/20230724153911.1376830-5-nm@ti.com/
> 
>  .../bindings/opp/ti,omap-opp-supply.yaml      | 106 ++++++++++++++++++
>  .../bindings/opp/ti-omap5-opp-supply.txt      |  63 -----------
>  2 files changed, 106 insertions(+), 63 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/opp/ti,omap-opp-supply.yaml
>  delete mode 100644 Documentation/devicetree/bindings/opp/ti-omap5-opp-supply.txt
> 
> diff --git a/Documentation/devicetree/bindings/opp/ti,omap-opp-supply.yaml b/Documentation/devicetree/bindings/opp/ti,omap-opp-supply.yaml
> new file mode 100644
> index 000000000000..25a0cb5ec6ff
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/opp/ti,omap-opp-supply.yaml
> @@ -0,0 +1,106 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/opp/ti,omap-opp-supply.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments OMAP compatible OPP supply
> +
> +description:
> +  OMAP5, DRA7, and AM57 families of SoCs have Class 0 AVS eFuse
> +  registers, which contain OPP-specific voltage information tailored
> +  for the specific device. This binding provides the information
> +  needed to describe such a hardware values and relate them to program
> +  the primary regulator during an OPP transition.
> +
> +  Also, some supplies may have an associated vbb-supply, an Adaptive
> +  Body Bias regulator, which must transition in a specific sequence
> +  w.r.t the vdd-supply and clk when making an OPP transition. By
> +  supplying two regulators to the device that will undergo OPP
> +  transitions, we can use the multi-regulator support implemented by
> +  the OPP core to describe both regulators the platform needs. The
> +  OPP core binding Documentation/devicetree/bindings/opp/opp-v2.yaml
> +  provides further information (refer to Example 4 Handling multiple

Thanks, this makes it much more clear to me :)

Reviewed-by: Dhruva Gole <d-gole@ti.com>

> +  regulators).
> +
> +maintainers:
> +  - Nishanth Menon <nm@ti.com>
> +
[...]

-- 
Best regards,
Dhruva Gole <d-gole@ti.com>