Received: by 2002:a05:7412:6592:b0:d7:7d3a:4fe2 with SMTP id m18csp900286rdg; Fri, 11 Aug 2023 03:46:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGi7UfdMc29nFvcFMHM+w6Zx97J02tuu8xfA4vPBOp6DJgJROvqLL8/bcWjLXNylXVUhlHH X-Received: by 2002:a17:906:7491:b0:992:c8d7:b66f with SMTP id e17-20020a170906749100b00992c8d7b66fmr1293135ejl.75.1691750804582; Fri, 11 Aug 2023 03:46:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691750804; cv=none; d=google.com; s=arc-20160816; b=vo1tkppar2XIJJktEU9JB5cli+4wvpIBCOZnh0MZCJsI7ly9MROXPP1TxAngjCLMqi ls7GAZnB25HrIMOg2JvfIW4t3LRMtVyJ0fhzroxlDAsSdpmi5oeWxjRC16byNB1Xo/cC JyuMMeWxHjjATRrFoFz4t+FPETlDdoEk393vPh6j6oVzQ4OHQ7B9gjciUKkY+gfGlnf5 sGDGbwN5to+0A06Docb3+4/mWgGCi2FSakEF8Fp7dizs3/p6q6++cSwC5/Os4ZUAg9sV Gzxm452O+ek9f3eMEjc3fdbQzzIsxxqpctWuCV9SXcdh6x2KlFzzQAGxY7LQ+oWoErZa kg1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=IPcNBxWbf7XiaVb6q57SobH5MiQ7WDSS0Xgm9ME9EVA=; fh=woJdKc7Pl3s0sbPZtV5BBTGBSGnywl1OxnpFPlU6R+Y=; b=OcblzL0OsZJ824SnwNu2FjhgbB7VflKbzoI+809pJA9VUPnqS8dX4U6krjSijghu0U OVrkSCckE5O4+0Es97qW4lUv5zoGKgFXggBOAnim7l7OYYbE2PAhZFpQ0jxCiUa6rp23 BmEaW2Yyzj+UPMLzHcBK3GMzQ7dNT+p+9NnI7f8yt4X/R9wvETEbdgbTU0uKc+lOvISC OlIkbTq7/COAkBf4R2P0uCH4MFqmNmEFxOO0rg92IQtnKjJVYeJBnQ3+So/pEq8QwKtb g/hNC/aOT5u8nYPczzoCkH8dbTz07kyTrgrmeEysmy8SVv4D9Z8Sl3T77DCk5WkLUwOY O8oA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=CXI8dxjS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a21-20020a1709062b1500b00991cbb3d4a6si3173062ejg.115.2023.08.11.03.46.17; Fri, 11 Aug 2023 03:46:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=CXI8dxjS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234454AbjHKJfJ (ORCPT + 99 others); Fri, 11 Aug 2023 05:35:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230478AbjHKJfH (ORCPT ); Fri, 11 Aug 2023 05:35:07 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0210126BC; Fri, 11 Aug 2023 02:35:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691746507; x=1723282507; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=30FA1fvKG5fhZ6OZRVeFBPQmbmKp7z1629d+RxTdjE8=; b=CXI8dxjSm3KZggL8O3drWaQ+nZ0twgrcMsN16yC+cEfsQom56giMluiH maKp3Pw0vHre76/hniiEG2d6E3iWQktXOzyAZMbB55AFLsfbiM/LaaaNX bT/kX0X1dXjEFrxLHfBaXuzKApcOzC8TWTmVYamH5EjH5T6dfWQhuPq32 VUiMWnldUZGdbV9rQUB+xbFnkeJhtfT/g24b4SZHqy0mIPVXlJYPsU34F Vioq2mFL183mJ59PDIxZlJwrtxSm10UYP7B7w8qR275OqE9CTJYCjh/+Y AEM+Je8j1diLZt58edJsKLOlVLVJNujgmHHDeLhrZ0QfiLyKZ5qT7Aln5 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10798"; a="458012637" X-IronPort-AV: E=Sophos;i="6.01,165,1684825200"; d="scan'208";a="458012637" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2023 02:35:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10798"; a="979183085" X-IronPort-AV: E=Sophos;i="6.01,165,1684825200"; d="scan'208";a="979183085" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga006.fm.intel.com with ESMTP; 11 Aug 2023 02:35:03 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qUOXt-008lwF-1P; Fri, 11 Aug 2023 12:35:01 +0300 Date: Fri, 11 Aug 2023 12:35:01 +0300 From: Andy Shevchenko To: Tony Lindgren Cc: Greg Kroah-Hartman , Jiri Slaby , Dhruva Gole , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , John Ogness , Johan Hovold , Sebastian Andrzej Siewior , Vignesh Raghavendra , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Guenter Roeck Subject: Re: [PATCH] serial: core: Fix serial core port id, including multiport devices Message-ID: References: <20230810065737.47294-1-tony@atomide.com> <20230811051121.GL11676@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230811051121.GL11676@atomide.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 11, 2023 at 08:11:21AM +0300, Tony Lindgren wrote: > * Andy Shevchenko [230810 15:26]: > > On Thu, Aug 10, 2023 at 06:24:13PM +0300, Andy Shevchenko wrote: > > > On Thu, Aug 10, 2023 at 09:57:34AM +0300, Tony Lindgren wrote: ... > > > > + unsigned int min = 0, max = ~0U; > > > > > > Shouldn't this be int? The max IIRC will be INT_MAX with this anyway. > > > > Ah, and then you can supply is as 0 (IIRC). > > The returned id will be INT_MAX, but idr.h uses unsigned int: > > int ida_alloc_range(struct ida *, unsigned int min, unsigned int max, gfp_t); > > If there's some reason to limit max id we can do it, otherwise it's just > a don't care flag. > > Please clarify if I'm not following what you are suggesting :) ... max = 0; Will have the same effect with more explicit intention "use whatever maximum is default". With ~0U I would expect to see something bigger than INT_MAX, but it won't ever appear. -- With Best Regards, Andy Shevchenko