Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <cover.1691607526.git.mehdi.djait.k@gmail.com> <8fb74f21bda4949a862bcb4bb1ed4f0acb135948.1691607526.git.mehdi.djait.k@gmail.com>
 <ZNYDa+Un5bl5y9vT@smile.fi.intel.com>
In-Reply-To: <ZNYDa+Un5bl5y9vT@smile.fi.intel.com>
From:   Mehdi Djait <mehdi.djait.k@gmail.com>
Date:   Fri, 11 Aug 2023 12:01:23 +0200
Message-ID: <CAFukWp2w2KwE+Obt1DWTcT81DbN7FdMNVo2Q7MSvjNi=_0uBRA@mail.gmail.com>
Subject: Re: [PATCH v7 5/7] iio: accel: kionix-kx022a: Refactor driver and add
 chip_info structure
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     jic23@kernel.org, mazziesaccount@gmail.com,
        krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
        lars@metafoo.de, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hello Andy,

Thank you for the review.

On Fri, Aug 11, 2023 at 11:46=E2=80=AFAM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Wed, Aug 09, 2023 at 09:11:36PM +0200, Mehdi Djait wrote:
> > Add the chip_info structure to the driver's private data to hold all
> > the device specific infos.
> > Refactor the kx022a driver implementation to make it more generic and
> > extensible.
>
> ...
>
> > +     chip_info =3D device_get_match_data(&i2c->dev);
> > +     if (!chip_info) {
> > +             const struct i2c_device_id *id =3D i2c_client_get_device_=
id(i2c);
>
> Missing blank line.
>
> > +             chip_info =3D (const struct kx022a_chip_info *)id->driver=
_data;
> > +             if (!chip_info)
> > +                     return -EINVAL;
> > +     }
>
> ...
>
> > -     if (val > KX022A_FIFO_LENGTH)
> > -             val =3D KX022A_FIFO_LENGTH;
> > +     val =3D min_t(unsigned int, data->chip_info->fifo_length, val);
>
> min_t() is a beast. Please, use min() if no special requirement for
> min_t() here, otherwise explain why.

No actual reason, you suggested min_t or min for a previous version

>
> ...
>
> > +     data->fifo_buffer =3D kmalloc(data->chip_info->fifo_length *
> > +                                 KX022A_FIFO_SAMPLES_SIZE_BYTES, GFP_K=
ERNEL);
>
> kmalloc_array()

Should I send another version for this ?
The usage of kmalloc is quite straightforward and easy to understand here.

--
Kind Regard
Mehdi Djait