Received: by 2002:a05:7412:6592:b0:d7:7d3a:4fe2 with SMTP id m18csp928412rdg; Fri, 11 Aug 2023 04:45:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEaboK+uRyIettgnOWDKoKmVWb846hvCorexfwE0/bTGP9kWLwj1O71Acxjddb8YAZKlyvI X-Received: by 2002:a05:6a00:10cd:b0:64d:5b4b:8429 with SMTP id d13-20020a056a0010cd00b0064d5b4b8429mr1288283pfu.18.1691754343882; Fri, 11 Aug 2023 04:45:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691754343; cv=none; d=google.com; s=arc-20160816; b=cTKU/tZIqeDmi3N+9wRpE4wEtCJhFo6c95qHwkHZ60e3Z/ZMlt6fwMYxlmHW1VLfas FObWJeqoUIgnC8pQUPYfcbeKSnyvfHBWwLAdwTTdCtNdAmcdfwA5Ga98YEtksgakmL7x VFhbofVTov1IkpyMdNQDYGnNVS8r3LYcoF0vr/bjluVZA30ZiYS2teQeIIlfS3qcI5d6 Qihjypsyqkw9PBVNnk1DV1pFrilS5WhSnnWjC0TtdGioQSxNeyshFg4UIPSVrBBiIphQ 6Y6SNaKbxqkpq445ARWHnDQBSTeag8jz6B3gwUBmOA0E6fW66PsisA5w/r9p6EQ58YFB W9TQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=bzxPTOIMXMlc+twimewXSVorRDRF4sKvqm0xOaxb4XA=; fh=P/bYNe0OGKXRhFoFTSFV1YXYq/gRT1td8SDqMxv4KI0=; b=vWCd9HZx4jYs85rUGdfDaWarRpaklFQF0qStv00LLN2s1Y+T6JTX7+67crE4e0qx94 ASUAmI46FgQ0sJyDhcX0Z9cLTixRcL8Dqd6rVr912yB15Rs2uuzkoViLQMEGwkB8jyDM hQDiGfEWSNfwz7HItg3A0tvGc7tpcBQofRZua78Pld9R2oqPP0EMwgo+dnWV0yGW7OkP VhyFw39xAqo8JJOfWlaRP5Y/dLaH3M9YilKoXbwBDVEB6eMug1QGVGZT2J9Ogc9+3xq8 TVugflCpQmhfmuJY9nFbqTtzWMWmrP4Cyh6XsElhX9m6o8zG28gXp+0KGCN3AfHrQXLI t9UA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=alien8 header.b=jgzdtE2G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e16-20020a056a001a9000b006874f410d77si3380607pfv.93.2023.08.11.04.45.32; Fri, 11 Aug 2023 04:45:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=alien8 header.b=jgzdtE2G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231426AbjHKK2H (ORCPT + 99 others); Fri, 11 Aug 2023 06:28:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230230AbjHKK2F (ORCPT ); Fri, 11 Aug 2023 06:28:05 -0400 Received: from mail.alien8.de (mail.alien8.de [IPv6:2a01:4f9:3051:3f93::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E65E6CE for ; Fri, 11 Aug 2023 03:28:04 -0700 (PDT) Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 2355840E01A1; Fri, 11 Aug 2023 10:28:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Authentication-Results: mail.alien8.de (amavisd-new); dkim=pass (4096-bit key) header.d=alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id AJOhFDPKpFef; Fri, 11 Aug 2023 10:28:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1691749680; bh=bzxPTOIMXMlc+twimewXSVorRDRF4sKvqm0xOaxb4XA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jgzdtE2G/xlrF2lvHxAqY7Y4LMfiowDypsiZncOn2ej/BQSoEelKcrGCsdK2nLEof cUundY0OoNtbORT3rPsiJxPVvrm2pFF+XgAxizl9KSjtIZcSoBNNqPTeZP79yxjY9/ 6hozYpZnHbwOlOh3p4B6/BdL6I6Iq0dn62ZptuUCDDkCzpy5XGJHaBBoBGRFLtmpHz sfidFS4jn/hC0LP8bIUilN4JqiHe4ROq868cINAEZBQsD6AEmf/9BQtwIVReV1T5Y8 VXhXQbgzoQrZSYJDIK4zlz96rtzpZnMuEOqkUBfVg+rbisKow/p4lNDUhCpKzvCjCN 3UGBQ+PWxEBnaPpe1ANH4nJM8/OYCoOC59wDOAcH2MdNMCdwIDJdNom80DXUCMvQC0 rxni04vgQoyoQicF1zMc1MVfnSl7j9UKhJqWQeigf9MXXl6klnBPuHmLTo88yqkyQ7 7KAOgGxj5UnPRWJuvrnFMNpJc5aP9gu31XqFA9jWSy8+XTIWqKTwMf0oQml2kVQ0yh i7Yo2tgjMYpQi71tCvRktpAJmCtqXZyV15O/HHWp+aa0DwDpVEsM9kVV5p+z4ZBAkw 2RqQI7r7tL3fs1FKsdvQgctxPbxk9DP8lJRuyqED/KaCg64zIfZ14qK91TKsuXUQRP +td83DZXihYuOWrpR6GwymyQ= Received: from zn.tnic (pd9530d32.dip0.t-ipconnect.de [217.83.13.50]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 439DA40E0194; Fri, 11 Aug 2023 10:27:53 +0000 (UTC) Date: Fri, 11 Aug 2023 12:27:48 +0200 From: Borislav Petkov To: Josh Poimboeuf Cc: Peter Zijlstra , x86@kernel.org, linux-kernel@vger.kernel.org, David.Kaplan@amd.com, Andrew.Cooper3@citrix.com, gregkh@linuxfoundation.org Subject: Re: [RFC][PATCH 06/17] x86/cpu: Add SRSO untrain to retbleed= Message-ID: <20230811102748.GEZNYNJEeDxTqcOLvj@fat_crate.local> References: <20230809071218.000335006@infradead.org> <20230809072200.850338672@infradead.org> <20230810154404.GOZNUFxHxLIMth6j9s@fat_crate.local> <20230810161003.i65d37ozlt3d5xse@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230810161003.i65d37ozlt3d5xse@treble> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 10, 2023 at 12:10:03PM -0400, Josh Poimboeuf wrote: > I tend to agree that SRSO is a new issue and should have its own sysfs > and cmdline options (though a separate CONFIG option is overkill IMO). Yeah, there's a patch floating around adding a config option for every mitigation. Apparently people want to build-time disable them all. > The mitigations are unfortunately intertwined, but we've been in that > situation several times before (e.g., spectre_v2 + intel retbleed). Yap. And if you recall, keeping Intel Retbleed from AMD Retbleed apart was already a PITA at the time so adding yet another one behind that flag would be madness. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette