Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <a1974520-8341-cca1-866c-c24777b3ae0a@roeck-us.net>
Date:   Fri, 11 Aug 2023 05:20:23 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v1] watchdog: intel-mid_wdt: add MODULE_ALIAS() to allow
 auto-load
Content-Language: en-US
To:     Raag Jadav <raag.jadav@intel.com>, wim@linux-watchdog.org,
        mika.westerberg@linux.intel.com, andriy.shevchenko@linux.intel.com
Cc:     linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
        mallikarjunappa.sangannavar@intel.com, pandith.n@intel.com
References: <20230811120220.31578-1-raag.jadav@intel.com>
From:   Guenter Roeck <linux@roeck-us.net>
In-Reply-To: <20230811120220.31578-1-raag.jadav@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/11/23 05:02, Raag Jadav wrote:
> When built with CONFIG_INTEL_MID_WATCHDOG=m, currently the driver
> needs to be loaded manually, for the lack of module alias.
> This causes unintended resets in cases where watchdog timer is
> set-up by bootloader and the driver is not explicitly loaded.
> Add MODULE_ALIAS() to load the driver automatically at boot and
> avoid this issue.
> 
> Fixes: 87a1ef8058d9 ("watchdog: add Intel MID watchdog driver support")
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   drivers/watchdog/intel-mid_wdt.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/watchdog/intel-mid_wdt.c b/drivers/watchdog/intel-mid_wdt.c
> index 9b2173f765c8..fb7fae750181 100644
> --- a/drivers/watchdog/intel-mid_wdt.c
> +++ b/drivers/watchdog/intel-mid_wdt.c
> @@ -203,3 +203,4 @@ module_platform_driver(mid_wdt_driver);
>   MODULE_AUTHOR("David Cohen <david.a.cohen@linux.intel.com>");
>   MODULE_DESCRIPTION("Watchdog Driver for Intel MID platform");
>   MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:intel_mid_wdt");